https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
> LGTM. It may be a good idea to move these APIs over to use std::optional
> instead of taking a default value so we can use 'value_or' instead of having
> to write logic to handle the default value through a parameter.
My goal is fixing the regression in this diff. I will
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM. It may be a good idea to move these APIs over to use std::optional
instead of taking a default value so we can use 'value_or' instead of having to
write logic to handle the default value through a parameter.
https://github.com/llvm
https://github.com/kusmour approved this pull request.
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -57,7 +57,7 @@ llvm::StringRef GetString(const llvm::json::Object *obj,
llvm::StringRef key,
llvm::StringRef defaultValue) {
if (obj == nullptr)
return defaultValue;
- return GetString(*obj, key);
walter-erquinigo wrote:
ow
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
https://github.com/llvm/llvm-project/pull/69238 caused breakage in VSCode debug
console usage -- the user's input is always treated as commands instead of
expressions (the same behavior as if empty command escap
https://github.com/jeffreytan81 ready_for_review
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/72902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/72902
https://github.com/llvm/llvm-project/pull/69238 caused breakage in VSCode debug
console usage -- the user's input is always treated as commands instead of
expressions (the same behavior as if empty command
14 matches
Mail list logo
