https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 18812772780abee17dd106e0e8f8c78ab8d4dbf1 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 8 Mar 2024 14:46:13 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
big fan, LGTM
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,7 +12,7 @@
target var a
# CHECK-LABEL: target var a
# FIXME: This should also produce some kind of an error.
-# CHECK: (A) a = {}
+# CHECK: (A) a =
Michael137 wrote:
nice!
https://github.com/llvm/llvm-project/pull/84265
___
adrian-prantl wrote:
Found two more tests that were (positively) affected by this change!
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 78866b8977b655109d85bd1c231b1659c5c90c8a Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 8 Mar 2024 14:46:13 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 9b02d004a3aec681047d47cb481a269637bdd9fc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 8 Mar 2024 14:46:13 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 934ad65f660a43917ec66861127230c68c697743 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 8 Mar 2024 14:46:13 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/84265
>From 76d65446227d18f4f3c4675b1aa12678037dff8c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 6 Mar 2024 16:21:14 -0800
Subject: [PATCH] Report back errors in GetNumChildren()
This is a proof-of-c
adrian-prantl wrote:
Rebased
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> From looking at the code, it seems like there are two clear classes of users,
> those that need to check the error, and those that, in the error case, 0 is
> just as good as the error. The latter appears not infrequently as:
>
> `llvm::expectedToStdOptional(value_sp->Get
jimingham wrote:
>From looking at the code, it seems like there are two clear classes of users,
>those that need to check the error, and those that, in the error case, 0 is
>just as good as the error. The latter appears not infrequently as:
`llvm::expectedToStdOptional(value_sp->GetNumChildre
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85
cb496e138b46732de73d0e56b2bfc3f749355953 --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85...cb496e138b46732de73d0e56b2bfc3f749355953
lldb/
adrian-prantl wrote:
```
Ran command:
"v -ptr-depth 1 x"
Got output:
(Opaque *) x = 0x00018000
```
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This is a proof-of-concept patch that illustrates how to use the
Expected return values to surface rich error messages all the way up
to the ValueObjectPrinter.
This is the final patch in the series tha
18 matches
Mail list logo
