JDevlieghere wrote:
I've reverted this because it breaks a bunch of tests:
https://lab.llvm.org/buildbot/#/builders/68/builds/69018
https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/16273
Please keep an eye on the bots when relanding this.
https://github.com/llvm/llvm-project/pull/
https://github.com/kusmour closed
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/81706
>From 70d3c80aa73ef10284c6615ac9e5e73ff38a5245 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 5 Feb 2024 11:33:03 -0800
Subject: [PATCH 1/4] Only report total currently loaded debug info
---
lldb/include/ll
https://github.com/clayborg approved this pull request.
You can remove the headerdoc in the SymbolFileDWARF.h file and this is good to
go.
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -186,7 +186,19 @@ class SymbolFileDWARF : public SymbolFileCommon {
GetMangledNamesForFunction(const std::string &scope_qualified_name,
std::vector &mangled_names) override;
- uint64_t GetDebugInfoSize() override;
+ /// Get total currently l
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/81706
>From 0fec0afdbcfcb896a45c4ba837331aa2c0349f02 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 5 Feb 2024 11:33:03 -0800
Subject: [PATCH 1/4] Only report total currently loaded debug info
---
lldb/include/ll
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/81706
>From 0fec0afdbcfcb896a45c4ba837331aa2c0349f02 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 5 Feb 2024 11:33:03 -0800
Subject: [PATCH 1/4] Only report total currently loaded debug info
---
lldb/include/ll
https://github.com/kusmour edited
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/81706
>From 0fec0afdbcfcb896a45c4ba837331aa2c0349f02 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 5 Feb 2024 11:33:03 -0800
Subject: [PATCH 1/4] Only report total currently loaded debug info
---
lldb/include/ll
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/81706
>From 0fec0afdbcfcb896a45c4ba837331aa2c0349f02 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 5 Feb 2024 11:33:03 -0800
Subject: [PATCH 1/4] Only report total currently loaded debug info
---
lldb/include/ll
https://github.com/bulbazord commented:
Idea looks ok, the naming could use a bit of work. Right now it feels a bit
generic and I'm not sure what "loading" means. I like Greg's suggestion here.
https://github.com/llvm/llvm-project/pull/81706
___
lldb-
@@ -224,6 +224,7 @@ llvm::json::Value DebuggerStats::ReportStatistics(
const lldb_private::StatisticsOptions &options) {
const bool summary_only = options.summary_only;
+ const bool force_laoding = options.force_loading;
bulbazord wrote:
typo in this o
@@ -1419,6 +1419,10 @@ let Command = "statistics dump" in {
def statistics_dump_all: Option<"all-targets", "a">, Group<1>,
Desc<"Include statistics for all targets.">;
def statistics_dump_summary: Option<"summary", "s">, Group<1>,
-Desc<"Dump only high-level summary
@@ -391,7 +392,14 @@ class SymbolFile : public PluginInterface {
/// entire file should be returned. The default implementation of this
/// function will iterate over all sections in a module and add up their
/// debug info only section byte sizes.
- virtual uint64_t Get
@@ -186,7 +186,19 @@ class SymbolFileDWARF : public SymbolFileCommon {
GetMangledNamesForFunction(const std::string &scope_qualified_name,
std::vector &mangled_names) override;
- uint64_t GetDebugInfoSize() override;
+ /// Get total currently l
@@ -132,6 +132,7 @@ struct ConstStringStats {
struct StatisticsOptions {
bool summary_only = false;
+ bool force_loading = false;
clayborg wrote:
Maybe `load_all_debug_info` is more clear?
https://github.com/llvm/llvm-project/pull/81706
__
@@ -24,6 +24,9 @@ class LLDB_API SBStatisticsOptions {
void SetSummaryOnly(bool b);
bool GetSummaryOnly();
+
+ void SetForceLoading(bool b);
clayborg wrote:
Need headerdoc for these.
https://github.com/llvm/llvm-project/pull/81706
@@ -24,6 +24,9 @@ class LLDB_API SBStatisticsOptions {
void SetSummaryOnly(bool b);
bool GetSummaryOnly();
+
+ void SetForceLoading(bool b);
+ bool GetForceLoading();
clayborg wrote:
The `SetForceLoading` name doesn't clearly indicate to us what we ar
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
61c83e9491b2be71a54b255cdb11f65365245953...497b0a76501923afc169922c3aab9e92fb00c511
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 61c83e9491b2be71a54b255cdb11f65365245953
497b0a76501923afc169922c3aab9e92fb00c511 --
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/81706
>From 8cfd1ee9629ce8069cc8fe8f4150e9fc0f5d5ee6 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 5 Feb 2024 11:33:03 -0800
Subject: [PATCH 1/3] Only report total currently loaded debug info
---
lldb/include/ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Wanyi (kusmour)
Changes
Currently running `statistics dump` will trigger lldb to load debug info that's
not yet loaded (eg. dwo files). Resulted in a delay in the command return,
which, can be interrupting.
This patch also added a new opt
https://github.com/kusmour created
https://github.com/llvm/llvm-project/pull/81706
Currently running `statistics dump` will trigger lldb to load debug info that's
not yet loaded (eg. dwo files). Resulted in a delay in the command return,
which, can be interrupting.
This patch also added a new
25 matches
Mail list logo
