[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-02 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/71128 The current Darwin arm64e ABI on AArch64 systems using ARMv8.3 & newer cores, adds authentication bits to the vtable pointer address. The vtable address must be in addressable memory, so running it through

[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The current Darwin arm64e ABI on AArch64 systems using ARMv8.3 & newer cores, adds authentication bits to the vtable pointer address. The vtable address must be in addressable memory, so running it thro

[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'm assuming lack of new tests is because testing is running existing tests on arm64e. LGTM. https://github.com/llvm/llvm-project/pull/71128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/71128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/71128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/71128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-03 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > I'm assuming lack of new tests is because testing is running existing tests > on arm64e. LGTM. Yeah, lldb can't get the dynamic type in any function that takes a base class argument but a subclass object is passed in (and they have virtual functions), there's tests for t

[Lldb-commits] [lldb] Strip authentication bits from vtable load address (PR #71128)

2023-11-03 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/71128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits