Author: Jordan Rupprecht
Date: 2021-03-09T10:57:00-08:00
New Revision: b4825a6d9c18bdb3e241d709f2f76573aba9f91b

URL: 
https://github.com/llvm/llvm-project/commit/b4825a6d9c18bdb3e241d709f2f76573aba9f91b
DIFF: 
https://github.com/llvm/llvm-project/commit/b4825a6d9c18bdb3e241d709f2f76573aba9f91b.diff

LOG: [lldb][gui] Fix uninitialized variable in SourceFileWindowDelegate.

After 5419b671375c46299ff1da6c929859040e7beaf5 (which is `[SimplifyCFG] Update 
FoldTwoEntryPHINode to handle and/or of select and binop equally`), this 
uninitialized value is detected by msan.

Added: 
    

Modified: 
    lldb/source/Core/IOHandlerCursesGUI.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Core/IOHandlerCursesGUI.cpp 
b/lldb/source/Core/IOHandlerCursesGUI.cpp
index e76a0bc16f75..a1c9daa79be7 100644
--- a/lldb/source/Core/IOHandlerCursesGUI.cpp
+++ b/lldb/source/Core/IOHandlerCursesGUI.cpp
@@ -3392,10 +3392,10 @@ class SourceFileWindowDelegate : public WindowDelegate {
   SourceFileWindowDelegate(Debugger &debugger)
       : WindowDelegate(), m_debugger(debugger), m_sc(), m_file_sp(),
         m_disassembly_scope(nullptr), m_disassembly_sp(), 
m_disassembly_range(),
-        m_title(), m_line_width(4), m_selected_line(0), m_pc_line(0),
-        m_stop_id(0), m_frame_idx(UINT32_MAX), m_first_visible_line(0),
-        m_first_visible_column(0), m_min_x(0), m_min_y(0), m_max_x(0),
-        m_max_y(0) {}
+        m_title(), m_tid(LLDB_INVALID_THREAD_ID), m_line_width(4),
+        m_selected_line(0), m_pc_line(0), m_stop_id(0), 
m_frame_idx(UINT32_MAX),
+        m_first_visible_line(0), m_first_visible_column(0), m_min_x(0),
+        m_min_y(0), m_max_x(0), m_max_y(0) {}
 
   ~SourceFileWindowDelegate() override = default;
 


        
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to