Author: Jim Ingham Date: 2023-07-17T10:52:29-07:00 New Revision: b9541b6707715b8ea07b47f453f001e698195b3e
URL: https://github.com/llvm/llvm-project/commit/b9541b6707715b8ea07b47f453f001e698195b3e DIFF: https://github.com/llvm/llvm-project/commit/b9541b6707715b8ea07b47f453f001e698195b3e.diff LOG: Fix the root directory completion test. It was implicitly assumning that "/" would have no files in it, only directories. That's not true, for instance on macOS if you've navigated to the root directory in the Finder... Since we're assuming everything we check against is a directory, then we need to filter the completion for that coming in. Added: Modified: lldb/test/API/functionalities/completion/TestCompletion.py Removed: ################################################################################ diff --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py index 4b413260279b9c..74fb83071ad4af 100644 --- a/lldb/test/API/functionalities/completion/TestCompletion.py +++ b/lldb/test/API/functionalities/completion/TestCompletion.py @@ -485,7 +485,7 @@ def test_completion_target_create_from_root_dir(self): "target create " + root_dir, list( filter( - lambda x: os.path.exists(x), + lambda x: os.path.exists(x) and os.path.isdir(x), map(lambda x: root_dir + x + os.sep, os.listdir(root_dir)), ) ), _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
