On 21/04/2021 22:13, Shafik Yaghmour wrote:
Having side effects in the argument to a function call just feels like a bad
idea in general even if it seems obviously correct here e.g.
++last_symbol_id,
Can’t we just do:
uint64_t last_symbol_id =
num_symbols ?
Having side effects in the argument to a function call just feels like a bad
idea in general even if it seems obviously correct here e.g.
++last_symbol_id,
Can’t we just do:
uint64_t last_symbol_id =
num_symbols ? symbol_table->SymbolAtIndex(num_symbols - 1)->GetID() + 1:
1;
Thank
Author: Pavel Labath
Date: 2021-04-21T11:24:43+02:00
New Revision: cd64273f5ed39ec697ff1e20a1fe25ebd3502629
URL:
https://github.com/llvm/llvm-project/commit/cd64273f5ed39ec697ff1e20a1fe25ebd3502629
DIFF:
https://github.com/llvm/llvm-project/commit/cd64273f5ed39ec697ff1e20a1fe25ebd3502629.diff
