Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

I think the issue is that on OS X, GetScalarValue fails to return false when the value is *not* actually scalar. When it's not scalar, it should be using WriteMemory instead, right? Or is it possible for GetScalarValue to succeed but return something with a different byte size? On Mon, Feb 29,

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Sorry about the breakage, and thanks for working on a patch Chaoren. Hopefully Marianne will revise her merge request if this fix is still important for her. On 28/02/2016 00:06, Todd Fiala wrote: I brought the state of the lines changed there to what they were prior to the change. If you

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

I brought the state of the lines changed there to what they were prior to the change. If you adjusted those same lines, then yes that got undone. We were failing different tests in those files. Your change may have fixed the new issues on Linux, but did not address the new failures on OS X.

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

I thought I fixed it with http://reviews.llvm.org/D17658. Did you revert that as well? On Sat, Feb 27, 2016 at 3:14 PM, Todd Fiala wrote: > Hi all, > > The new assert was failing on the OS X testbot here: > http://lab.llvm.org:8080/green/job/lldb_build_test/ > > The nag

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Hi all, The new assert was failing on the OS X testbot here: http://lab.llvm.org:8080/green/job/lldb_build_test/ The nag mail didn't make it to you since we have it only fire on the transition from good build to bad build, and Tamas had the privilege of earning that with a minor Xcode breakage

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Hmm. Weird. That assert is failing on Linux: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11833 On Fri, Feb 26, 2016 at 9:40 AM, Aidan Dodds via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: aidandodds > Date: Fri Feb 26 11:40:50 2016 > New Revision:

[Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Author: aidandodds Date: Fri Feb 26 11:40:50 2016 New Revision: 262041 URL: http://llvm.org/viewvc/llvm-project?rev=262041=rev Log: Fix bug with register values byte order in expression evaluation. The evaluation of expressions containing register values was broken for targets for which