Author: jingham
Date: Tue Apr 26 14:46:39 2016
New Revision: 267594
URL: http://llvm.org/viewvc/llvm-project?rev=267594&view=rev
Log:
UtilityFunction::MakeFunctionCaller uses the Error to report failure,
but when there's was no process it was just returning an null pointer
and not setting the error. I don't have a scenario where this might
go wrong, just code inspection...
Modified:
lldb/trunk/source/Expression/UtilityFunction.cpp
Modified: lldb/trunk/source/Expression/UtilityFunction.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/UtilityFunction.cpp?rev=267594&r1=267593&r2=267594&view=diff
==============================================================================
--- lldb/trunk/source/Expression/UtilityFunction.cpp (original)
+++ lldb/trunk/source/Expression/UtilityFunction.cpp Tue Apr 26 14:46:39 2016
@@ -77,7 +77,10 @@ UtilityFunction::MakeFunctionCaller (con
ProcessSP process_sp = m_jit_process_wp.lock();
if (!process_sp)
+ {
+ error.SetErrorString("Can't make a function caller without a
process.");
return nullptr;
+ }
Address impl_code_address;
impl_code_address.SetOffset(StartAddress());
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
