Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2018-06-01 Thread Pavel Labath via lldb-commits
wrote: > > On May 31, 10:31am, lab...@google.com (Pavel Labath) wrote: > -- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898 > > | I hate to resurrect an old thread, but there has been a new spurt of > | this discussion about this patch here > | <https://reviews.llvm.or

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2018-05-31 Thread Christos Zoulas via lldb-commits
On May 31, 10:31am, lab...@google.com (Pavel Labath) wrote: -- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898 | I hate to resurrect an old thread, but there has been a new spurt of | this discussion about this patch here | <https://reviews.llvm.org/rL303907>. | | I think

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2018-05-31 Thread Pavel Labath via lldb-commits
I hate to resurrect an old thread, but there has been a new spurt of this discussion about this patch here . I think I have an idea on how to improve things slightly for us here, but as I know very little about this issue, I'd like someone to take a look at this

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-06-19 Thread Christos Zoulas via lldb-commits
On May 29, 8:11pm, ulrich.weig...@de.ibm.com ("Ulrich Weigand") wrote: -- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898 | Sorry, this is on an internal IBM machine ... I don't have a publically | accessible machine to reproduce this on at the moment. I am so

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-06-19 Thread Christos Zoulas via lldb-commits
On May 30, 6:02pm, ulrich.weig...@de.ibm.com ("Ulrich Weigand") wrote: -- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898 | Hmm, from looking at the version of libedit I'm using it would | appear that it should correctly handle either: | - a narrow char read function instal

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-05-30 Thread Ulrich Weigand via lldb-commits
chris...@zoulas.com (Christos Zoulas) wrote on 30.05.2017 17:46:58: > I am sorry to say that this is my fault and this sucks. I accepted > some patches that broke binary compatibility in a way that it is not > user visible. Basically you seem to have version of libedit that is > between the

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-05-29 Thread Ulrich Weigand via lldb-commits
Kamil Rytarowski wrote on 29.05.2017 18:10:36: > Do you offer shell account? I don't have Linux and/or s390x to debug it. Sorry, this is on an internal IBM machine ... I don't have a publically accessible machine to reproduce this on at the moment. I managed to debug a bit

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-05-29 Thread Kamil Rytarowski via lldb-commits
Do you offer shell account? I don't have Linux and/or s390x to debug it. On 29.05.2017 17:17, Ulrich Weigand via lldb-commits wrote: > Hello, > > It appears this commit broke the > EditlineTestFixture.EditlineReceivesSingleLineText > unit test on s390x-linux. The test now simply hangs (hanging

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-05-29 Thread Ulrich Weigand via lldb-commits
Hello, It appears this commit broke the EditlineTestFixture.EditlineReceivesSingleLineText unit test on s390x-linux. The test now simply hangs (hanging the whole test suite execution) ... Mit freundlichen Gruessen / Best Regards Ulrich Weigand -- Dr. Ulrich Weigand | Phone:

[Lldb-commits] [lldb] r303907 - Fix bug #28898

2017-05-25 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Thu May 25 15:12:30 2017 New Revision: 303907 URL: http://llvm.org/viewvc/llvm-project?rev=303907=rev Log: Fix bug #28898 lldb: libedit produces garbled, unusable input on Linux Apply patch from Christos Zoulas, upstream libedit developer. It has been tested on NetBSD/amd64.