Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

I posted a patch that should fix this in https://reviews.llvm.org/D56798 . thanks for your feedback! -- adrian ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

Note that the PDB code runs on all platforms, not just Windows. You can reproduce it by just running the affected test on darwin, as long as you've built lld. On Wed, Jan 16, 2019 at 8:50 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > On 16/01/2019 17:38, Adrian Prantl

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

On 16/01/2019 17:38, Adrian Prantl wrote: On Darwin I'm getting an also very misleading (lldb) target var ref (void (&)(bool)) ref = 0x00010920 (&::ref = ) Wait, no. I reverted the wrong patch:-( I get vs . I assume that's what's happening on Windows, too. If that's the case I should

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

> On Jan 16, 2019, at 8:36 AM, Adrian Prantl via lldb-commits > wrote: > >> >> On Jan 16, 2019, at 4:22 AM, Pavel Labath wrote: >> >> Hi Adrian, Zachary, >> >> this commit breaks the SymbolFile/NativePDB/function-types-builtins.cpp test >>

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

> On Jan 16, 2019, at 4:22 AM, Pavel Labath wrote: > > Hi Adrian, Zachary, > > this commit breaks the SymbolFile/NativePDB/function-types-builtins.cpp test > . This > is due do a slight behavioral change where previously thi

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

Hi Adrian, Zachary, this commit breaks the SymbolFile/NativePDB/function-types-builtins.cpp test . This is due do a slight behavioral change where previously this function would consider a value 0 from GetByteSize to be fail

[Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

Author: adrian Date: Tue Jan 15 13:26:03 2019 New Revision: 351250 URL: http://llvm.org/viewvc/llvm-project?rev=351250&view=rev Log: Simplify Value::GetValueByteSize() Modified: lldb/trunk/source/Core/Value.cpp Modified: lldb/trunk/source/Core/Value.cpp URL: http://llvm.org/viewvc/llvm-proj