Author: teemperor Date: Tue Apr 16 01:06:56 2019 New Revision: 358479 URL: http://llvm.org/viewvc/llvm-project?rev=358479&view=rev Log: Fix typo in ArmUnwindInfo::GetUnwindPlan
Summary: As reported in LLVM bug 41486, the check `(byte1 & 0xf8) == 0xc0` is wrong. We want to check for `11010nnn`, so the proper value we want to compare against is `0xd0` (`0xc0` would check for the value `11000nnn` which we already checked for above as described in the bug report). Reviewers: #lldb, jasonmolenda Reviewed By: #lldb, jasonmolenda Subscribers: jasonmolenda, javed.absar, kristof.beyls, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D60655 Modified: lldb/trunk/source/Symbol/ArmUnwindInfo.cpp Modified: lldb/trunk/source/Symbol/ArmUnwindInfo.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ArmUnwindInfo.cpp?rev=358479&r1=358478&r2=358479&view=diff ============================================================================== --- lldb/trunk/source/Symbol/ArmUnwindInfo.cpp (original) +++ lldb/trunk/source/Symbol/ArmUnwindInfo.cpp Tue Apr 16 01:06:56 2019 @@ -304,7 +304,7 @@ bool ArmUnwindInfo::GetUnwindPlan(Target // 11001yyy // Spare (yyy != 000, 001) return false; - } else if ((byte1 & 0xf8) == 0xc0) { + } else if ((byte1 & 0xf8) == 0xd0) { // 11010nnn // Pop VFP double-precision registers D[8]-D[8+nnn] saved (as if) by // FSTMFDD (see remark d) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits