Re: [Lldb-commits] Support of MSVC function-level linking

2018-05-31 Thread Adrian McCarthy via lldb-commits
Can you post your patch to https://reviews.llvm.org/ ? On Thu, May 31, 2018 at 10:36 AM, Leonard Mosescu via lldb-commits < lldb-commits@lists.llvm.org> wrote: > If anyone's working on this I'd suggest adding a test case for the "split > code" case as well (where even a single function is split i

Re: [Lldb-commits] Support of MSVC function-level linking

2018-05-31 Thread Leonard Mosescu via lldb-commits
If anyone's working on this I'd suggest adding a test case for the "split code" case as well (where even a single function is split into multiple ranges). MSVC with PGO should help produce hot/cold cold split repros. On Thu, May 31, 2018 at 10:24 AM, Greg Clayton via lldb-commits < lldb-commits@li

Re: [Lldb-commits] Support of MSVC function-level linking

2018-05-31 Thread Greg Clayton via lldb-commits
> On May 31, 2018, at 2:31 AM, Aleksandr Urakov via lldb-commits > wrote: > > Hello! > > I'm Aleksandr from JetBrains. We are working on improving support of > MSVC-compiled binaries in lldb. We have made several fixes and would like to > upstream them. > > The first patch adds support of

[Lldb-commits] Support of MSVC function-level linking

2018-05-31 Thread Aleksandr Urakov via lldb-commits
Hello! I'm Aleksandr from JetBrains. We are working on improving support of MSVC-compiled binaries in lldb. We have made several fixes and would like to upstream them. The first patch adds support of function-level linking feature. The SymbolFilePDB::ParseCompileUnitLineTable function relies on