Re: [Lldb-commits] Use explicit delete in DISALLOW_COPY_AND_ASSIGN

2016-09-27 Thread Zachary Turner via lldb-commits
Not sure why operator= is returning a const&. It doesn't matter in practice but it's a bit strange. Anyway lgtm On Tue, Sep 27, 2016 at 7:11 PM Daniel Austin Noland via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Explicit delete is preferable to declaring a method private when > your inte

[Lldb-commits] Use explicit delete in DISALLOW_COPY_AND_ASSIGN

2016-09-27 Thread Daniel Austin Noland via lldb-commits
Explicit delete is preferable to declaring a method private when your intention is to prevent that method from ever being used. * better compiler error messages * can't be bypassed by friendship * clearer intent This was discussed here: http://lists.llvm.org/pipermail/lldb-dev/2016-Septembe