Author: Charles Zablit
Date: 2025-06-13T08:16:09-07:00
New Revision: 6751b3a549ebef78a7e75b100d61742c20945592
URL:
https://github.com/llvm/llvm-project/commit/6751b3a549ebef78a7e75b100d61742c20945592
DIFF:
https://github.com/llvm/llvm-project/commit/6751b3a549ebef78a7e75b100d61742c20945592.diff
https://github.com/kstoimenov closed
https://github.com/llvm/llvm-project/pull/144054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kstoimenov approved this pull request.
Original PR broke a bunch of Sanitizers bots:
https://lab.llvm.org/buildbot/#/builders/85/builds/9827. I will merge that
revert.
https://github.com/llvm/llvm-project/pull/144054
___
lldb-comm
DavidSpickett wrote:
https://github.com/llvm/llvm-project/issues/144077 for the terminal closing.
It's not related to this change.
I had to disable two of the tests that try to read a closed file descriptor. MS
CRT validates the fd before it reads it and this leads to a software breakpoint
/
Author: David Spickett
Date: 2025-06-13T14:26:06Z
New Revision: 82911f188be7ce7cb0a04b7fd648ea8b4aad2e59
URL:
https://github.com/llvm/llvm-project/commit/82911f188be7ce7cb0a04b7fd648ea8b4aad2e59
DIFF:
https://github.com/llvm/llvm-project/commit/82911f188be7ce7cb0a04b7fd648ea8b4aad2e59.diff
LOG
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/144119
Today we can run `target modules dump separate-debug-info --json` to get a json
blob of all the separate debug info, but it has a few shortcomings when
developing some scripting against it. Namely, the caller h
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Today we can run `target modules dump separate-debug-info --json` to get a json
blob of all the separate debug info, but it has a few shortcomings when
developing some scripting against it. Namely, the calle
Jlalond wrote:
@jasonmolenda tagged you because I think you're the relevant SME, but feel free
to reassign otherwise.
https://github.com/llvm/llvm-project/pull/144119
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/ashgti commented:
Looking at this locally, I think this is changing:
```
0x01234 ff ff ff ff NSLog: pacibsp
...
```
into:
```
0x01234 ff ff ff ff pacibsp ; NSLog
...
```
When other functions are called, they have the name in the comment, so you'd see
```
0x01234
ashgti wrote:
> If this is a feature you actually rely on, we should check the fd is valid
> before we use it. As in: check and if it's invalid early return an error,
> instead of getting all the way to reading from it.
The start of the `ReadFull` helper is checking `IsValid()`:
```
static Ex
JDevlieghere wrote:
@ashgti AFAIK that only checks if the file descriptor is a valid number (i.e.
>= 0) not whether the underlying FD is actually valid. On POSIX we definitely
do check that and return an `llvm::Error` but maybe on Windows that's missing.
https://github.com/llvm/llvm-project/pu
Author: Jonas Devlieghere
Date: 2025-06-13T10:02:41-07:00
New Revision: 2704b27a0b452f4aaf87ab26d315fdc92857373a
URL:
https://github.com/llvm/llvm-project/commit/2704b27a0b452f4aaf87ab26d315fdc92857373a
DIFF:
https://github.com/llvm/llvm-project/commit/2704b27a0b452f4aaf87ab26d315fdc92857373a.d
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/144070
putting the function name is the dissassembly instruction messes up the
alignment making it less readable. put it instead with the comment.
This also aligns the opcodes and instruction to the left matching th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
putting the function name is the dissassembly instruction messes up the
alignment making it less readable. put it instead with the comment.
This also aligns the opcodes and instruction to the left matching t
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/144072
Take 2.
uses the `SendTargetCapabilityes` from #142831
>From c4d909a9bb25983a955254956d3f0dab2ecc284f Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Thu, 12 Jun 2025 12:48:24 +0100
Subject: [PATCH] [lldb-d
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/144072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
Take 2.
uses the `SendTargetCapabilities` from #142831
---
Full diff: https://github.com/llvm/llvm-project/pull/144072.diff
10 Files Affected:
- (modified) lldb/packages/Python/lldbsuite/test/tools/lldb-d
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/143633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/144153
>From e54b23052c17efd61297db619c355749d51e34c6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 13 Jun 2025 11:58:27 -0700
Subject: [PATCH 1/2] [lldb-dap] Creating protocol types for
setExceptionBreakpoin
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/144177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/144177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/144177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/144177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/144177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/144177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
>From what I can tell, you have the lldb_private API's you are adding return a
>StringMap because it facilitates building a list where each unique
>file spec appears only once. Other than that, I can't see you make any use of
>the StringMap-ness of the data you return.
That
https://github.com/ashgti commented:
Would it be worth it to include a file in lldb/docs/resources about running
this? For folks wanting to get started trying this out?
Maybe in a follow up PR.
https://github.com/llvm/llvm-project/pull/143628
___
lld
@@ -0,0 +1,72 @@
+//===- Tool.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,131 @@
+//===- Protocol.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,280 @@
+//===- ProtocolServerMCP.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,131 @@
+//===- Protocol.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,280 @@
+//===- ProtocolServerMCP.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,280 @@
+//===- ProtocolServerMCP.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,13 @@
+add_lldb_library(lldbPluginProtocolServerMCP PLUGIN
ashgti wrote:
Should this be behind a build flag?
I could see some distributions disabling this feature for security reasons.
Once an MCP server is running, it can run arbitrary commands in t
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/143628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
Just one nit in the less than operator.
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -45,9 +49,16 @@ struct Range {
friend bool operator==(const Range &lhs, const Range &rhs) {
return lhs.start == rhs.start && lhs.range_ref == rhs.range_ref;
}
+
+ friend bool operator<(const Range &lhs, const Range &rhs) {
+return lhs.start < rhs.start;
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/143628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/143628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
Reading more about this in the VSCode docs and on the MCP website I think I
understand the flow of logic a bit more.
I think this is definitely helpful for allowing an agent to help control a
debug session.
However, I'm still not sure how we should handle the MCP client and debu
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -10,10 +10,10 @@
# Test plugin list without an argument will list all plugins.
plugin list
# CHECK-LABEL: plugin list
-# CHECK: system-runtime
-# CHECK: [+] systemruntime-macosx System runtime plugin for Mac OS
X native libraries
# CHECK: instrumentation-runtime
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This PR adds an MCP (Model Context Protocol ) server to LLDB. For motivation
and background, please refer to the corresponding RFC:
https://discourse.llvm.org/t/rfc-adding-mcp-support-to-lldb/86798
JDevlieghere wrote:
I'm adding the folks that chimed in on the RFC as reviewers.
https://github.com/llvm/llvm-project/pull/143628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/143628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/143628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/143628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dmpots updated
https://github.com/llvm/llvm-project/pull/143970
>From 10f527ddd5b3defc3e7ceef8c5a00ffba9f77b74 Mon Sep 17 00:00:00 2001
From: David Peixotto
Date: Thu, 12 Jun 2025 11:17:53 -0700
Subject: [PATCH 1/4] Use PluginInstances instead of vector for Architecuture
plu
@@ -10,10 +10,10 @@
# Test plugin list without an argument will list all plugins.
plugin list
# CHECK-LABEL: plugin list
-# CHECK: system-runtime
-# CHECK: [+] systemruntime-macosx System runtime plugin for Mac OS
X native libraries
# CHECK: instrumentation-runtime
https://github.com/dmpots edited
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dmpots wrote:
I'll wait a few more days before merging in case someone wants to add more
feedback.
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/dmpots edited
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dmpots edited
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -39,6 +41,8 @@ class ExceptionBreakpoint {
std::string m_filter;
std::string m_label;
lldb::LanguageType m_language;
+ bool m_is_throw;
+ bool m_is_catch;
ashgti wrote:
Sure, created an enum. Thats hopefully more clear than the set of bools.
https:
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/143628
>From 3c1cb491ab014714866335f8de451c2bf7e7ca01 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Jun 2025 16:33:55 -0700
Subject: [PATCH] [lldb] Add MCP support to LLDB
https://discourse.llvm.
https://github.com/clayborg commented:
This seems ok, but we should get some ok from the owners or contributors to the
`llvm/lib/TargetParser/Triple.cpp` file.
https://github.com/llvm/llvm-project/pull/143633
___
lldb-commits mailing list
lldb-commit
clayborg wrote:
> The reason is that those files don't have load commands like
> `LC_BUILD_VERSION` or `LC_VERSION_MIN_*`
What kind of files don't have this `LC_VERSION_MIN_*` set? That seems like the
bug we should be fixing.
https://github.com/llvm/llvm-project/pull/143633
__
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From 8608a949e6579f9ee69961ceabf8158a6b91b208 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
chelcassanova wrote:
Just updated this patch to:
- Remove changes to `SBStream` and `Stream`
- Change the setting name to `disable-ansi-prefix`
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/144153
This adds new types for setExceptionBreakpoints and adds support for
`supportsExceptionFilterOptions`, which allows exception breakpoints to set a
condition.
While testing this, I noticed that obj-c exception c
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds new types for setExceptionBreakpoints and adds support for
`supportsExceptionFilterOptions`, which allows exception breakpoints to set a
condition.
While testing this, I noticed that obj-c exceptio
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/143633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/143633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/143633
>From d01f75f4b8f75676ae15730f0035cca685dc5195 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 3 Jun 2025 17:04:29 -0700
Subject: [PATCH 1/5] Set default object format. Add test.
---
.../ObjectFile/Mach-O/O
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/143633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
royitaqi wrote:
Hi @jasonmolenda ,
If/when you have the time, could you kindly review and also help me check if
this patch breaks any tests on a x86_64 macOS machine? I don't have such a
machine at hand.
I have checked that nothing is broken on Linux and aarch64 macOS.
Thanks,
Roy
https://
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/144177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From e948fcf7a890d3ebcde5eb3586577099ba4ee2c0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/143633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/143633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I've been thinking about this too. I think you're right to distinguish two use
cases:
1. Interacting with an existing debug session. For example you've started
debugging in VS Code with DAP and you want your AI assistant to interact with
the debug session.
2. Starting a n
https://github.com/royitaqi created
https://github.com/llvm/llvm-project/pull/144177
**Context**: See previous attempts: #142704, #143633
**Problem**: When `ObjectFileMachO` parses a Mach-O file (including yaml data
in lldb unit tests) which doesn't have load commands like `LC_BUILD_VERSION` o
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (royitaqi)
Changes
**Context**: See previous attempts: #142704, #143633
**Problem**: When `ObjectFileMachO` parses a Mach-O file (including yaml data
in lldb unit tests) which doesn't have load commands like `LC_BUILD_VERSION` or
`LC
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/19295
Here is the relevant piece of the b
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/144036
We now bubble up the expression evaluation diagnostics to the user and also
distinguish between "expression failed to parse/run" versus other ways in which
expressions didn't complete (e.g., setup errors, et
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
We now bubble up the expression evaluation diagnostics to the user and also
distinguish between "expression failed to parse/run" versus other ways in which
expressions didn't complete (e.g., setup errors,
Author: David Spickett
Date: 2025-06-13T09:12:01Z
New Revision: 06c783567069db169ee2d1545a4bd3ffd0e3fec0
URL:
https://github.com/llvm/llvm-project/commit/06c783567069db169ee2d1545a4bd3ffd0e3fec0
DIFF:
https://github.com/llvm/llvm-project/commit/06c783567069db169ee2d1545a4bd3ffd0e3fec0.diff
LOG
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/144036
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ilia Kuklin
Date: 2025-06-13T16:31:25+05:00
New Revision: 4236423ee863be5903819db57205fc83a4bd21e1
URL:
https://github.com/llvm/llvm-project/commit/4236423ee863be5903819db57205fc83a4bd21e1
DIFF:
https://github.com/llvm/llvm-project/commit/4236423ee863be5903819db57205fc83a4bd21e1.diff
L
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/141422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-06-13T12:43:27+01:00
New Revision: 41b37f05554ae59974675ae219430b5598c6159f
URL:
https://github.com/llvm/llvm-project/commit/41b37f05554ae59974675ae219430b5598c6159f
DIFF:
https://github.com/llvm/llvm-project/commit/41b37f05554ae59974675ae219430b5598c6159f.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/144036
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
da-viper wrote:
> okay, so would something like this be sufficient to reproduce the issue (you
> can put the functions in different files as needed):
This should be reproducable but I am not sure if it is the same problem,
because it now skips `fn2` line completely regardless if it is complied
labath wrote:
> It still seems pretty aggressive to log all LLDB_LOG_ERROR messages to the
> console, but this is a stop-gap until we want to do something about it.
I said as much on the PR, and still think it's too aggressive to send all these
errors to the system log.
> Looks like this er
@@ -105,6 +105,21 @@ protocol::Source CreateSource(lldb::SBAddress address,
lldb::SBTarget &target) {
return CreateSource(line_entry.GetFileSpec());
}
+protocol::Source CreateSource(lldb::SBFrame frame) {
+ if (!frame.IsValid())
+return {};
+
+ const lldb::SBTarget ta
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/143644
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/141577
>From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001
From: DhruvSrivastavaX
Date: Tue, 27 May 2025 05:44:55 -0500
Subject: [PATCH 1/7] Added XCOFF ParseSymtab handling
---
.../Objec
DhruvSrivastavaX wrote:
Thats true. Created new ones.
https://github.com/llvm/llvm-project/pull/141577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/141577
>From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001
From: DhruvSrivastavaX
Date: Tue, 27 May 2025 05:44:55 -0500
Subject: [PATCH 1/7] Added XCOFF ParseSymtab handling
---
.../Objec
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This fixes the error reported in
https://github.com/llvm/llvm-project/pull/144037.
When computing the aranges table of a CU, LLDB would currently visit all
`DW_TAG_subprogram` DIEs and check their `DW_AT_l
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/144059
This fixes the error reported in
https://github.com/llvm/llvm-project/pull/144037.
When computing the aranges table of a CU, LLDB would currently visit all
`DW_TAG_subprogram` DIEs and check their `DW_AT_low
Michael137 wrote:
> > It still seems pretty aggressive to log all LLDB_LOG_ERROR messages to the
> > console, but this is a stop-gap until we want to do something about it.
>
> I said as much on the PR, and still think it's too aggressive to send all
> these errors to the system log.
@JDevlie
labath wrote:
Yeah, that sounds like a bug. A different one that what you are fixing, but I
think it's kind of related, as now the stepping machinery who concludes it has
stepped "into" fn2 (and then decides to step out of it). I've filed #144061 to
track that.
Would it work if we replace the
https://github.com/labath approved this pull request.
Looks good. I don't think the test is very useful. Since all it tests is a
negative, the test could be easily invalidated (e.g. by changing the error
string), and we would never notice.
You can keep it if you want, but I'd be fine with this
Michael137 wrote:
Yea that's fair. I'll remove the test and just add a comment in the source
https://github.com/llvm/llvm-project/pull/144059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
Nerixyz wrote:
> I've described a use case a couple times already. If you have a client-server
> architecture, it would be really nice to be able to debug both the client and
> the server in the same lldb process, because then you can add tooling on top
> of lldb to do things like "step in acr
DavidSpickett wrote:
Timed out on the very first build :rofl:
On second thought this test is better disabled. It's more correct than it was,
but it's never going to be truly stable.
https://github.com/llvm/llvm-project/commit/06c783567069db169ee2d1545a4bd3ffd0e3fec0
https://github.com/llvm/l
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/144037
Currently `LLDB_LOG_ERROR` always logs to the "always-on" channel (which prints
to the console; this started with
https://github.com/llvm/llvm-project/pull/111911).
Attaching to LLDB spams the console with
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Currently `LLDB_LOG_ERROR` always logs to the "always-on" channel (which prints
to the console; this started with
https://github.com/llvm/llvm-project/pull/111911).
Attaching to LLDB spams the console wit
1 - 100 of 125 matches
Mail list logo
