[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-09-03 Thread via lldb-commits
athierry-oct wrote: Sorry for the long delay, I'm back from vacation and tackling this issue in parallel with other tasks. I've started investigating the other failing tests (such as the DAP tests). For all failing tests, it seems essentially the root cause is the same: moving events between

[Lldb-commits] [lldb] [llldb][test] Mark a DWO test unsupported on Darwin and Windows (PR #156306)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This uses split DWARF and from looking at other tests, it should not be running on Darwin or Windows. It does pass using the DIA PDB plugin but I think this is misleading because it's not actually te

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Sorry for the delay, long weekend here in the US. Ok, I think I finally got it working, mostly? I was facing two issues: 1) `v` gets confused by what we were doing, but `expr` doesn't; 2) Older versions of LLDB would fail to find the symbol -- even with expr -- after `tar

[Lldb-commits] [lldb] [lldb] Use weak pointers instead of shared pointers in DynamicLoader (PR #156446)

2025-09-03 Thread Andrew Savonichev via lldb-commits
asavonic wrote: @jimingham, @JDevlieghere, thanks to your suggestions in #147289, I was able to use existing LLDB API to completely release some modules from the cache, but keep other modules intact. However, this approach did not work completely, because `DynamicLoaderWindowsDYLD` kept module

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/2] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [mlir] [openmp] Fix typos and spelling errors across codebase (PR #156270)

2025-09-03 Thread Tom Eccles via lldb-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/156270 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-09-03 Thread via lldb-commits
https://github.com/kusmour approved this pull request. lgtm just need to clear the test error https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb][test] Use lld on Windows in frame format test (PR #156320)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes link.exe discards DWARF information. Other linkers on non-Windows do not. Uses the same solution as TestFrameFunctionInlined.test. This test was failing with the native PDB plugin but shouldn't have b

[Lldb-commits] [lldb] [LLDB] Complete constant array member types in class members (PR #156370)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: Actually, what you want to do is probably just call `TypeSystemClang::RequireCompleteType` on the element type. This is basically what the PDB plugin does: ``` https://github.com/llvm/llvm-project/blob/6042e090fac8b06d64666348fe4ca6ca6e4f77db/lldb/source/Plugins/SymbolFile/PDB

[Lldb-commits] [lldb] [LLDB] Add unary plus and minus to DIL (PR #155617)

2025-09-03 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/155617 >From 4d14bbb31d0411c45b95778d1659ccc416165be1 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Aug 2025 19:11:55 +0500 Subject: [PATCH 1/6] [LLDB] Add unary plus and minus to DIL --- lldb/include/lldb/V

[Lldb-commits] [clang] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From 5d75d1679d492df1a72c4013afde052f7b6195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 18 Aug 2025 15:12:45 +0100 Subject: [PATCH 1/6] [llvm][DebugInfo] Support DW_AT_linkage_names that are di

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-09-03 Thread Pavel Labath via lldb-commits
labath wrote: I think it'd be better to not do that. HandleCommand does that because it has no idea what events are going to be produced by the command it runs. In case of EvaluateExpression, it feels like there ought to be a way which events are going to be produced and consumed, and I think

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-09-03 Thread Anthony Eid via lldb-commits
@@ -9,6 +9,7 @@ #ifndef LLDB_TOOLS_LLDB_DAP_JSONUTILS_H #define LLDB_TOOLS_LLDB_DAP_JSONUTILS_H +#include "DAP.h" Anthony-Eid wrote: I removed it https://github.com/llvm/llvm-project/pull/124232 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-09-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/155061 >From eff269a2c869b3a3c73ed0198f3b749fd914b2aa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 22 Aug 2025 19:34:57 -0700 Subject: [PATCH 1/5] [lldb] Add Pythonic API to SBStructuredData extension * Impl

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -0,0 +1,21 @@ +{ +"triple": "replace me", +"uuid": "replace me", +"type": "executable", +"sections": [ +{ +"name": "__DATA", +"type": "data", felipepiovezan wrote: I think I need to make this test run only on

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame affordance (PR #149622)

2025-09-03 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/149622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [mlir] [openmp] [NFC][CMake] quote ${CMAKE_SYSTEM_NAME} consistently (PR #154537)

2025-09-03 Thread Amy Kwan via lldb-commits
https://github.com/amy-kwan milestoned https://github.com/llvm/llvm-project/pull/154537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Your guess is right. Enabling `log enable lldb expr`, we can see the IR generated for `expr get_high_bits(&myglobal_json)` ``` @"_ZGVZ12$__lldb_exprPvE19$__lldb_expr_result" = internal global i8 0, align 1 ; Function Attrs: convergent noinline nounwind optnone define void

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [mlir] [openmp] Fix typos and spelling errors across codebase (PR #156270)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Austin Jiang (AustinBoyuJiang) Changes Corrected various spelling mistakes such as 'occurred', 'receiver', 'initialized', 'length', and others in comments, variable names, function names, and documentation throughout the proje

[Lldb-commits] [lldb] [LLDB][NativePDB] Complete array member types in AST builder (PR #156370)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/156370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Find global variables in namespaces (PR #156736)

2025-09-03 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/156736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Find global variables in namespaces (PR #156736)

2025-09-03 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/156736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-09-03 Thread Ziyi Wang via lldb-commits
https://github.com/zw3917 updated https://github.com/llvm/llvm-project/pull/155023 >From d978cb5b17b7a8450226825a8fd85f2054166059 Mon Sep 17 00:00:00 2001 From: Ziyi Wang Date: Fri, 22 Aug 2025 09:17:25 -0700 Subject: [PATCH 1/7] [lldb] Add count for errors of DWO files in statistics --- lldb

[Lldb-commits] [lldb] [LLDB][NativePDB] Find global variables in namespaces (PR #156736)

2025-09-03 Thread Zequan Wu via lldb-commits
@@ -306,6 +309,9 @@ class SymbolFileNativePDB : public SymbolFileCommon { lldb_private::UniqueCStringMap m_func_base_names; /// method basename -> Global ID(s) lldb_private::UniqueCStringMap m_func_method_names; + + /// basename -> Global ID(s) ZequanWu

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-09-03 Thread Ziyi Wang via lldb-commits
https://github.com/zw3917 updated https://github.com/llvm/llvm-project/pull/155023 >From d978cb5b17b7a8450226825a8fd85f2054166059 Mon Sep 17 00:00:00 2001 From: Ziyi Wang Date: Fri, 22 Aug 2025 09:17:25 -0700 Subject: [PATCH 1/7] [lldb] Add count for errors of DWO files in statistics --- lldb

[Lldb-commits] [lldb] [lldb] Reimplement __str__ in SBStructuredDataExtensions.i (PR #156725)

2025-09-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/156725 Follow up to #155061 and #156721. After discussing with @medismailben, the ideal course of to have a `__str__`, however, instead of throwing an exception, the fallback behavior calls `__repr__` (`GetDescrip

[Lldb-commits] [lldb] [lldb] Reimplement __str__ in SBStructuredDataExtensions.i (PR #156725)

2025-09-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/156725 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add count for errors of DWO files in statistics and combine DWO file count functions (PR #155023)

2025-09-03 Thread Ziyi Wang via lldb-commits
https://github.com/zw3917 edited https://github.com/llvm/llvm-project/pull/155023 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revert custom __str__ in SBStructuredDataExtensions.i (PR #156721)

2025-09-03 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while building `lldb` at step 6 "test-build-unified-tree-check-cross-project". Full details are available at: https://lab.llvm.org/buildbot/#/builders/163/bui

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The LLVM Style Guide says the following about error and warning messages [1]: > [T]o match error message styles commonly produced by other tools, > start the first sentence with a lowercase letter, a

[Lldb-commits] [lldb] [LLDB][AArch64] Make TPIDR a generic tp register (PR #154444)

2025-09-03 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @DavidSpickett Please take a second look when you get a chance https://github.com/llvm/llvm-project/pull/15 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Set IsDynmaicCXXType metadata for records (PR #155853)

2025-09-03 Thread Zequan Wu via lldb-commits
@@ -601,21 +601,26 @@ PdbAstBuilder::CreateModifierType(const ModifierRecord &modifier) { } clang::QualType PdbAstBuilder::CreateRecordType(PdbTypeSymId id, -const TagRecord &record) { +

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't complete conflicting Objective-C++ types (PR #156681)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 milestoned https://github.com/llvm/llvm-project/pull/156681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't complete conflicting Objective-C++ types (PR #156681)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: /cherry-pick a862225813c251c28b085603b7d32d4b111dbc57 https://github.com/llvm/llvm-project/pull/156681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Mark scripted frames as synthetic instead of artificial (PR #153117)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/153117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't complete conflicting Objective-C++ types (PR #156681)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/156681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Expression] Reject languages not supported by TypeSystems for expression evaluation (PR #156648)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes There are some languages for which the `ClangExpressionParser` currently switches the language type behind a user's back. Specifically, `C` gets turned into `C++` and `ObjC` into `ObjC++`. That's because t

[Lldb-commits] [lldb] [lldb] Reimplement __str__ in SBStructuredDataExtensions.i (PR #156725)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes Follow up to #155061 and #156721. After discussing with @medismailben, the ideal course of to have a `__str__`, however, instead of throwing an exception, the fallback behavior calls `__repr__` (`GetDescript

[Lldb-commits] [lldb] [llvm] Add AArch64 support to the premerge tests (PR #155274)

2025-09-03 Thread Tom Stellard via lldb-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/155274 >From 57697a66cfdddf2028c7260f1ce61ecacc550d00 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Mon, 25 Aug 2025 17:15:36 + Subject: [PATCH 01/57] Add AArch64 support to the premerge tests --- .github/wo

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame affordance (PR #149622)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch introduces a new scripting affordance in lldb: `ScriptedFrame`. This allows user to produce mock stackframes in scripted threads and scripted processes from a python script. With this ch

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-03 Thread Roy Shi via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/156803 # Usage ``` --time-to-live When using --connection, the number of milliseconds to wait for new connections at the beginning and after all clients have disconnected. Not specifying

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Roy Shi (royitaqi) Changes # Usage ``` --time-to-live When using --connection, the number of milliseconds to wait for new connections at the beginning and after all clients have disconnected. Not specifyin

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-03 Thread Aiden Grossman via lldb-commits
@@ -13,3 +13,15 @@ config.name = "lldb" config.test_source_root = os.path.dirname(__file__) config.test_exec_root = os.path.join(config.lldb_obj_root, "test") + +# We prefer the lit internal shell which provides a better user experience on +# failures and is faster unless the u

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-09-03 Thread Igor Kudrin via lldb-commits
@@ -688,6 +688,27 @@ def test_arm_core(self): values["lr"] = "0x000e" values["pc"] = "0x000f" values["cpsr"] = "0x0010" +for i in range(32): +values["s" + str(i)] = str(i) +values["fpscr"] = "0x12345678" +v

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame affordance (PR #149622)

2025-09-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r origin/main...HEAD lldb/examples/python/templates/scripted_process.py lldb/test/API/funct

[Lldb-commits] [lldb] [lldb] Add some vector operations to the IRInterpreter (PR #155000)

2025-09-03 Thread Daniel Sanders via lldb-commits
https://github.com/dsandersllvm updated https://github.com/llvm/llvm-project/pull/155000 >From be4ddf49a230b32699df153ecc3b2b3ee62c1c22 Mon Sep 17 00:00:00 2001 From: Daniel Sanders Date: Fri, 22 Aug 2025 10:54:52 -0700 Subject: [PATCH 1/7] [lldb] Add some vector operations to the IRInterpreter

[Lldb-commits] [lldb] [lldb][Expression] Reject languages not supported by TypeSystems for expression evaluation (PR #156648)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: > BTW, if this patch breaks that feature w/o some test catching it, we should > add a test for these allowed keywords. This patch doesn't break said feature. It only breaks if you explicitly pass `expression --language C`, and expect it to work. If it's a C frame, then `expr

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-03 Thread Aiden Grossman via lldb-commits
@@ -13,3 +13,15 @@ config.name = "lldb" config.test_source_root = os.path.dirname(__file__) config.test_exec_root = os.path.join(config.lldb_obj_root, "test") + +# We prefer the lit internal shell which provides a better user experience on +# failures and is faster unless the u

[Lldb-commits] [lldb] [lldb][Expression] Reject languages not supported by TypeSystems for expression evaluation (PR #156648)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156648 >From 5689f9e8489c66237097891e98aba93571f8583f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 3 Sep 2025 12:19:17 +0100 Subject: [PATCH 1/3] [lldb][Expression] Reject languages not supported by TypeS

[Lldb-commits] [lldb] [lldb][Expression] Reject languages not supported by TypeSystems for expression evaluation (PR #156648)

2025-09-03 Thread Michael Buch via lldb-commits
@@ -44,18 +44,21 @@ Status CommandObjectExpression::CommandOptions::SetOptionValue( const int short_option = GetDefinitions()[option_idx].short_option; switch (short_option) { - case 'l': + case 'l': { language = Language::GetLanguageTypeFromString(option_arg); -

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-09-03 Thread via lldb-commits
jimingham wrote: The only bad effect I can see just from looking at the patch is if I had selected frame 5 of a given thread, and then had run an expression. I want to make sure that when the expression is done running, we don't set the selected frame back to 0 (or whatever the most relevant

[Lldb-commits] [lldb] [lldb] Mark scripted frames as synthetic instead of artificial (PR #153117)

2025-09-03 Thread via lldb-commits
jimingham wrote: LGTM2 https://github.com/llvm/llvm-project/pull/153117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/156729 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 74b7e73 - [llldb][test] Mark a DWO test unsupported on Darwin and Windows (#156306)

2025-09-03 Thread via lldb-commits
Author: David Spickett Date: 2025-09-01T13:20:30+01:00 New Revision: 74b7e7352b47dd1a5fd8c02bce392027b4c035dc URL: https://github.com/llvm/llvm-project/commit/74b7e7352b47dd1a5fd8c02bce392027b4c035dc DIFF: https://github.com/llvm/llvm-project/commit/74b7e7352b47dd1a5fd8c02bce392027b4c035dc.diff

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [mlir] [openmp] Fix typos and spelling errors across codebase (PR #156270)

2025-09-03 Thread Carlos Galvez via lldb-commits
carlosgalvezp wrote: > we shouldn't discourage people from improving the codebase These are orthogonal issues. People are always welcome to improve the codebase, but small PRs are essential for a healthy codebase. And it will actually be **less* work for the author, because the patches will be

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [mlir] [openmp] Fix typos and spelling errors across codebase (PR #156270)

2025-09-03 Thread Paschalis Mpeis via lldb-commits
https://github.com/paschalis-mpeis approved this pull request. Thanks for the fixes. Directory `/bolt` LGTM. Please wait on other areas. https://github.com/llvm/llvm-project/pull/156270 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/156506 >From d9ede8035d1786a62375295fdb855fb2a08f0c72 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Wed, 16 Jul 2025 14:52:27 + Subject: [PATCH 1/2] [lldb][RISCV][test] make atomic region stepping test more r

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions c -- lldb/test/API/riscv/step/branch.c lldb/test/API/ri

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: In `lldb/test/API/riscv/step/incomplete_sequence_without_lr.c` you expect to land on `and a5, a2, a4`. There is another `and a5...` but has different 2nd and 3rd operands. There is a comment that refers to this but it almost looks like a typo. ``` // a step instruction a

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread David Spickett via lldb-commits
@@ -26,19 +26,26 @@ def do_sequence_test(self, filename, bkpt_name): substrs=["stopped", "stop reason = instruction step into"], ) -pc = cur_thread.GetFrameAtIndex(0).GetPC() +# Get the instruction we stopped at +pc = cur_thread.GetF

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/156506 >From d9ede8035d1786a62375295fdb855fb2a08f0c72 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Wed, 16 Jul 2025 14:52:27 + Subject: [PATCH 1/2] [lldb][RISCV][test] make atomic region stepping test more r

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Yes, in these tests, execution during the step is inside the inline assembly > block, so I hope the mnemonics will be stable. Understood. > This patch rewrites the test to avoid this disadvantage. The test now checks > the opcode of the instruction after the step instea

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: None (dlav-sc) Changes Currently, the tests that check stepping through atomic sequences use a hardcoded step distance, which is unreliable because this distance depends on LLVM's codegeneration. This patch rewrites the test to

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
@@ -11,6 +11,7 @@ void __attribute__((naked)) cas(int *a, int *b) { "xor a5, a2, a5\n\t" dlav-sc wrote: addressed https://github.com/llvm/llvm-project/pull/156506 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Assuming the comments are updated, this LGTM. Thanks for explaining the rationale, it does make sense to me now. One of these days I will take inspiration from this and finally fix these sequences for AArch64. https://github.com/llv

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: And btw does this mean you're running RISC-V tests semi-regularly? If so, glad to know someone is :) https://github.com/llvm/llvm-project/pull/156506 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -0,0 +1,19 @@ +#include +#include +#include + +int myglobal = 41; felipepiovezan wrote: It is used by the python expression evaluation, but given your other comments I'll remove it https://github.com/llvm/llvm-project/pull/153585 _

[Lldb-commits] [clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97443 >From 38b7837bcc5da9e89778191654f9552ebccacbd5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 2 Jul 2024 18:43:34 +0200 Subject: [PATCH 1/3] [clang][RecordLayoutBuilder] Be stricter about inferring pa

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/95100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -0,0 +1,19 @@ +#include +#include +#include + +int myglobal = 41; + +uint64_t get_high_bits(void *ptr) { + uint64_t mask = ~((1ULL << 48) - 1); + uint64_t ptrtoint = (uint64_t)ptr; + uint64_t high_bits = ptrtoint & mask; felipepiovezan wrote: my bad, I m

[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/119860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [WIP][lldb] Alternative implementation of more reliable function call infrastructure (PR #115245)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/115245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: Not needed, for now.. https://github.com/llvm/llvm-project/pull/119860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [WIP][lldb] Alternative implementation of more reliable function call infrastructure (PR #115245)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: Landed in https://github.com/llvm/llvm-project/pull/148877 https://github.com/llvm/llvm-project/pull/115245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 converted_to_draft https://github.com/llvm/llvm-project/pull/127829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: Landed in https://github.com/llvm/llvm-project/pull/148877 https://github.com/llvm/llvm-project/pull/114529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: @efriedma-quic @rjmccall ping Remembered about this while clearing out open PRs https://github.com/llvm/llvm-project/pull/97443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [clang] [lldb] [llvm] [WIP][lldb][Expression] More reliable function call resolution (PR #114529)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/114529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/153585 >From ce9c2cc6748c22ce4b0f5178b8f5e877d430 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 13 Aug 2025 18:38:23 -0700 Subject: [PATCH 1/7] [lldb] Call FixUpPointer in WritePointer

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
@@ -26,19 +26,26 @@ def do_sequence_test(self, filename, bkpt_name): substrs=["stopped", "stop reason = instruction step into"], ) -pc = cur_thread.GetFrameAtIndex(0).GetPC() +# Get the instruction we stopped at +pc = cur_thread.GetF

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: I've simplified the test as suggested. Also going to take your offer of testing/porting this on Linux :) It should hopefully be a simple platform check inside python followed by a json update like what we do for the triple/uuid. https://github.com/llvm/llvm-project/pull/1

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r origin/main...HEAD lldb/test/API/macosx/arm-pointer-metadata-stripping/TestArmPointerMetad

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM. @jasonmolenda anything to add? https://github.com/llvm/llvm-project/pull/153585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
dlav-sc wrote: > And btw does this mean you're running RISC-V tests semi-regularly? Yeah :) We have a close-source fork with ci, where RISCV lldb tests run after each commit. https://github.com/llvm/llvm-project/pull/156506 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't complete conflicting Objective-C++ types (PR #156681)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/156681 This upstreams https://github.com/swiftlang/llvm-project/pull/10313. If we detect a situation where a forward declaration is C++ and the definition DIE is Objective-C, then just don't try to complete the typ

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: Closing in favour of https://github.com/llvm/llvm-project/pull/156681 https://github.com/llvm/llvm-project/pull/130768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/130768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

2025-09-03 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/153585 >From ce9c2cc6748c22ce4b0f5178b8f5e877d430 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 13 Aug 2025 18:38:23 -0700 Subject: [PATCH 1/8] [lldb] Call FixUpPointer in WritePointer

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-03 Thread Corentin Jabot via lldb-commits
cor3ntin wrote: I'm still happy with this. I did not notice it was not merged https://github.com/llvm/llvm-project/pull/122265 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't complete conflicting Objective-C++ types (PR #156681)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This upstreams https://github.com/swiftlang/llvm-project/pull/10313. If we detect a situation where a forward declaration is C++ and the definition DIE is Objective-C, then just don't try to complete the t

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't complete conflicting Objective-C++ types (PR #156681)

2025-09-03 Thread Michael Buch via lldb-commits
Michael137 wrote: Planning to cherry-pick this to `release/21.x` if this lands https://github.com/llvm/llvm-project/pull/156681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/156506 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/133079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes When hitting a sanitizer breakpoint, LLDB currently displays the frame in the sanitizer dylib (which we usually don't have debug-info for), which isn't very helpful to the user. A more helpful frame to dis

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/133079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/133079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV][test] make atomic region stepping test more robust (PR #156506)

2025-09-03 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/156506 >From d9ede8035d1786a62375295fdb855fb2a08f0c72 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Wed, 16 Jul 2025 14:52:27 + Subject: [PATCH 1/3] [lldb][RISCV][test] make atomic region stepping test more r

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't complete conflicting Objective-C++ types (PR #156681)

2025-09-03 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/156681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From 6427b12a42c2064d57bc211443a5aa1e59fa81d9 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 3 Sep 2025 08:25:14 -0700 Subject: [PATCH] Add a bunch of mnemonics to the command options now that

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

2025-09-03 Thread David Blaikie via lldb-commits
dwblaikie wrote: Any word on this? Dead/can't be done? Lowered priority/might revisit later? Any conclusions/lessons that'd be handy to record for posterity? https://github.com/llvm/llvm-project/pull/95100 ___ lldb-commits mailing list lldb-commits@l

  1   2   >