[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/2] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/7] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/133079 >From 2314f9e584d736ce2093cc196c7c57c2087cde42 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 26 Mar 2025 12:54:36 + Subject: [PATCH 1/4] [lldb][Instrumentation] Set selected frame to outside san

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cc220b1 - [lldb] Mark UnsupportedLanguage.test Unsupported on Windows

2025-09-04 Thread Aiden Grossman via lldb-commits
Author: Aiden Grossman Date: 2025-09-04T13:53:37Z New Revision: cc220b1d55297b5939eb7eb197767a8b27aa71f8 URL: https://github.com/llvm/llvm-project/commit/cc220b1d55297b5939eb7eb197767a8b27aa71f8 DIFF: https://github.com/llvm/llvm-project/commit/cc220b1d55297b5939eb7eb197767a8b27aa71f8.diff LOG

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-09-04 Thread via lldb-commits
athierry-oct wrote: > in async mode that event should be propagated so that the process event > listener can fetch the event and so the public state gets correctly reset @jimingham currently the event is also propagated in sync mode (and this propagated event stays unprocessed forever). Should

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
@@ -61,3 +61,10 @@ def pre_init_command: S<"pre-init-command">, def: Separate<["-"], "c">, Alias, HelpText<"Alias for --pre-init-command">; + +def time_to_live: S<"time-to-live">, + MetaVarName<"">, + HelpText<"When using --connection, the number of milliseconds t

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/156774 >From 7e2901ba9171555b07a44a008e84f6811a95a64d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 3 Sep 2025 16:45:13 -0700 Subject: [PATCH] [lldb] Correct style of error messages The LLVM Style G

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Friendly ping https://github.com/llvm/llvm-project/pull/155705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
@@ -418,7 +418,7 @@ other command as far as there is only one alias command match."); if ((pos != std::string::npos) && (pos > 0)) raw_command_string = raw_command_string.substr(pos); } else { - result.AppendError("Error parsing command string. No alias

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Great! May be we should do this for: > > * `Status::Status(std::string err_str)` > * `static Status FromErrorString(const char *str)` > * `static Status FromErrorStringWithFormat(const char *format, ...)` > * `template static Status FromErrorStringWithFormatv(const > char

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via lldb-commits
Michael137 wrote: Latest commit narrows the heuristics so it specifically applies to `CallExpr`s generated for structured bindings. Here's what the AST looks like when stopped in `IgnoreImplicitCallSingleStep` for a structured binding: ``` (lldb) p E->dump()

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-09-04 Thread via lldb-commits
jimingham wrote: The latter. We have to send the event so that lldb will know that the expression stopped mid-way through. But process events have to be consumed to have any effect, so in sync mode EvaluateExpression should consume the event and then print the stop status. https://github.co

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Thanks for the feedback, I have made sure to keep the changes to a minimum in the new revision. https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Expression] Reject languages not supported by TypeSystems for expression evaluation (PR #156648)

2025-09-04 Thread Michael Buch via lldb-commits
Michael137 wrote: > How do we explain that for my global variable `class`, > > (lldb) expr class = 110 > > works when I happen to be stopped in a C frame, but if I can't find a C frame > around there's no way I can replicate that behavior? > How do we explain that for my global variable `clas

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/133078 >From 4a0d13ef2751071505ab797c63c2ee20d14a6c61 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 26 Mar 2025 13:20:24 + Subject: [PATCH 1/4] [lldb][Target] Clear selected frame index after a StopInf

[Lldb-commits] [lldb] [lldb] Use weak pointers instead of shared pointers in DynamicLoader (PR #156446)

2025-09-04 Thread Andrew Savonichev via lldb-commits
https://github.com/asavonic closed https://github.com/llvm/llvm-project/pull/156446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-09-04 Thread Omair Javaid via lldb-commits
omjavaid wrote: @slydiman https://github.com/llvm/llvm-project/issues/156861 has been report. https://github.com/llvm/llvm-project/pull/155939 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 01/13] [clang][DebugInfo] Expand detection of structured bindin

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 01/10] [clang][DebugInfo] Expand detection of structured bindin

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-09-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/155956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-09-04 Thread David Spickett via lldb-commits
@@ -696,6 +696,31 @@ def test_arm_core(self): self.expect("register read --all") +@skipIfLLVMTargetMissing("ARM") +def test_arm_core_vfp(self): +# check reading VFP registers +target = self.dbg.CreateTarget(None) +self.assertTrue(target

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/133079 >From 3d5ee1252efe24bf2c72fb4e155f8042e7334aba Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 26 Mar 2025 12:54:36 + Subject: [PATCH 1/2] [lldb][Instrumentation] Set selected frame to outside san

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/4] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This patch replaces any occurences of lower case generic type hints with its `typing` implementation, i.e `list[str]` becomes `List[str]`. [Type hinting generic in the standard collection were introd

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/156868 This patch replaces any occurence of lower case generic type hints with its `typing` implementation, i.e `list[str]` becomes `List[str]`. [Type hinting generic in the standard collection were introduced

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
@@ -283,6 +283,21 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, g_loop.AddPendingCallback( [](MainLoopBase &loop) { loop.RequestTermination(); }); }); + static MainLoopBase::TimePoint ttl_time_point; walter-

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
@@ -61,3 +61,10 @@ def pre_init_command: S<"pre-init-command">, def: Separate<["-"], "c">, Alias, HelpText<"Alias for --pre-init-command">; + +def time_to_live: S<"time-to-live">, + MetaVarName<"">, + HelpText<"When using --connection, the number of milliseconds t

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
@@ -283,6 +283,21 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, g_loop.AddPendingCallback( [](MainLoopBase &loop) { loop.RequestTermination(); }); }); + static MainLoopBase::TimePoint ttl_time_point; + static std::mutex ttl

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
@@ -283,6 +283,21 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, g_loop.AddPendingCallback( [](MainLoopBase &loop) { loop.RequestTermination(); }); }); + static MainLoopBase::TimePoint ttl_time_point; + static std::mutex ttl

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-09-04 Thread Michael Buch via lldb-commits
Michael137 wrote: > The only bad effect I can see just from looking at the patch is if I had > selected frame 5 of a given thread, and then had run an expression. I want to > make sure that when the expression is done running, we don't set the selected > frame back to 0 (or whatever the most r

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 01/11] [clang][DebugInfo] Expand detection of structured bindin

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/122265 >From a9e13ad8d2a7a95d431dddcced611bea1e83b99a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Jan 2025 10:01:31 + Subject: [PATCH 01/12] [clang][DebugInfo] Expand detection of structured bindin

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum requested changes to this pull request. Re: Python bindings (`clang/bindings/python/clang/cindex.py`) We `from __future__ import annotations` at the start of `cindex.py` which allows using the PEP 585 features (among others). We have a CI job that runs the libcla

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
DeinAlptraum wrote: @DavidSpickett the `typing` module is part of the standard library, so there is no need to install it https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame affordance (PR #149622)

2025-09-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/149622 >From df4c41ddc529dce9aac96a698199cb6ed4506000 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 4 Sep 2025 10:21:46 -0700 Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance This patch i

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp -- lldb/test/Shell/SymbolFile/DWARF/deterministic-b

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/156931 >From f1418f873ce40963ca09e39490c202da503535ce Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 4 Sep 2025 10:14:20 -0700 Subject: [PATCH 1/2] [LLDB] Fix tests that fail when using internal shell. These t

[Lldb-commits] [lldb] [lldb][Expression] Reject languages not supported by TypeSystems for expression evaluation (PR #156648)

2025-09-04 Thread via lldb-commits
jimingham wrote: The other scenario is accessing an extant C global variable (maybe even one you don't have debug info for) called "class" or "namespace". But more importantly, having this sort of secret out that is applied inconsistently will just make lldb more confusing. It's fine to say

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
@@ -6,7 +6,7 @@ # XFAIL: system-openbsd # RUN: %clang_host %S/Inputs/simple.c -g -o %t.out -# RUN: SHELL=bogus not %lldb %t.out -b -o 'process launch -X 1 --' 2>&1 | FileCheck %s --check-prefix ERROR +# RUN: env SHELL=bogus not %lldb %t.out -b -o 'process launch -X 1 --' 2>&1

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Roy Shi via lldb-commits
royitaqi wrote: @JDevlieghere Thanks for the good questions. I appreciate all of them. Below are my thoughts for discussion. > proliferation of new options > motivation Main motivation is memory pressure. Other ways to counter memory pressure is either to monitor from lldb-dap VS Code extensi

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156774 The LLVM Style Guide says the following about error and warning messages [1]: > [T]o match error message styles commonly produced by other tools, > start the first sentence with a lowercase letter, and fini

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 commented: `lldb/test/Shell/Host/TestCustomShell.test` will still fail after this, but this change is still necessary either way. It does fix the other two tests and enables implementing `env -i` within lit's internal shell to fix `lldb/test/Shell/Host/TestCus

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 approved this pull request. https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct style of error messages (PR #156774)

2025-09-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: llvm.org having issues at the moment so I can't read the guidance but sure why not, if that's the format it wants. Wonder about multiple sentence messages though. https://github.com/llvm/llvm-project/pull/156774 __

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-09-04 Thread David Spickett via lldb-commits
@@ -152,6 +152,11 @@ constexpr RegsetDesc AARCH64_GCS_Desc[] = { {llvm::Triple::Linux, llvm::Triple::aarch64, llvm::ELF::NT_ARM_GCS}, }; +constexpr RegsetDesc ARM_VFP_Desc[] = { +{llvm::Triple::FreeBSD, llvm::Triple::UnknownArch, llvm::ELF::NT_ARM_VFP}, +{llvm::Tri

[Lldb-commits] [lldb] [lldb][elf-core][ARM] Add support for VFP registers (PR #155956)

2025-09-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I wanted to say merge this into the existing `linux-arm.core` but I can't find any source for it. So I'm ok with this being its own thing, and if you do have time, extending it to set GPR and replacing the existing core file would be great. https://

[Lldb-commits] [lldb] [lldb][test] Fix unordered-map test (PR #156033)

2025-09-04 Thread Pavel Labath via lldb-commits
labath wrote: The script code is not an exact equivalent of the "frame var" expression. Notice how in the "frame var", you explicitly dereference the object, while in the script, you call GetChildAtIndex directly on the pointer value. The "frame var" expression would be more similar to `script

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread via lldb-commits
cmtice wrote: > Ok, I will revert this and try to work out how to test/fix the issues on > windows (I wonder why it passed the windows CI premerge tests). Maybe not? The failing test has already been updated and marked as 'Unsupported' on windows? https://github.com/llvm/llvm-project/pull/15

[Lldb-commits] [lldb] [LLDB][NativePDB] Find global variables in namespaces (PR #156736)

2025-09-04 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/156736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/5] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/155705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't crash if no default unwind plan (PR #152481)

2025-09-04 Thread Nikita Popov via lldb-commits
nikic wrote: Ping :) https://github.com/llvm/llvm-project/pull/152481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @cmtice I suspect that this may have broken three tests: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14836/ Could you revert/investigate? Let me know if you need any data or help reproducing. https://github.com/llvm/llvm-project/pull/156729 __

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 requested changes to this pull request. If you have bots for this, please address specific failures rather than grepping through the entire monorepo for these constructs. A bunch of the files you have hit here (like the ones related to CI) will never be run as

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-09-04 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. cool https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread David Spickett via lldb-commits
DavidSpickett wrote: > from typing import List Is this something we install or something that's included with Python 3.8+? https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Jannick Kremer via lldb-commits
https://github.com/DeinAlptraum dismissed https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][AArch64] Make TPIDR a generic tp register (PR #154444)

2025-09-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM Remove the `@` mention in the description before merging, so that they don't get spammed when this gets merged into forks. https://github.com/llvm/llvm-project/pull/15 ___ lldb-com

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Can you talk a bit about what's motivating this change? I'm a little worried about the proliferation of new options and I'm especially wary about the ones that need to be specified on the command line instead of over the protocol. Every new option extends the matrix of thin

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + if (t

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request. https://github.com/llvm/llvm-project/pull/156803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [polly] [python] remove Python 3.9 specific typing annotations (PR #156868)

2025-09-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/156868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 65f60fd - [lldb] Moving MCPTransport into its own file. (#156712)

2025-09-04 Thread via lldb-commits
Author: John Harrison Date: 2025-09-04T08:52:33-07:00 New Revision: 65f60fd4657a31f832ac48caf3d9e1b138d96653 URL: https://github.com/llvm/llvm-project/commit/65f60fd4657a31f832ac48caf3d9e1b138d96653 DIFF: https://github.com/llvm/llvm-project/commit/65f60fd4657a31f832ac48caf3d9e1b138d96653.diff

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes These tests were failing on darwin, because the internal shell needs environment var definitions to start with 'env'. This PR (hopefully) fixes that problem. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/156931 These tests were failing on darwin, because the internal shell needs environment var definitions to start with 'env'. This PR (hopefully) fixes that problem. >From f1418f873ce40963ca09e39490c202da503535ce Mon

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
cmtice wrote: I need someone with a darwin system to verify that this actually fixes the breakages from here: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14836/ https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits ma

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread via lldb-commits
cmtice wrote: > @cmtice I suspect that this may have broken three tests: > > https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14836/ > > Could you revert/investigate? Let me know if you need any data or help > reproducing. @adrian-prantl Could you please test https://github.c

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread Michael Buch via lldb-commits
Michael137 wrote: I suspect this broke `UnsupportedLanguage.test` on the lldb-x86_64-win bot: https://lab.llvm.org/buildbot/#/builders/211/builds/1840 Though don't have a machine to confirm that. ``` TEST 'lldb-shell :: Process/UnsupportedLanguage.test' FAILED ***

[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: #156939 should fix the last remaining issue. https://github.com/llvm/llvm-project/pull/156729 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/156050 >From 35999d8d509864795dd36565d12ddea425a98c22 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 29 Aug 2025 16:57:35 +0100 Subject: [PATCH 1/6] [lldb][DataFormatter] Allow std::string formatters to mat

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame affordance (PR #149622)

2025-09-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/149622 >From a38ed4d99315224889c503d2ce31362be28b28eb Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Wed, 3 Sep 2025 18:32:22 -0700 Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance This patch i

[Lldb-commits] [lldb] bdb9283 - [LLDB][NativePDB] Find global variables in namespaces (#156736)

2025-09-04 Thread via lldb-commits
Author: nerix Date: 2025-09-04T19:30:34+02:00 New Revision: bdb9283eec633585a14f7b1640822448c17ed71a URL: https://github.com/llvm/llvm-project/commit/bdb9283eec633585a14f7b1640822448c17ed71a DIFF: https://github.com/llvm/llvm-project/commit/bdb9283eec633585a14f7b1640822448c17ed71a.diff LOG: [L

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread John Harrison via lldb-commits
@@ -509,6 +547,17 @@ int main(int argc, char *argv[]) { } if (!connection.empty()) { +int ttl = 0; ashgti wrote: nit: Could this be `ttl_ms` or maybe a `std::chrono::milliseconds` instead of an `int`? https://github.com/llvm/llvm-project/pull/156803

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread John Harrison via lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + if (t

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread John Harrison via lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + if (t

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread John Harrison via lldb-commits
@@ -327,6 +348,23 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + if (t

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: I've tested this locally on Darwin. I can confirm it fixes part of `TestCustomShell.test` and completely fixes the other two tests. https://github.com/llvm/llvm-project/pull/156931 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread via lldb-commits
cmtice wrote: > `lldb/test/Shell/Host/TestCustomShell.test` will still fail after this, but > this change is still necessary either way. It does fix the other two tests > and enables implementing `env -i` within lit's internal shell to fix > `lldb/test/Shell/Host/TestCustomShell.test`. > > I'

[Lldb-commits] [lldb] [LLDB] Fix tests that fail when using internal shell. (PR #156931)

2025-09-04 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @cmtice @boomanaiden154 1/3 are still failing: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/14864/testReport/lldb-shell/SymbolFile_DWARF/deterministic_build_cpp/ https://github.com/llvm/llvm-project/pull/156931 __

[Lldb-commits] [lldb] [lldb] Add some vector operations to the IRInterpreter (PR #155000)

2025-09-04 Thread Michael Buch via lldb-commits
@@ -1564,7 +1660,103 @@ bool IRInterpreter::Interpret(llvm::Module &module, llvm::Function &function, returnVal = value.GetScalar(); // Push the return value as the result -frame.AssignValue(inst, returnVal, module); +frame.AssignValue(inst, re

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This came up in https://github.com/llvm/llvm-project/issues/155691. For `std::basic_string` our formatter matching logic required the allocator template parameter to be a `std::allocator`. There is no comp

[Lldb-commits] [lldb] [lldb] Add some vector operations to the IRInterpreter (PR #155000)

2025-09-04 Thread Michael Buch via lldb-commits
@@ -30,9 +30,14 @@ class ArchitecturePPC64 : public Architecture { void AdjustBreakpointAddress(const Symbol &func, Address &addr) const override; + lldb::ByteOrder GetVectorElementOrder() const override; + private: static std::unique_ptr

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-09-04 Thread Anthony Eid via lldb-commits
@@ -62,7 +97,11 @@ struct Variables { /// These are the variables evaluated from debug console REPL. llvm::DenseMap m_referencedpermanent_variables; - int64_t m_next_temporary_var_ref{VARREF_FIRST_VAR_IDX}; + /// Key = frame_id + /// Value = (locals, globals Registers)

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Rick van Voorden via lldb-commits
https://github.com/vanvoorden edited https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Rick van Voorden via lldb-commits
https://github.com/vanvoorden edited https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Vlad Serebrennikov via lldb-commits
Endilll wrote: I'd like to see this massive change to be backed by an RFC on Discourse. That is also a good place to discuss various options for the exact wording. https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb][DataFormatter] Allow std::string formatters to match against custom allocators (PR #156050)

2025-09-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/156050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-09-04 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: ping, I need feedback from the DebugInfo experts, do the test changes look good? https://github.com/llvm/llvm-project/pull/155120 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-09-04 Thread Anthony Eid via lldb-commits
https://github.com/Anthony-Eid updated https://github.com/llvm/llvm-project/pull/124232 >From 30658e994b18b7c0db114a297036421c8de2dea3 Mon Sep 17 00:00:00 2001 From: Anthony Date: Wed, 27 Aug 2025 13:04:26 -0400 Subject: [PATCH 01/17] Fix variable request from reusing variable_ids --- .../lld

[Lldb-commits] [lldb] lldb-dap: Stop using replicated variable ids (PR #124232)

2025-09-04 Thread Anthony Eid via lldb-commits
@@ -62,7 +97,11 @@ struct Variables { /// These are the variables evaluated from debug console REPL. llvm::DenseMap m_referencedpermanent_variables; - int64_t m_next_temporary_var_ref{VARREF_FIRST_VAR_IDX}; + /// Key = frame_id + /// Value = (locals, globals Registers)

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-04 Thread Rick van Voorden via lldb-commits
https://github.com/vanvoorden edited https://github.com/llvm/llvm-project/pull/156995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix deterministic-build.cpp post #156931 (PR #156983)

2025-09-04 Thread via lldb-commits
cmtice wrote: Just FYI: That blank line got removed because otherwise it failed the code formatting premerge test. :-( https://github.com/llvm/llvm-project/pull/156983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [lldb] [LLDB] Fix deterministic-build.cpp post #156931 (PR #156983)

2025-09-04 Thread Aiden Grossman via lldb-commits
boomanaiden154 wrote: > Just FYI: That blank line got removed because otherwise it failed the code > formatting premerge test. :-( Good point. Updated to change the line number rather than add in the extra blank line. I've confirmed this fixes the issue locally, so I'm going to merge this onc

  1   2   >