[Lldb-commits] [lldb] Fix a bug where an error was emitted for GCC union types. (PR #159401)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes GCC doesn't add DW_AT_data_member_location attributes to the DW_TAG_member children of DW_TAG_union_type types. An error was being emitted incorrectly for these cases fr om the DWARFASTParserClang. This fixe

[Lldb-commits] [lldb] [lldb][test] Disable parallel module loading for TestNetBSDCore.py (PR #159395)

2025-09-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/159395 Since #157170 this test has been flakey on several LLDB buildbots. I suspect it's to do with mutli-threading, there are more details in #159377. Disable parallel loading for now so we are not spamming peo

[Lldb-commits] [lldb] Fix a bug where an error was emitted for GCC union types. (PR #159401)

2025-09-17 Thread Greg Clayton via lldb-commits
https://github.com/clayborg created https://github.com/llvm/llvm-project/pull/159401 GCC doesn't add DW_AT_data_member_location attributes to the DW_TAG_member children of DW_TAG_union_type types. An error was being emitted incorrectly for these cases fr om the DWARFASTParserClang. This fixes

[Lldb-commits] [lldb] [lldb][Linux] Fix potential out of bounds read of pr_fname (PR #159375)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes https://github.com/llvm/llvm-project/pull/157170 added code that assigned pr_fname to another std::string member. In the lines before, we copy pr_fname using assign with a max length set to either th

[Lldb-commits] [lldb] [lldb][Linux] Fix potential out of bounds read of pr_fname (PR #159375)

2025-09-17 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. LGTM, thanks for the fix! Do you suspect this is also related to #159377? Looks like you have a different proposed fix there. https://github.com/llvm/llvm-project/pull/159375 ___ lldb-commits maili

[Lldb-commits] [lldb] [lldb] Add unreachable after fully covered switches, avoid GCC warnings. NFC. (PR #159327)

2025-09-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. > the root cause here is that GCC assumes that an enum variable still > technically can have any value outside of the enum Ok, I forgot about this aspect. LGTM. https://github.com/llvm/llvm-project/pull/159327 __

[Lldb-commits] [lldb] [lldb] Avoid build warnings when building for Windows. NFC. (PR #159345)

2025-09-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/159345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/API] Mark SBValue with error as invalid (PR #158759)

2025-09-17 Thread via lldb-commits
https://github.com/jimingham requested changes to this pull request. This doesn't sound like a good idea to me. IsValid means "will I get meaningful information back if I ask a question of this object". You certainly want to know if the Error state of the SBValue is in fact valid. So an SBVa

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/API] Mark SBValue with error as invalid (PR #158759)

2025-09-17 Thread via lldb-commits
jimingham wrote: Note, another way to do this would be to have default constructed SBValues have a Failed error state of "Nothing in me now". Then you could dispense with SBValie.IsValid altogether, since there aren't any SBValues that don't at least have valid error states. https://github.

[Lldb-commits] [lldb] [lldb/API] Mark SBValue with error as invalid (PR #158759)

2025-09-17 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/158759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Matheus Izvekov via lldb-commits
@@ -112,6 +112,25 @@ class LangOptionsBase { SOB_Trapping }; + // Used by __attribute__((overflow_behavior())) to describe overflow behavior + // on a per-type basis. + enum OverflowBehaviorKind { +// Default C standard behavior (type dependent). +OB_Unset, +

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Justin Stitt via lldb-commits
@@ -112,6 +112,25 @@ class LangOptionsBase { SOB_Trapping }; + // Used by __attribute__((overflow_behavior())) to describe overflow behavior + // on a per-type basis. + enum OverflowBehaviorKind { +// Default C standard behavior (type dependent). +OB_Unset, +

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Justin Stitt via lldb-commits
@@ -7477,6 +7477,10 @@ void TypeLocReader::VisitBTFTagAttributedTypeLoc(BTFTagAttributedTypeLoc TL) { // Nothing to do. } +void TypeLocReader::VisitOverflowBehaviorTypeLoc(OverflowBehaviorTypeLoc TL) { + // Nothing to do. +} JustinStitt wrote: Right. Done

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Justin Stitt via lldb-commits
@@ -2165,6 +2167,26 @@ void TypePrinter::printBTFTagAttributedAfter(const BTFTagAttributedType *T, printAfter(T->getWrappedType(), OS); } +void TypePrinter::printOverflowBehaviorBefore(const OverflowBehaviorType *T, + raw_ostream

[Lldb-commits] [lldb] [lldb/docs] Breakdown python reference into multiple files (PR #158331)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Any reason we can't use the existing [.htaccess](https://github.com/llvm/llvm-project/blob/main/lldb/docs/.htaccess) for that? https://github.com/llvm/llvm-project/pull/158331 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/154123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Linux] Fix potential out of bounds read of pr_fname (PR #159375)

2025-09-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/159375 https://github.com/llvm/llvm-project/pull/157170 added code that assigned pr_fname to another std::string member. In the lines before, we copy pr_fname using assign with a max length set to either the le

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Matheus Izvekov via lldb-commits
@@ -9002,6 +9057,10 @@ inline bool Type::isIntegralOrEnumerationType() const { if (const auto *ET = dyn_cast(CanonicalType)) return IsEnumDeclComplete(ET->getOriginalDecl()); + if (const OverflowBehaviorType *OBT = + dyn_cast(CanonicalType)) mi

[Lldb-commits] [lldb] RISCV unwinding enable (PR #158161)

2025-09-17 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/158161 >From ee3cadcf6d29c07529aac18975965da1c3422b3a Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Thu, 11 Sep 2025 14:06:05 -0700 Subject: [PATCH 1/7] RISCV unwinding enable --- lldb/include/lldb/Core/Op

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also this needs an entry in the release notes (llvm/docs/ReleaseNotes.md) and something in the PR description about how it works for the user. Mentioning -Y and the feature setting assuming it also works (make it work if it does not). https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb][Instrumentation] Set selected frame to outside sanitizer libraries (PR #133079)

2025-09-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 auto_merge_enabled https://github.com/llvm/llvm-project/pull/133079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Added unique builtins types for __bf16 and _Float16 (PR #157674)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (tgs-sc) Changes During debugging applization with __bf16 and _Float16 float types it was discovered that lldb creates the same CompilerType for them. This can cause an infinite recursion error, if one tries to create two struct speci

[Lldb-commits] [lldb] [lldb-mcp] Adding a tool to list debuggers again. (PR #158340)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Not directly related to this PR, but something I'm planning to address that will affect this. I've gotten some reports that nearly all models struggle with the debugger IDs being 1-based. Some of them are smart enough to try 1

[Lldb-commits] [lldb] [lldb][Linux] Fix potential out of bounds read of pr_fname (PR #159375)

2025-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is unrelated to that since this fixes a Linux specific code path. The failing tests are all NetBSD cores and I confirmed we're not calling the Linux code accidentally there. https://github.com/llvm/llvm-project/pull/159375 _

[Lldb-commits] [lldb] [lldb] Avoid build warnings when building for Windows. NFC. (PR #159345)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Martin Storsjö (mstorsjo) Changes This avoids the following warnings from Clang: ../../lldb/source/Host/windows/Host.cpp:324:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default] 324 |

[Lldb-commits] [lldb] [LLDB][ProcessWindows] Set exit status on instance rather than going through all targets (PR #159308)

2025-09-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Great find! I had noticed that lldb was slow to quit but I always thought it would be something inherent to how things work on Windows. https://github.com/llvm/llvm-project/pull/159308 ___ l

[Lldb-commits] [lldb] [lldb][test] Disable parallel module loading for TestNetBSDCore.py (PR #159395)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Since #157170 this test has been flakey on several LLDB buildbots. I suspect it's to do with mutli-threading, there are more details in #159377. Disable parallel loading for now so we are not spamming

[Lldb-commits] [lldb] d0bdc5d - [lldb][test] Disable parallel module loading for TestNetBSDCore.py (#159395)

2025-09-17 Thread via lldb-commits
Author: David Spickett Date: 2025-09-17T17:40:36+01:00 New Revision: d0bdc5d94502b9fb829bb7cb5f9d2f5bbccdbb2f URL: https://github.com/llvm/llvm-project/commit/d0bdc5d94502b9fb829bb7cb5f9d2f5bbccdbb2f DIFF: https://github.com/llvm/llvm-project/commit/d0bdc5d94502b9fb829bb7cb5f9d2f5bbccdbb2f.diff

[Lldb-commits] [lldb] [lldb][test] Disable parallel module loading for TestNetBSDCore.py (PR #159395)

2025-09-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/159395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Linux] Fix potential out of bounds read of pr_fname (PR #159375)

2025-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: To prevent any confusion working on fixing that issue, I will leave this PR open until the issue is resolved. https://github.com/llvm/llvm-project/pull/159375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes This adds basic c-style type casting to DIL. It handles basic built-in types: bool, char, short, int, long, double, float, and void. It also handles user-defined types (e.g. class names, typedefs, etc.). It does NOT h

[Lldb-commits] [lldb] [cmake][lldb][test] Respect LIBCXX_LIBDIR_SUBDIR (PR #159106)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Raul Tambre (tambry) Changes This code in principle needs to match the one in libc++ but hasn't been updated to account for LIBCXX_LIBDIR_SUBDIR so tests don't work if LLVM is built with it specified. Fixes: ed155f3f237a7e3a3e40a84d815225

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-17 Thread via lldb-commits
@@ -1873,6 +1874,24 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, clang_type = m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +// Try to find an existing specialization with these template arguments and +//

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-17 Thread via lldb-commits
https://github.com/cmtice unassigned https://github.com/llvm/llvm-project/pull/159500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-17 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/159481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add support for the structured data plugins in lldb-server (PR #159457)

2025-09-17 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo unassigned https://github.com/llvm/llvm-project/pull/159457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-17 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/159500 This adds basic c-style type casting to DIL. It handles basic built-in types: bool, char, short, int, long, double, float, and void. It also handles user-defined types (e.g. class names, typedefs, etc.). It does

[Lldb-commits] [lldb] [lldb-dap] Add command line option `--connection-timeout` (PR #156803)

2025-09-17 Thread Roy Shi via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/156803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-17 Thread via lldb-commits
https://github.com/tgs-sc updated https://github.com/llvm/llvm-project/pull/154123 >From 4c41e8481c8daeccfcdf448c3a1e7521da79cdd7 Mon Sep 17 00:00:00 2001 From: Timur Golubovich Date: Mon, 8 Sep 2025 14:43:50 +0300 Subject: [PATCH] [lldb][DWARFASTParserClang] Added a check for the specializati

[Lldb-commits] [lldb] 6a71938 - Revert "[lldb][NFC] Force some logging on to TestCortexMExceptionUnwind.py"

2025-09-17 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-09-10T22:58:30-07:00 New Revision: 6a719387704c8c01b29bdb418a4d8a3b5df6b090 URL: https://github.com/llvm/llvm-project/commit/6a719387704c8c01b29bdb418a4d8a3b5df6b090 DIFF: https://github.com/llvm/llvm-project/commit/6a719387704c8c01b29bdb418a4d8a3b5df6b090.diff

[Lldb-commits] [lldb] [lldb][test] Fix unordered-map test (PR #156033)

2025-09-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp -- lldb/source/Plugins/Language/CPlusPlus/LibCxxUno

[Lldb-commits] [lldb] [LLDB] Fix 64 bit support for CIE and FDE handling in DWARFCallFrameInfo (PR #158350)

2025-09-17 Thread David Peixotto via lldb-commits
dmpots wrote: > I do not know the proper way to test this change and am open to > recommendations on how to add a test We should be able to add a test to DWARFCallFrameInfoTest using an ELF YAML file that has a 32-bit/64-bit CIE. Here is an example where I added a minimal CIE entry for testin

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [Inclusive Language] migrate "sanity" checks to "soundness" checks (PR #156995)

2025-09-17 Thread Jay Foad via lldb-commits
jayfoad wrote: > Replacing `sanity` with `sound`, as in `sound of mind`, a _direct synonym_ > with the exact same connotation. > > Seems like it'd do more harm than good. I don't buy that argument at all. "Sound" has plenty of uses. It does not imply "sound of mind". https://github.com/llvm/

[Lldb-commits] [lldb] [llvm] [ELF][LLDB] Add an nvsass triple (PR #159459)

2025-09-17 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/159459 >From a14b6f181cdea884b5bd7d0232d44e07a8bac769 Mon Sep 17 00:00:00 2001 From: Walter Erquinigo Date: Tue, 16 Sep 2025 13:17:25 -0700 Subject: [PATCH] [ELF][LLDB] Add an nvsass triple When handling CUDA

[Lldb-commits] [lldb] [LLDB] Add support for the structured data plugins in lldb-server (PR #159457)

2025-09-17 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/159457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add support for the structured data plugins in lldb-server (PR #159457)

2025-09-17 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @dmpots , I've added the test https://github.com/llvm/llvm-project/pull/159457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Roy Shi (royitaqi) Changes This helps lldb-dap (the binary) development. For example, after rebuilding the lldb-dap binary, one probably wants to restart the server so that it will use the newly built binary instead of a stale one. With t

[Lldb-commits] [lldb] [vscode-lldb] Restart server when the lldb-dap binary's modification time has changed (PR #159481)

2025-09-17 Thread Roy Shi via lldb-commits
@@ -14,11 +14,11 @@ ], "outFiles": [ "${workspaceFolder}/out/**/*.js" - ], - "preLaunchTask": { - "type": "npm", -

[Lldb-commits] [lldb] [LLDB] Fix 64 bit support for CIE and FDE handling in DWARFCallFrameInfo (PR #158350)

2025-09-17 Thread Andrew Gontarek via lldb-commits
@@ -577,7 +598,8 @@ DWARFCallFrameInfo::ParseFDE(dw_offset_t dwarf_offset, } // FDE entries with zeroth cie_offset may occur for debug_frame. - assert(!(m_type == EH && 0 == cie_offset) && cie_offset != UINT32_MAX); + assert(!(m_type == EH && 0 == cie_offset) &&

[Lldb-commits] [lldb] [LLDB] [Tests] Downgrade -Wincompatible-pointer-types to a warning in some tests (PR #158756)

2025-09-17 Thread via lldb-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/158756 These no longer compile because the warning now defaults to an error after #157364, so downgrade the error to a warning for now; I’m not familiar enough with either LLDB or MacOS to fix these warnings properly

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r origin/main...HEAD lldb/test/API/commands/frame/var-dil/expr/CStyleCast/TestFrameVarDILCSt

[Lldb-commits] [clang] [lldb] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-09-17 Thread antoine moynault via lldb-commits
antmox wrote: Hi @Michael137 , It looks like this patch caused a bot failure ( lldb-aarch64-windows ) : https://lab.llvm.org/buildbot/#/builders/141/builds/11398/ Could you please look at this ? https://lab.llvm.org/buildbot/#/builders/141/builds/11398/steps/6/logs/stdio : FAIL: test_nested_n

[Lldb-commits] [lldb] [LLDB] Add support for the structured data plugins in lldb-server (PR #159457)

2025-09-17 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/159457 >From 30b75ddfc7fcbc406eb9cf920dccb8c077dea751 Mon Sep 17 00:00:00 2001 From: Walter Erquinigo Date: Wed, 17 Sep 2025 14:01:43 -0700 Subject: [PATCH] [LLDB] Add support for the structured data plugins i

[Lldb-commits] [lldb] [LLDB] Add support for the structured data plugins in lldb-server (PR #159457)

2025-09-17 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo unassigned https://github.com/llvm/llvm-project/pull/159457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-17 Thread via lldb-commits
@@ -1873,6 +1873,17 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, clang_type = m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +if (!class_specialization_decl) { + if (log) { +dwarf->GetObjectFile()

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL. (PR #159500)

2025-09-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp,h -- lldb/test/API/commands/frame/var-dil/expr/CSty

[Lldb-commits] [lldb] [lldb] Add unreachable after fully covered switches, avoid GCC warnings. NFC. (PR #159327)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Martin Storsjö (mstorsjo) Changes This avoids the following kind of warning with GCC: warning: control reaches end of non-void function [-Wreturn-type] --- Full diff: https://github.com/llvm/llvm-project/pull/159327.diff 4 Files Affe

[Lldb-commits] [lldb] [lldb] Add unreachable after fully covered switches, avoid GCC warnings. NFC. (PR #159327)

2025-09-17 Thread Martin Storsjö via lldb-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/159327 This avoids the following kind of warning with GCC: warning: control reaches end of non-void function [-Wreturn-type] From e59f57ff5eec52bbcfa20403cbadd5866bf4aa98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?

[Lldb-commits] [lldb] [LLDB][NativePDB] Add modifiers to modified type name (PR #159296)

2025-09-17 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/159296 When creating LLDB types from `LF_MODIFIER` records, the type name of the modified type was used. This didn't include the modifiers (`const`/`volatile`/`__unaligned`). With this PR, they're included. The DIA p

[Lldb-commits] [lldb] [LLDB][ProcessWindows] Set exit status on instance rather than going through all targets (PR #159308)

2025-09-17 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/159308 When quitting LLDB on Windows while a process was still running, LLDB would take unusually long to exit. This was due to a temporary deadlock: The main thread was destroying the processes. In doing so, it itera

[Lldb-commits] [lldb] [lldb] Add unreachable after fully covered switches, avoid GCC warnings. NFC. (PR #159327)

2025-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Taking one as an example: ``` enum class FunctionNameRepresentation { eName, eNameWithArgs, eNameWithNoArgs }; ``` And we do have a return for each of the cases. So it feels like a limitation in GCC's analysis, is that right or did they make a decision to wa

[Lldb-commits] [lldb] [lldb] Avoid build warnings when building for Windows. NFC. (PR #159345)

2025-09-17 Thread Martin Storsjö via lldb-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/159345 This avoids the following warnings from Clang: ../../lldb/source/Host/windows/Host.cpp:324:3: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default] 324 | d

[Lldb-commits] [lldb] [LLDB][NVIDIA] Add NVPTX architecture support (PR #158334)

2025-09-17 Thread Andrew Gontarek via lldb-commits
https://github.com/agontarek updated https://github.com/llvm/llvm-project/pull/158334 >From 0751dd1fee9237590773d2f2f4e1e0fd8d88cab9 Mon Sep 17 00:00:00 2001 From: Andrew Gontarek Date: Wed, 10 Sep 2025 12:40:28 -0500 Subject: [PATCH] [LLDB][NVIDIA] Add NVPTX architecture support - Introduced

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Justin Stitt via lldb-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/148914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix GetDIE is outside of its CU error from .debug_names (PR #157574)

2025-09-17 Thread via lldb-commits
jeffreytan81 wrote: Updated the test to remove unnecessary steps, be more readable. https://github.com/llvm/llvm-project/pull/157574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Justin Stitt via lldb-commits
@@ -112,6 +112,25 @@ class LangOptionsBase { SOB_Trapping }; + // Used by __attribute__((overflow_behavior())) to describe overflow behavior + // on a per-type basis. + enum OverflowBehaviorKind { +// Default C standard behavior (type dependent). +OB_Unset, +

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Justin Stitt via lldb-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/148914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

2025-09-17 Thread Justin Stitt via lldb-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/148914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Add modifiers to modified type name (PR #159296)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/159296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-mcp] Launch lldb on demand, if needed. (PR #158701)

2025-09-17 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/158701 >From 39b27ffc60fe30e88e42918f2c3382369f06f3df Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 15 Sep 2025 10:30:04 -0700 Subject: [PATCH 1/3] [lldb-mcp] Launch lldb on demand, if needed. Adding support

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Added a check for the specialization existence (PR #154123)

2025-09-17 Thread via lldb-commits
@@ -1873,6 +1874,24 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, clang_type = m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +// Try to find an existing specialization with these template arguments and +//

[Lldb-commits] [lldb] [lldb] Add unreachable after fully covered switches, avoid GCC warnings. NFC. (PR #159327)

2025-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also if we added an entry to one of these enums, would the "switch doesn't cover value" warning still happen? I think it would right? https://github.com/llvm/llvm-project/pull/159327 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] [lldb] Recognize MTE fault Mach exceptions (PR #159117)

2025-09-17 Thread Julian Lettner via lldb-commits
https://github.com/yln approved this pull request. This looks good from my side. I will follow up with more patches @JDevlieghere said. The first one to prepare for bette testing is here: https://github.com/llvm/llvm-project/pull/153914#pullrequestreview-3156070533 I will address the feedback

[Lldb-commits] [lldb] [lldb] Recognize MTE fault Mach exceptions (PR #159117)

2025-09-17 Thread Julian Lettner via lldb-commits
https://github.com/yln edited https://github.com/llvm/llvm-project/pull/159117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Recognize MTE fault Mach exceptions (PR #159117)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/159117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] def2020 - [lldb] Recognize MTE fault Mach exceptions (#159117)

2025-09-17 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-09-17T11:20:52-07:00 New Revision: def202048586dad7029c9458a39dcb0e3cdb6c33 URL: https://github.com/llvm/llvm-project/commit/def202048586dad7029c9458a39dcb0e3cdb6c33 DIFF: https://github.com/llvm/llvm-project/commit/def202048586dad7029c9458a39dcb0e3cdb6c33.d

[Lldb-commits] [lldb] [lldb] Fix OP_deref evaluation for large integer results (PR #159460)

2025-09-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Nice fix, good job on coming up with a test for it too, that's a lot of setup for this. https://github.com/llvm/llvm-project/pull/159460 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [lldb][LoongArch] Preserve temporary symbols starting with `.L` in lldb symbol table (PR #158551)

2025-09-17 Thread via lldb-commits
https://github.com/zhaoqi5 created https://github.com/llvm/llvm-project/pull/158551 LoongArch64 always uses symbols for relocations, so temporary symbols starting with ".L" should be preserved so that relocations in `.debug_info` can be fixed correctly. After this commit, three tests passed:

[Lldb-commits] [lldb] [lldb][test] Prevent TestqOffsets.py picking up host binaries (PR #157432)

2025-09-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/157432 Due to a fallback in GDBRemoteCommunicationClient.cpp, on Linux we will assume a PID of 1 if the remote does not respond in some way that tells us the real PID. So if PID 1 happened to be a process that

[Lldb-commits] [lldb] [lldb][test] Re-enable import-std-module tests on Linux (PR #157649)

2025-09-17 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > Seeing some repeated test failures in tests modified by this change on the > linux premerge testing: > https://github.com/llvm/llvm-project/actions/runs/17683541354?pr=158343 - > perhaps someone here knows what that's about? It happened here https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb][test] Re-enable `TestRerunAndExprDylib.py` (PR #157872)

2025-09-17 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/157872 the `skipTestIfFn` requires a function that return a string to skip or None to run the test. The `isUbuntu18_04` function returns a bool and the test is skipped on all platforms. https://github.com/llvm/llvm

[Lldb-commits] [lldb] [lldb] Fix OP_deref evaluation for large integer results (PR #159460)

2025-09-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/159460 >From ef8ba401c07514076a3367c256e0c8f63d5c2c06 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 17 Sep 2025 14:22:31 -0700 Subject: [PATCH] [lldb] Fix OP_deref evaluation for large int

[Lldb-commits] [lldb] [lldb][test] Fix unordered-map test (PR #156033)

2025-09-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/156033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-17 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/156803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a static_assert that g_core_definitions matches the Core enum (PR #159452)

2025-09-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/159452 This PR uses the same trick as 7ced9fff95473 to ensure the `g_core_definitions` table is correctly indexed by the Core enum. It's easy to make a mistake. Case in point: this caught two entries that appeare

[Lldb-commits] [lldb] 1d2007b - [lldb] Fix OP_deref evaluation for large integer results (#159460)

2025-09-17 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-09-17T15:46:24-07:00 New Revision: 1d2007ba6f7bacda8848e35298a1833e79f4abd5 URL: https://github.com/llvm/llvm-project/commit/1d2007ba6f7bacda8848e35298a1833e79f4abd5 DIFF: https://github.com/llvm/llvm-project/commit/1d2007ba6f7bacda8848e35298a1833e7

[Lldb-commits] [lldb] [lldb] Fix OP_deref evaluation for large integer results (PR #159460)

2025-09-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/159460 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add memory event (PR #158437)

2025-09-17 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/158437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add memory event (PR #158437)

2025-09-17 Thread John Harrison via lldb-commits
ashgti wrote: LGTM, I can merge it. https://github.com/llvm/llvm-project/pull/158437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-mcp] Fix servers accepting more than one client. (PR #158357)

2025-09-17 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/158357 >From 07a8a62569a41c881f721b2800086eb559da6fa8 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 12 Sep 2025 13:06:30 -0700 Subject: [PATCH 1/2] [lldb-mcp] Fix servers accepting more than one client. This

[Lldb-commits] [lldb] [lldb] Fix OP_deref evaluation for large integer results (PR #159460)

2025-09-17 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: ``` CMake Error at cmake/modules/LLVM-Config.cmake:271 (message): Library 'AArch64' is a direct reference to a target library for an omitted target. ``` Seems like a real problem. Will revert while I debug. https://github.com/llvm/llvm-project/pull/159460 _

[Lldb-commits] [lldb] [LLDB] Require DIA SDK for testing the PDB plugin-selection setting (PR #158284)

2025-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes If LLDB is built without the DIA SDK enabled, then the native plugin is used regardless of `plugin.symbol-file.pdb.reader` or `LLDB_USE_NATIVE_PDB_READER`. This made the test fail on Windows when the DIA SDK was dis

[Lldb-commits] [lldb] [lldb] Fix OP_deref evaluation for large integer results (PR #159460)

2025-09-17 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 4 "cmake-configure". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/28097 Here is the relevant pi

[Lldb-commits] [lldb] [lldb] Fix OP_deref evaluation for large integer results (PR #159460)

2025-09-17 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while building `lldb` at step 4 "cmake-configure". Full details are available at: https://lab.llvm.org/buildbot/#/builders/163/builds/26651 Here is the rele

[Lldb-commits] [lldb] c744f61 - [lldb-dap] Add memory event (#158437)

2025-09-17 Thread via lldb-commits
Author: Druzhkov Sergei Date: 2025-09-17T15:51:40-07:00 New Revision: c744f6168f6f817c7a2dcd493a8e29a0c1f8a3bb URL: https://github.com/llvm/llvm-project/commit/c744f6168f6f817c7a2dcd493a8e29a0c1f8a3bb DIFF: https://github.com/llvm/llvm-project/commit/c744f6168f6f817c7a2dcd493a8e29a0c1f8a3bb.dif

[Lldb-commits] [lldb] 1a4685d - Revert "[lldb] Fix OP_deref evaluation for large integer results (#159460)"

2025-09-17 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-09-17T15:49:09-07:00 New Revision: 1a4685df13282ae5c1d7dce055a71a7130bfab3c URL: https://github.com/llvm/llvm-project/commit/1a4685df13282ae5c1d7dce055a71a7130bfab3c DIFF: https://github.com/llvm/llvm-project/commit/1a4685df13282ae5c1d7dce055a71a713

[Lldb-commits] [lldb] [lldb-mcp] Fix servers accepting more than one client. (PR #158357)

2025-09-17 Thread John Harrison via lldb-commits
@@ -52,11 +60,14 @@ class ProtocolServerMCP : public ProtocolServer { lldb_private::MainLoop m_loop; std::thread m_loop_thread; std::mutex m_mutex; + uint32_t m_client_count = 0; ashgti wrote: Done, updated to `size_t`. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] Add a scripted way to re-present a stop location (PR #158128)

2025-09-17 Thread via lldb-commits
@@ -529,6 +561,20 @@ class Breakpoint : public std::enable_shared_from_this, m_name_list.erase(name_to_remove); } + enum TypeDisplay { jimingham wrote: I also changed the enum name to DisplayType. I intended this to read as "Type of Display" but t

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-09-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: My understanding: * The ELF describes which extensions it is using. * As the LLDB being used may not be linked with an LLVM that understands them all, we have an allowlist of features we will read from the ELF. And now I'm wondering what happens when

  1   2   >