[Lldb-commits] [lldb] r337030 - No longer pass a StringRef to the Python API

2018-07-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 13 11:13:46 2018 New Revision: 337030 URL: http://llvm.org/viewvc/llvm-project?rev=337030=rev Log: No longer pass a StringRef to the Python API Summary: The refactoring patch for DoExecute missed this case of a variadic function that just silently accepts a

[Lldb-commits] [lldb] r323119 - Fix uninitialized variable in GoParser

2018-01-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jan 22 06:32:43 2018 New Revision: 323119 URL: http://llvm.org/viewvc/llvm-project?rev=323119=rev Log: Fix uninitialized variable in GoParser Summary: `m_last_tok` isn't initialized anywhere before it's used the first time (most likely in the `GoParser::Rule::error`

[Lldb-commits] [lldb] r323197 - Fix memory leaks in GoParser

2018-01-23 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jan 23 05:50:46 2018 New Revision: 323197 URL: http://llvm.org/viewvc/llvm-project?rev=323197=rev Log: Fix memory leaks in GoParser Summary: The GoParser is leaking memory in the tests due to not freeing allocated nodes when encountering some parsing errors. With

[Lldb-commits] [lldb] r341940 - Print the correct error when our DynamicCheckerFunctions fail to install

2018-09-11 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Sep 11 06:59:47 2018 New Revision: 341940 URL: http://llvm.org/viewvc/llvm-project?rev=341940=rev Log: Print the correct error when our DynamicCheckerFunctions fail to install Summary: The check is inverted here: If we have error messages, we should print those

[Lldb-commits] [lldb] r326727 - Including for std::bind

2018-03-05 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Mar 5 09:54:23 2018 New Revision: 326727 URL: http://llvm.org/viewvc/llvm-project?rev=326727=rev Log: Including for std::bind Differential Revision: https://reviews.llvm.org/D44099 Modified:

Re: [Lldb-commits] [lldb] r344982 - [ValueObject] Stop assuming types are non-zero sized.

2018-10-23 Thread Raphael Isemann via lldb-commits
You maybe able to add a test for that in C++: Clang types can have 0 size, the padding from 0 to 1 happens in the CodeGen IIRC. See also this bug: https://bugs.llvm.org/show_bug.cgi?id=31612 - Raphael Am Di., 23. Okt. 2018 um 02:33 Uhr schrieb Davide Italiano via lldb-commits : > > Author: davide

Re: [Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

2018-09-23 Thread Raphael Isemann via lldb-commits
> AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The > test will still be failing on Arch. I was more hoping it would at least turn the deadlock into a fail, this way I could at least run the test suit. Anyway, the actual issue is related Python 3: Arch Linux (and

[Lldb-commits] [lldb] r343191 - Refactor ClangUserExpression::GetLanguageForExpr

2018-09-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Sep 27 03:12:54 2018 New Revision: 343191 URL: http://llvm.org/viewvc/llvm-project?rev=343191=rev Log: Refactor ClangUserExpression::GetLanguageForExpr Summary: The `ClangUserExpression::GetLanguageForExpr` method is currently a big source of sadness, as it's name

[Lldb-commits] [lldb] r350675 - Fix unused private field warning.

2019-01-08 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jan 8 14:55:02 2019 New Revision: 350675 URL: http://llvm.org/viewvc/llvm-project?rev=350675=rev Log: Fix unused private field warning. Summary: The member is private and unused if HAVE_LIBCOMPRESSION is undefined, which triggers Clang's -Wunused-private-field

[Lldb-commits] [lldb] r342121 - Remove byte counting from SourceManager [NFC]

2018-09-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Sep 13 02:19:40 2018 New Revision: 342121 URL: http://llvm.org/viewvc/llvm-project?rev=342121=rev Log: Remove byte counting from SourceManager [NFC] Summary: Similar to what we did in D50681, we now stop manually byte counting here in the SourceManager. Reviewers:

[Lldb-commits] [lldb] r342181 - Add support for descriptions with command completions.

2018-09-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Sep 13 14:26:00 2018 New Revision: 342181 URL: http://llvm.org/viewvc/llvm-project?rev=342181=rev Log: Add support for descriptions with command completions. Summary: This patch adds a framework for adding descriptions to the command completions we provide. It also

[Lldb-commits] [lldb] r342044 - Remove manual byte counting from internal Stream methods.

2018-09-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Sep 12 03:20:41 2018 New Revision: 342044 URL: http://llvm.org/viewvc/llvm-project?rev=342044=rev Log: Remove manual byte counting from internal Stream methods. Summary: This patch removes the manual byte counting in all internal Stream methods. This is now done by

[Lldb-commits] [lldb] r342042 - Add a basic test for 'memory region'

2018-09-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Sep 12 03:04:25 2018 New Revision: 342042 URL: http://llvm.org/viewvc/llvm-project?rev=342042=rev Log: Add a basic test for 'memory region' Summary: The 'memory region' command is at the moment not tested at all by our test suite. This patch just adds a basic test

[Lldb-commits] [lldb] r342385 - Add descriptions to completed expressions

2018-09-17 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Sep 17 05:06:07 2018 New Revision: 342385 URL: http://llvm.org/viewvc/llvm-project?rev=342385=rev Log: Add descriptions to completed expressions Summary: Completing inside the expression command now uses the new description API to also provide additional information

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

2019-02-28 Thread Raphael Isemann via lldb-commits
Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via lldb-commits : > > On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote: > > On 28/02/2019 02:37, Davide Italiano via Phabricator wrote: > >> davide added a comment. > >> Herald added a subscriber: jdoerfert. > >> Herald added a

[Lldb-commits] [lldb] r355548 - Remove redundant second os.path.join call [NFC]

2019-03-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Mar 6 12:51:28 2019 New Revision: 355548 URL: http://llvm.org/viewvc/llvm-project?rev=355548=rev Log: Remove redundant second os.path.join call [NFC] Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

[Lldb-commits] [lldb] r356174 - Safer casting in ClangExpressionParser code completion

2019-03-14 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Mar 14 10:39:39 2019 New Revision: 356174 URL: http://llvm.org/viewvc/llvm-project?rev=356174=rev Log: Safer casting in ClangExpressionParser code completion Summary: Makes the code a bit safer in the unlikely situation that we don't get a ClangUserExpression when

[Lldb-commits] [lldb] r355897 - Correctly look up declarations in inline namespaces

2019-03-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Mar 12 00:45:04 2019 New Revision: 355897 URL: http://llvm.org/viewvc/llvm-project?rev=355897=rev Log: Correctly look up declarations in inline namespaces Summary: This patch marks the inline namespaces from DWARF as inline and also ensures that looking up

[Lldb-commits] [lldb] r356592 - Remove the unused return value in ASTImporter::Imported [NFC]

2019-03-20 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Mar 20 12:00:25 2019 New Revision: 356592 URL: http://llvm.org/viewvc/llvm-project?rev=356592=rev Log: Remove the unused return value in ASTImporter::Imported [NFC] Summary: `ASTImporter::Imported` currently returns a Decl, but that return value is not used by the

[Lldb-commits] [lldb] r355939 - Add ability to import std module into expression parser to improve C++ debugging

2019-03-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Mar 12 10:09:33 2019 New Revision: 355939 URL: http://llvm.org/viewvc/llvm-project?rev=355939=rev Log: Add ability to import std module into expression parser to improve C++ debugging Summary: This patch is the MVP version of importing the std module into the

[Lldb-commits] [lldb] r354038 - Don't source local .lldbinit in the test suite

2019-02-14 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Feb 14 09:39:19 2019 New Revision: 354038 URL: http://llvm.org/viewvc/llvm-project?rev=354038=rev Log: Don't source local .lldbinit in the test suite Summary: As suggested by Pavel, we shouldn't let our tests parse the local .lldbinit to prevent random test failures

[Lldb-commits] [lldb] r353643 - Fix x86 return pattern detection

2019-02-10 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun Feb 10 07:41:53 2019 New Revision: 353643 URL: http://llvm.org/viewvc/llvm-project?rev=353643=rev Log: Fix x86 return pattern detection Summary: Replace 0xc9 (LEAVE) with 0xcb (RETF) in ret_pattern_p(). Also put 0xc3 first, since it is the most common form and will

[Lldb-commits] [lldb] r353642 - lldb: Fix compilation on OpenBSD

2019-02-10 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun Feb 10 07:23:58 2019 New Revision: 353642 URL: http://llvm.org/viewvc/llvm-project?rev=353642=rev Log: lldb: Fix compilation on OpenBSD Summary: Update the OpenBSD Host.cpp for the new SetFile() function signature. Fixes compiling lldb on OpenBSD. Reviewers:

[Lldb-commits] [lldb] r353753 - Fixed function name in log statement

2019-02-11 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Feb 11 13:45:33 2019 New Revision: 353753 URL: http://llvm.org/viewvc/llvm-project?rev=353753=rev Log: Fixed function name in log statement Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified:

[Lldb-commits] [lldb] r354202 - Fix TestDataFormatterLibcxxListLoop.py test

2019-02-16 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Feb 16 04:13:30 2019 New Revision: 354202 URL: http://llvm.org/viewvc/llvm-project?rev=354202=rev Log: Fix TestDataFormatterLibcxxListLoop.py test Summary: The compilation of the TestDataFormatterLibcxxListLoop.py currently fails with this error: ```

[Lldb-commits] [lldb] r353381 - Fix documentation formatting for ShellExpandArguments

2019-02-07 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Feb 7 01:47:57 2019 New Revision: 353381 URL: http://llvm.org/viewvc/llvm-project?rev=353381=rev Log: Fix documentation formatting for ShellExpandArguments Modified: lldb/trunk/include/lldb/Host/Host.h lldb/trunk/include/lldb/Target/Platform.h Modified:

[Lldb-commits] [lldb] r352175 - Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

2019-01-25 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jan 25 00:21:47 2019 New Revision: 352175 URL: http://llvm.org/viewvc/llvm-project?rev=352175=rev Log: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication Summary: The field `m_decompression_scratch_type` is only used when `HAVE_LIBCOMPRESSION` is

[Lldb-commits] [lldb] r352180 - Fix typo in ClangModulesDeclVendor [NFC]

2019-01-25 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jan 25 01:28:48 2019 New Revision: 352180 URL: http://llvm.org/viewvc/llvm-project?rev=352180=rev Log: Fix typo in ClangModulesDeclVendor [NFC] Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.h Modified:

[Lldb-commits] [lldb] r352249 - Simplify LangOpts initalization in ClangExpressionParser [NFC]

2019-01-25 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jan 25 14:41:31 2019 New Revision: 352249 URL: http://llvm.org/viewvc/llvm-project?rev=352249=rev Log: Simplify LangOpts initalization in ClangExpressionParser [NFC] Reviewers: davide Reviewed By: davide Subscribers: shafik, davide, lldb-commits Differential

[Lldb-commits] [lldb] r358357 - Prevent unnecessary conversion from StringRef to C-string [NFC]

2019-04-14 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun Apr 14 07:01:49 2019 New Revision: 358357 URL: http://llvm.org/viewvc/llvm-project?rev=358357=rev Log: Prevent unnecessary conversion from StringRef to C-string [NFC] There is an alternative method to GetConstCStringWithLength that takes a StringRef.

Re: [Lldb-commits] [lldb] r360564 - @skipIfLinux flaky lldb-mi tests

2019-05-13 Thread Raphael Isemann via lldb-commits
These tests are now SkipIf Windows, FreeBSD, Darwin AND Linux :( So unless someone sets up a Minix or GNU Hurd bot these tests are never run. CC'ing Alexander who was IIRC able to fix these tests in the past, so maybe he has an idea what's going on. - Raphael Am Mo., 13. Mai 2019 um 10:45 Uhr

[Lldb-commits] [lldb] r359664 - Removed unnecessary conversion to StringRef

2019-05-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed May 1 02:49:07 2019 New Revision: 359664 URL: http://llvm.org/viewvc/llvm-project?rev=359664=rev Log: Removed unnecessary conversion to StringRef Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified:

[Lldb-commits] [lldb] r359665 - Fix build URL in new LLDB website

2019-05-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed May 1 02:55:00 2019 New Revision: 359665 URL: http://llvm.org/viewvc/llvm-project?rev=359665=rev Log: Fix build URL in new LLDB website Summary: After the LLDB website was migrated to be generated by Sphinx the build.html file lives in another location. See

[Lldb-commits] [lldb] r359387 - Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift

2019-04-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Apr 27 11:15:35 2019 New Revision: 359387 URL: http://llvm.org/viewvc/llvm-project?rev=359387=rev Log: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift Summary: As reported in LLVM bug 41487, the check in this function is wrong and should be the

[Lldb-commits] [lldb] r359546 - Sort containers alphabetically in CxxModuleHandler [NFC]

2019-04-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Apr 30 03:27:31 2019 New Revision: 359546 URL: http://llvm.org/viewvc/llvm-project?rev=359546=rev Log: Sort containers alphabetically in CxxModuleHandler [NFC] Modified: lldb/trunk/source/Symbol/CxxModuleHandler.cpp Modified:

[Lldb-commits] [lldb] r359538 - Instantiate 'std' templates explicitly in the expression evaluator

2019-04-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Apr 30 01:41:35 2019 New Revision: 359538 URL: http://llvm.org/viewvc/llvm-project?rev=359538=rev Log: Instantiate 'std' templates explicitly in the expression evaluator Summary: This patch is a follow-up for D58125. It implements the manual instantiation and merging

[Lldb-commits] [lldb] r359773 - Inject only relevant local variables in the expression evaluation context

2019-05-02 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu May 2 03:12:56 2019 New Revision: 359773 URL: http://llvm.org/viewvc/llvm-project?rev=359773=rev Log: Inject only relevant local variables in the expression evaluation context Summary: In r259902, LLDB started injecting all the locals in every expression evaluation.

[Lldb-commits] [lldb] r359779 - Add std::stack and std::queue support to CxxModuleHandler

2019-05-02 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu May 2 04:25:50 2019 New Revision: 359779 URL: http://llvm.org/viewvc/llvm-project?rev=359779=rev Log: Add std::stack and std::queue support to CxxModuleHandler Reviewers: aprantl, shafik Reviewed By: aprantl, shafik Subscribers: lldb-commits Tags:

[Lldb-commits] [lldb] r359777 - Rename Minion to ASTImporterDelegate

2019-05-02 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu May 2 03:58:33 2019 New Revision: 359777 URL: http://llvm.org/viewvc/llvm-project?rev=359777=rev Log: Rename Minion to ASTImporterDelegate Summary: I think there universal agreement that Minion isn't the best name for this class. This patch renames the class to

[Lldb-commits] [lldb] r359931 - Fixed some minor style issues in rLLDB359921 [NFC]

2019-05-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri May 3 14:01:45 2019 New Revision: 359931 URL: http://llvm.org/viewvc/llvm-project?rev=359931=rev Log: Fixed some minor style issues in rLLDB359921 [NFC] Ran clang-format on the added test file and use the new StringRef comparison over the temporary ConstStrings. Also

[Lldb-commits] [lldb] r359813 - Remove unnecessary check in SymbolFileDWARF::ParseImportedModules

2019-05-02 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu May 2 11:26:58 2019 New Revision: 359813 URL: http://llvm.org/viewvc/llvm-project?rev=359813=rev Log: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules Summary: This check seems unnecessary as we already assert the same condition above and also

[Lldb-commits] [lldb] r359868 - C.128 override, virtual keyword handling

2019-05-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri May 3 03:03:28 2019 New Revision: 359868 URL: http://llvm.org/viewvc/llvm-project?rev=359868=rev Log: C.128 override, virtual keyword handling Summary: According to [C128] "Virtual functions should specify exactly one of `virtual`, `override`, or `final`", I've added

[Lldb-commits] [lldb] r365157 - Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

2019-07-04 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jul 4 12:49:31 2019 New Revision: 365157 URL: http://llvm.org/viewvc/llvm-project?rev=365157=rev Log: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration Summary: If we call this function with a non-namespace as a second argument (and a nullptr name), we

[Lldb-commits] [lldb] r365247 - [lldb] Added assert to VerifyDecl

2019-07-05 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 5 14:32:39 2019 New Revision: 365247 URL: http://llvm.org/viewvc/llvm-project?rev=365247=rev Log: [lldb] Added assert to VerifyDecl We could VerifyDecl sometimes with a nullptr. It would be nice if we could get an actual assert here instead of triggering UB.

[Lldb-commits] [lldb] r365813 - [lldb] Make TestDeletedExecutable more reliable

2019-07-11 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jul 11 12:27:33 2019 New Revision: 365813 URL: http://llvm.org/viewvc/llvm-project?rev=365813=rev Log: [lldb] Make TestDeletedExecutable more reliable Summary: It seems that calling Popen can return to the caller before the started process has read all the needed

[Lldb-commits] [lldb] r365812 - [lldb] Don't use __FUNCTION__ as a file name

2019-07-11 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jul 11 12:26:55 2019 New Revision: 365812 URL: http://llvm.org/viewvc/llvm-project?rev=365812=rev Log: [lldb] Don't use __FUNCTION__ as a file name Summary: I saw while debugging that we call this file `ParseInternal`, which is not a very good name for our fake

[Lldb-commits] [lldb] r365698 - [lldb] Fix handling of dollar characters in expr command

2019-07-10 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Jul 10 14:04:01 2019 New Revision: 365698 URL: http://llvm.org/viewvc/llvm-project?rev=365698=rev Log: [lldb] Fix handling of dollar characters in expr command Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/dollar-in-variable/

[Lldb-commits] [lldb] r365719 - [lldb] Disable TestDollarInVariable.py on Windows

2019-07-10 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Jul 10 17:35:31 2019 New Revision: 365719 URL: http://llvm.org/viewvc/llvm-project?rev=365719=rev Log: [lldb] Disable TestDollarInVariable.py on Windows It seems on Windows we don't handle the lldb_expr_result variable correctly: ``` AssertionError: False is not True

[Lldb-commits] [lldb] r365908 - [lldb] Let table gen create command option initializers.

2019-07-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 12 08:30:55 2019 New Revision: 365908 URL: http://llvm.org/viewvc/llvm-project?rev=365908=rev Log: [lldb] Let table gen create command option initializers. Summary: We currently have man large arrays containing initializers for our command options. These tables

[Lldb-commits] [lldb] r365090 - Refactor ObjectFile::GetSDKVersion

2019-07-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Jul 3 15:21:10 2019 New Revision: 365090 URL: http://llvm.org/viewvc/llvm-project?rev=365090=rev Log: Refactor ObjectFile::GetSDKVersion Summary: This patch modernizes the GetSDKVersion API and hopefully prevents problems such as the ones discovered in D61218.

[Lldb-commits] [lldb] r364967 - [lldb] Mention automatic codesign setup script [NFC]

2019-07-02 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jul 2 14:07:25 2019 New Revision: 364967 URL: http://llvm.org/viewvc/llvm-project?rev=364967=rev Log: [lldb] Mention automatic codesign setup script [NFC] The script is the modern way of getting the certificate, so we should mention it in the documentation. Patch

[Lldb-commits] [lldb] r359206 - Fixed typo in CompileUnit::GetImportedModules documentation [NFC]

2019-04-25 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Apr 25 10:08:54 2019 New Revision: 359206 URL: http://llvm.org/viewvc/llvm-project?rev=359206=rev Log: Fixed typo in CompileUnit::GetImportedModules documentation [NFC] Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h Modified:

[Lldb-commits] [lldb] r358477 - Correctly check if a warning message lacks a trailing new line

2019-04-16 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Apr 16 00:48:11 2019 New Revision: 358477 URL: http://llvm.org/viewvc/llvm-project?rev=358477=rev Log: Correctly check if a warning message lacks a trailing new line Summary: Fixes LLVM bug 41489. Reviewers: clayborg Reviewed By: clayborg Subscribers: lldb-commits

[Lldb-commits] [lldb] r358479 - Fix typo in ArmUnwindInfo::GetUnwindPlan

2019-04-16 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Apr 16 01:06:56 2019 New Revision: 358479 URL: http://llvm.org/viewvc/llvm-project?rev=358479=rev Log: Fix typo in ArmUnwindInfo::GetUnwindPlan Summary: As reported in LLVM bug 41486, the check `(byte1 & 0xf8) == 0xc0` is wrong. We want to check for `11010nnn`, so

[Lldb-commits] [lldb] r359087 - Shorten comment line to be below 80 characters [NFC]

2019-04-24 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Apr 24 05:21:03 2019 New Revision: 359087 URL: http://llvm.org/viewvc/llvm-project?rev=359087=rev Log: Shorten comment line to be below 80 characters [NFC] Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified:

[Lldb-commits] [lldb] r359089 - Minor code style fix in ClangUserExpression.cpp [NFC]

2019-04-24 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Apr 24 05:55:00 2019 New Revision: 359089 URL: http://llvm.org/viewvc/llvm-project?rev=359089=rev Log: Minor code style fix in ClangUserExpression.cpp [NFC] Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified:

[Lldb-commits] [lldb] r359281 - Allow direct comparison of ConstString against StringRef

2019-04-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Apr 26 00:21:36 2019 New Revision: 359281 URL: http://llvm.org/viewvc/llvm-project?rev=359281=rev Log: Allow direct comparison of ConstString against StringRef Summary: When we want to compare a ConstString against a string literal (or any other non-ConstString), we

[Lldb-commits] [lldb] r366196 - [lldb] Rename Options.inc to CommandOptions.inc [NFC]

2019-07-16 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jul 16 02:27:02 2019 New Revision: 366196 URL: http://llvm.org/viewvc/llvm-project?rev=366196=rev Log: [lldb] Rename Options.inc to CommandOptions.inc [NFC] It seems having two Options.inc files in the same project is giving our custom Xcode project a hard time. This

[Lldb-commits] [lldb] r368577 - [lldb] Remove undocumented return value from DiagnosticManager::PutString

2019-08-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 12 07:11:37 2019 New Revision: 368577 URL: http://llvm.org/viewvc/llvm-project?rev=368577=rev Log: [lldb] Remove undocumented return value from DiagnosticManager::PutString The returned value is currently unused. It also seems to imply that it somehow represents

[Lldb-commits] [lldb] r368567 - [lldb][NFC] Add unit test for lldb_private::DiagnosticManager

2019-08-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 12 06:31:45 2019 New Revision: 368567 URL: http://llvm.org/viewvc/llvm-project?rev=368567=rev Log: [lldb][NFC] Add unit test for lldb_private::DiagnosticManager Added: lldb/trunk/unittests/Expression/DiagnosticManagerTest.cpp Modified:

[Lldb-commits] [lldb] r368582 - [lldb][NFC] Minor fixes for lldb_private::DiagnosticManager

2019-08-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 12 07:37:12 2019 New Revision: 368582 URL: http://llvm.org/viewvc/llvm-project?rev=368582=rev Log: [lldb][NFC] Minor fixes for lldb_private::DiagnosticManager Modified: lldb/trunk/include/lldb/Expression/DiagnosticManager.h Modified:

[Lldb-commits] [lldb] r369113 - [lldb][NFC] Allow for-ranges on StringList

2019-08-16 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Aug 16 07:27:35 2019 New Revision: 369113 URL: http://llvm.org/viewvc/llvm-project?rev=369113=rev Log: [lldb][NFC] Allow for-ranges on StringList Modified: lldb/trunk/include/lldb/Utility/CompletionRequest.h lldb/trunk/include/lldb/Utility/StringList.h

[Lldb-commits] [lldb] r368920 - Revert "[lldb] Reinstate original guard variable check"

2019-08-14 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 14 14:21:14 2019 New Revision: 368920 URL: http://llvm.org/viewvc/llvm-project?rev=368920=rev Log: Revert "[lldb] Reinstate original guard variable check" It seems this breaks the following tests: lldb-Suite ::

[Lldb-commits] [lldb] r369237 - [lldb][NFC] Address review comments to StringList for-loop support

2019-08-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 19 00:22:19 2019 New Revision: 369237 URL: http://llvm.org/viewvc/llvm-project?rev=369237=rev Log: [lldb][NFC] Address review comments to StringList for-loop support Modified: lldb/trunk/include/lldb/Utility/StringList.h

[Lldb-commits] [lldb] r369240 - [lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute

2019-08-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 19 00:59:44 2019 New Revision: 369240 URL: http://llvm.org/viewvc/llvm-project?rev=369240=rev Log: [lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute Modified: lldb/trunk/source/Commands/CommandObjectApropos.cpp Modified:

[Lldb-commits] [lldb] r369242 - [lldb][NFC] Remove StringList::AutoComplete

2019-08-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 19 01:15:46 2019 New Revision: 369242 URL: http://llvm.org/viewvc/llvm-project?rev=369242=rev Log: [lldb][NFC] Remove StringList::AutoComplete We don't need this very specific function in StringList that we only call once in LLDB. Modified:

[Lldb-commits] [lldb] r369000 - [lldb][NFC] Refactor remaining completion logic to use CompletionRequests

2019-08-15 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 15 06:14:10 2019 New Revision: 369000 URL: http://llvm.org/viewvc/llvm-project?rev=369000=rev Log: [lldb][NFC] Refactor remaining completion logic to use CompletionRequests This patch moves the remaining completion functions from the old completion API (that used

[Lldb-commits] [lldb] r368975 - [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures

2019-08-15 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 15 00:29:53 2019 New Revision: 368975 URL: http://llvm.org/viewvc/llvm-project?rev=368975=rev Log: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures Summary: When building with modules we currently fail randomly to build

[Lldb-commits] [lldb] r368511 - [lldb] Fix dynamic_cast by no longer failing on variable without metadata

2019-08-10 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Aug 10 03:56:17 2019 New Revision: 368511 URL: http://llvm.org/viewvc/llvm-project?rev=368511=rev Log: [lldb] Fix dynamic_cast by no longer failing on variable without metadata Summary: Our IR rewriting infrastructure currently fails when it encounters a variable

[Lldb-commits] [lldb] r369267 - [lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test

2019-08-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 19 07:52:48 2019 New Revision: 369267 URL: http://llvm.org/viewvc/llvm-project?rev=369267=rev Log: [lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test This function is just a wrapper for GetNumberOfResults and will be removed soon. This patch just

[Lldb-commits] [lldb] r369293 - [lldb] Make TestIOHandlerCompletion more stable and document it

2019-08-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 19 12:13:26 2019 New Revision: 369293 URL: http://llvm.org/viewvc/llvm-project?rev=369293=rev Log: [lldb] Make TestIOHandlerCompletion more stable and document it Instead of relying that three tabs show all completions, we should show all remaining completions

[Lldb-commits] [lldb] r369353 - [lldb][NFC] Test quotes when completing

2019-08-20 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 20 02:26:58 2019 New Revision: 369353 URL: http://llvm.org/viewvc/llvm-project?rev=369353=rev Log: [lldb][NFC] Test quotes when completing Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py Modified:

[Lldb-commits] [lldb] r368695 - [lldb] Fix Microsoft guard variable detection

2019-08-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 13 07:13:39 2019 New Revision: 368695 URL: http://llvm.org/viewvc/llvm-project?rev=368695=rev Log: [lldb] Fix Microsoft guard variable detection Apparently we need to check for a suffix, not a prefix. This broke probably broke expression evaluation on Windows.

[Lldb-commits] [lldb] r368688 - [lldb] Reland "Refactor guard variable checks in IRForTarget"

2019-08-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 13 06:09:18 2019 New Revision: 368688 URL: http://llvm.org/viewvc/llvm-project?rev=368688=rev Log: [lldb] Reland "Refactor guard variable checks in IRForTarget" It seems the broken guard variable check for Windows was a feature(TM) and not a bug, so let's keep add

[Lldb-commits] [lldb] r368679 - [lldb][NFC] Add basic IOHandler completion test

2019-08-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 13 05:12:19 2019 New Revision: 368679 URL: http://llvm.org/viewvc/llvm-project?rev=368679=rev Log: [lldb][NFC] Add basic IOHandler completion test We have no test coverage for the IOHandler code that is doing the completion in the command line. This is adding a

[Lldb-commits] [lldb] r369198 - [lldb][NFC] Remove unused MaterializeInitializer and MaterializeInternalVariable

2019-08-17 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Aug 17 14:57:51 2019 New Revision: 369198 URL: http://llvm.org/viewvc/llvm-project?rev=369198=rev Log: [lldb][NFC] Remove unused MaterializeInitializer and MaterializeInternalVariable Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

[Lldb-commits] [lldb] r369252 - [lldb][NFC] Use CompletionRequest in Variable::AutoComplete

2019-08-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 19 04:49:43 2019 New Revision: 369252 URL: http://llvm.org/viewvc/llvm-project?rev=369252=rev Log: [lldb][NFC] Use CompletionRequest in Variable::AutoComplete Modified: lldb/trunk/source/Symbol/Variable.cpp Modified: lldb/trunk/source/Symbol/Variable.cpp URL:

[Lldb-commits] [lldb] r369249 - [lldb][NFC] Add a few more completion tests to increase test coverage

2019-08-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 19 03:46:38 2019 New Revision: 369249 URL: http://llvm.org/viewvc/llvm-project?rev=369249=rev Log: [lldb][NFC] Add a few more completion tests to increase test coverage These tests are mostly trying to reach the different completion functions in

[Lldb-commits] [lldb] r369625 - [lldb][NFC] Remove dead code that is supposed to handle invalid command options

2019-08-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 22 01:08:05 2019 New Revision: 369625 URL: http://llvm.org/viewvc/llvm-project?rev=369625=rev Log: [lldb][NFC] Remove dead code that is supposed to handle invalid command options Summary: We currently have a bunch of code that is supposed to handle invalid command

[Lldb-commits] [lldb] r369632 - [lldb][NFC] NFC cleanup for the completion code

2019-08-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 22 02:02:54 2019 New Revision: 369632 URL: http://llvm.org/viewvc/llvm-project?rev=369632=rev Log: [lldb][NFC] NFC cleanup for the completion code Modified: lldb/trunk/source/Commands/CommandObjectHelp.cpp

[Lldb-commits] [lldb] r369635 - [lldb][NFC] Remove unused return value from HandleOptionArgumentCompletion

2019-08-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 22 02:14:42 2019 New Revision: 369635 URL: http://llvm.org/viewvc/llvm-project?rev=369635=rev Log: [lldb][NFC] Remove unused return value from HandleOptionArgumentCompletion Modified: lldb/trunk/include/lldb/Interpreter/Options.h

[Lldb-commits] [lldb] r369660 - [lldb] Remove ')' to fix the build

2019-08-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 22 08:18:40 2019 New Revision: 369660 URL: http://llvm.org/viewvc/llvm-project?rev=369660=rev Log: [lldb] Remove ')' to fix the build That ')' slipped in by accident in the reformatting commit. Modified: lldb/trunk/source/Commands/CommandObjectProcess.cpp

[Lldb-commits] [lldb] r369652 - [lldb][NFC] Fix indentation in CommandObjectProcess

2019-08-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 22 06:50:54 2019 New Revision: 369652 URL: http://llvm.org/viewvc/llvm-project?rev=369652=rev Log: [lldb][NFC] Fix indentation in CommandObjectProcess Modified: lldb/trunk/source/Commands/CommandObjectProcess.cpp Modified:

[Lldb-commits] [lldb] r369646 - [lldb][NFC] Add test for target stop-hook disable/enable/delete

2019-08-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 22 06:09:02 2019 New Revision: 369646 URL: http://llvm.org/viewvc/llvm-project?rev=369646=rev Log: [lldb][NFC] Add test for target stop-hook disable/enable/delete Modified:

[Lldb-commits] [lldb] r369939 - [lldb][NFC] Remove dead code that handles situations where LLDB has no dummy target

2019-08-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 26 11:12:44 2019 New Revision: 369939 URL: http://llvm.org/viewvc/llvm-project?rev=369939=rev Log: [lldb][NFC] Remove dead code that handles situations where LLDB has no dummy target Summary: We always have a dummy target, so any error handling regarding a

[Lldb-commits] [lldb] r370043 - [lldb] Allow partial completions to fix directory completion.

2019-08-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 27 04:32:22 2019 New Revision: 370043 URL: http://llvm.org/viewvc/llvm-project?rev=370043=rev Log: [lldb] Allow partial completions to fix directory completion. On the command line we usually insert a space after a completion to indicate that the completion was

[Lldb-commits] [lldb] r370047 - [lldb][NFC] Give added test method a unique name

2019-08-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 27 04:43:54 2019 New Revision: 370047 URL: http://llvm.org/viewvc/llvm-project?rev=370047=rev Log: [lldb][NFC] Give added test method a unique name Otherwise dotest doesn't run the test and just lets it always pass. Also update the comment to explain that we do

[Lldb-commits] [lldb] r370050 - [lldb][NFC] Add some tests for the target subcommands

2019-08-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 27 04:57:26 2019 New Revision: 370050 URL: http://llvm.org/viewvc/llvm-project?rev=370050=rev Log: [lldb][NFC] Add some tests for the target subcommands Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py

[Lldb-commits] [lldb] r370057 - [lldb][NFC] Add missing invalid_core_file to TestTargetCommand test

2019-08-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 27 06:34:15 2019 New Revision: 370057 URL: http://llvm.org/viewvc/llvm-project?rev=370057=rev Log: [lldb][NFC] Add missing invalid_core_file to TestTargetCommand test Added:

[Lldb-commits] [lldb] r370440 - [lldb][NFC] Move Clang-specific flags to ClangUserExpression

2019-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Aug 30 00:44:29 2019 New Revision: 370440 URL: http://llvm.org/viewvc/llvm-project?rev=370440=rev Log: [lldb][NFC] Move Clang-specific flags to ClangUserExpression LLVMUserExpression doesn't use these variables and they are all specific to Clang. Also removes

[Lldb-commits] [lldb] r370174 - [lldb][NFC] Update documentation of Handle[Argument]Completion

2019-08-28 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 28 02:02:32 2019 New Revision: 370174 URL: http://llvm.org/viewvc/llvm-project?rev=370174=rev Log: [lldb][NFC] Update documentation of Handle[Argument]Completion We no longer have return values or any of the mentioned arguments in these functions since the

[Lldb-commits] [lldb] r370503 - [lldb][NFC] More tests for invalid register command invocations

2019-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Aug 30 12:19:25 2019 New Revision: 370503 URL: http://llvm.org/viewvc/llvm-project?rev=370503=rev Log: [lldb][NFC] More tests for invalid register command invocations Modified:

[Lldb-commits] [lldb] r370570 - [lldb][NFC] Remove unused prompt variable in TestMultilineCompletion.py

2019-08-31 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Aug 31 02:40:26 2019 New Revision: 370570 URL: http://llvm.org/viewvc/llvm-project?rev=370570=rev Log: [lldb][NFC] Remove unused prompt variable in TestMultilineCompletion.py Modified:

[Lldb-commits] [lldb] r370571 - [lldb] Unify target checking in CommandObject

2019-08-31 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Aug 31 02:41:25 2019 New Revision: 370571 URL: http://llvm.org/viewvc/llvm-project?rev=370571=rev Log: [lldb] Unify target checking in CommandObject Summary: We currently have several CommandObjects that manually reimplement the checking for a selected target or a

[Lldb-commits] [lldb] r370616 - [lldb][NFC] Fix failing tests on macOS after restructuring test folder

2019-09-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun Sep 1 09:30:06 2019 New Revision: 370616 URL: http://llvm.org/viewvc/llvm-project?rev=370616=rev Log: [lldb][NFC] Fix failing tests on macOS after restructuring test folder Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/add-dsym/uuid/Makefile

[Lldb-commits] [lldb] r370611 - [lldb][NFC] Fix failing tests after restructuring test folder

2019-09-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun Sep 1 06:36:44 2019 New Revision: 370611 URL: http://llvm.org/viewvc/llvm-project?rev=370611=rev Log: [lldb][NFC] Fix failing tests after restructuring test folder Just adjusts all the relative paths in the Makefiles (and the breakpoint test which seems to rely on

[Lldb-commits] [lldb] r370724 - [lldb][NFC] Test that enabling all log options doesn't crash anything

2019-09-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Sep 3 02:40:25 2019 New Revision: 370724 URL: http://llvm.org/viewvc/llvm-project?rev=370724=rev Log: [lldb][NFC] Test that enabling all log options doesn't crash anything Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py

[Lldb-commits] [lldb] r370734 - [lldb] Test 'frame select -r' and fix that INT32_MIN breaks the option parser

2019-09-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Sep 3 03:15:45 2019 New Revision: 370734 URL: http://llvm.org/viewvc/llvm-project?rev=370734=rev Log: [lldb] Test 'frame select -r' and fix that INT32_MIN breaks the option parser Added: lldb/trunk/packages/Python/lldbsuite/test/commands/frame/select/

[Lldb-commits] [lldb] r370719 - [lldb][NFC] Remove unnecessary constructors from invalid-args tests

2019-09-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Sep 3 02:25:02 2019 New Revision: 370719 URL: http://llvm.org/viewvc/llvm-project?rev=370719=rev Log: [lldb][NFC] Remove unnecessary constructors from invalid-args tests Modified:

[Lldb-commits] [lldb] r370718 - [lldb][NFC] Simplify script_alias test

2019-09-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Sep 3 02:21:47 2019 New Revision: 370718 URL: http://llvm.org/viewvc/llvm-project?rev=370718=rev Log: [lldb][NFC] Simplify script_alias test Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/command/script_alias/TestCommandScriptAlias.py Modified:

<    1   2   3   4   5   6   7   8   9   10   >