This change went up here, with a couple tweaks to documentation (per Greg
and another minor grammatical fix):
svn commit
Sendingsource/Target/Target.cpp
Transmitting file data .
Committed revision 218405.
On Wed, Sep 24, 2014 at 11:08 AM, Todd Fiala wrote:
> Doug - I'll get this in.
>
Doug - I'll get this in.
On Wed, Sep 24, 2014 at 11:04 AM, Greg Clayton wrote:
> Just replace "eInlineBreakpointsHeaders" with "headers" and you are good
> to go.
>
> > On Sep 24, 2014, at 11:01 AM, Doug Snyder
> wrote:
> >
> > i'll fix that and create a new patch
> >
> >
> >
> > On Wed, Sep 24
i'll fix that and create a new patch
On Wed, Sep 24, 2014 at 10:57 AM, Greg Clayton wrote:
> The text is wrong in the help text. It should't mention
> "eInlineBreakpointsHeaders", but it should mention "headers" (the actual
> text you would type for the settings set command). Other than that,
Just replace "eInlineBreakpointsHeaders" with "headers" and you are good to go.
> On Sep 24, 2014, at 11:01 AM, Doug Snyder wrote:
>
> i'll fix that and create a new patch
>
>
>
> On Wed, Sep 24, 2014 at 10:57 AM, Greg Clayton wrote:
> The text is wrong in the help text. It should't mention
The text is wrong in the help text. It should't mention
"eInlineBreakpointsHeaders", but it should mention "headers" (the actual text
you would type for the settings set command). Other than that, it looks good.
> On Sep 23, 2014, at 3:22 PM, Todd Fiala wrote:
>
> I think the patch might be mi
I think the patch might be missing from that mail. Here it is though:
On Tue, Sep 23, 2014 at 3:20 PM, Doug Snyder
wrote:
> here is a patch that sets the default to eInlineBreakpointsAlways. it
> also changes the associated comment text, since the old text
> was eInlineBreakpointsHeaders-def
here is a patch that sets the default to eInlineBreakpointsAlways. it also
changes the associated comment text, since the old text
was eInlineBreakpointsHeaders-default-centric
i manually tested it with lldb using one of my test cases and ran
check-lldb on ubuntu to make sure it wasn't breaking o
I would vote to switch over to using "always" as the default setting and then
let people who run into performance problems set it to "headers"
I am not fond of the two state approach because you might be trying to set a
breakpoint a shared library that isn't loaded yet.
More comments below:
>