[lldb-dev] llvm::to_integer

2017-05-15 Thread Zachary Turner via lldb-dev
In the past I've advocated for use of StringRef::getAsInteger(). Sometimes this leads to awkward code, for example if you have a std::string you have to write StringRef(Str).getAsInteger(). Secondly, the return value is extremely confusing as it returns true on failure and false on success. I re

[lldb-dev] [Bug 33042] New: Unable to read return value of arm64 functions returning large objects

2017-05-15 Thread via lldb-dev
https://bugs.llvm.org/show_bug.cgi?id=33042 Bug ID: 33042 Summary: Unable to read return value of arm64 functions returning large objects Product: lldb Version: unspecified Hardware: PC OS: Linux

Re: [lldb-dev] lldb-server tests

2017-05-15 Thread Zachary Turner via lldb-dev
One thing about lit that most people either don't understand or forget about is that FileCheck has nothing to do with lit. You can have lit tests without FileCheck. It's more work because you would have to define an LLDBServerTestFormat and invent some DSL that isn't just a bunch of run lines and c

Re: [lldb-dev] lldb-server tests

2017-05-15 Thread Kamil Rytarowski via lldb-dev
Thank you for this work. I will add a usual requirement - please make sure that "check-lldb-unit" works in standalone builds. On 15.05.2017 16:33, Pavel Labath wrote: > Hello all, > > In case you haven't noticed it, I'd like to draw your attention to > D32930, where we're proposing a new test fr

[lldb-dev] lldb-server tests

2017-05-15 Thread Pavel Labath via lldb-dev
Hello all, In case you haven't noticed it, I'd like to draw your attention to D32930, where we're proposing a new test framework for lldb-server tests. The discussion has so far been about low-level implementation details, so you don't have to read through it if you don't feel like to (but I do en

Re: [lldb-dev] Unable to build LLDB 4.0 on Debian Linux

2017-05-15 Thread Pavel Labath via lldb-dev
If you set enough cmake variables, you can certainly force cmake to do the build checks with -Werror. I am asking for the build command to rule that out (among other things) On 15 May 2017 at 11:57, Zachary Turner wrote: > Again, this has nothing to do with our build files, it is in cmakes intern

Re: [lldb-dev] Unable to build LLDB 4.0 on Debian Linux

2017-05-15 Thread Zachary Turner via lldb-dev
Again, this has nothing to do with our build files, it is in cmakes internal builtin modules when it is trying to compile a program to see if a symbol exists. This looks like a cmake bug, try upgrading cmake On Mon, May 15, 2017 at 1:25 AM Pavel Labath wrote: > Technically, it's the combination o

Re: [lldb-dev] Unable to build LLDB 4.0 on Debian Linux

2017-05-15 Thread Pavel Labath via lldb-dev
Technically, it's the combination of -Werror and -pedantic which is causing the problem. Any single one of them would be fine :) I am not sure what could be the problem, LLDB's build files do not explicitly add any of these flags, so they must be coming from somewhere else. Without more informatio