Re: [lldb-dev] [cfe-dev] stable layout bug for imported record decls.

2018-08-13 Thread Richard Smith via lldb-dev
On Mon, 13 Aug 2018 at 17:08, Lang Hames via cfe-dev wrote: > Hi Richard, > > Perhaps a better approach would be to make the "minimal" mode for the >> ASTImporter provide an ExternalASTSource to lazily complete the AST as >> needed (thereby avoiding violating the invariant, because you would >> p

Re: [lldb-dev] [cfe-dev] stable layout bug for imported record decls.

2018-08-13 Thread Lang Hames via lldb-dev
Hi Richard, Perhaps a better approach would be to make the "minimal" mode for the > ASTImporter provide an ExternalASTSource to lazily complete the AST as > needed (thereby avoiding violating the invariant, because you would > populate the lexical declarations list whenever anyone actually asks fo

Re: [lldb-dev] Failing LIT-based lldb-mi tests

2018-08-13 Thread Adrian Prantl via lldb-dev
> On Aug 13, 2018, at 4:19 PM, Александр Поляков wrote: > > Yes, I do, I'm able to pass any command to lldb-mi before the breakpoint is > hit. I guess that making exec-run to block the control until the process > stops might be the solution we are looking for. Right. I believe that it should

Re: [lldb-dev] Failing LIT-based lldb-mi tests

2018-08-13 Thread Александр Поляков via lldb-dev
Yes, I do, I'm able to pass any command to lldb-mi before the breakpoint is hit. I guess that making exec-run to block the control until the process stops might be the solution we are looking for. On Mon, Aug 13, 2018 at 11:18 PM Adrian Prantl wrote: > > > On Aug 13, 2018, at 11:54 AM, Александр

Re: [lldb-dev] [cfe-dev] stable layout bug for imported record decls.

2018-08-13 Thread Richard Smith via lldb-dev
On Thu, 9 Aug 2018 at 10:47, Lang Hames via cfe-dev wrote: > Hi clang-dev, lldb-dev, > > It looks like my clang commit r305850, which modified ASTImporter to > import method override tables from an external context, introduced a new > bug which manifests as incorrect vtable layouts for LLDB expre

Re: [lldb-dev] stable layout bug for imported record decls.

2018-08-13 Thread Lang Hames via lldb-dev
Hi Alexey, Gábor, Thank you so much for this information. This is very helpful! One trivial solution would be to change `ImporDeclContext` to behave > the same way in both modes. This is somewhat similar to the "brute > force" method you mentioned. > I am not an LLDB expert, so I am not sure if t

Re: [lldb-dev] Failing LIT-based lldb-mi tests

2018-08-13 Thread Adrian Prantl via lldb-dev
> On Aug 13, 2018, at 11:54 AM, Александр Поляков > wrote: > > Oops, I made a mistake, I typed break-insert main. Here is the right output: > > build/bin/lldb-mi a.out > (gdb) > -file-exec-and-symbols "a.out" > ^done > (gdb) > =library-loaded,id="/home/alexander/workspace/gsoc/a.out",target-

Re: [lldb-dev] [GSoC] Re-implement lldb-mi on top of the LLDB public API

2018-08-13 Thread Александр Поляков via lldb-dev
There are lots of them, so I don't think I can list them all. But if you are interested in some command you need to do a few simple steps: 1) go to GDB/MI specification and find the command you are interested in; 2) go to lldb-mi and try t

Re: [lldb-dev] [GSoC] Re-implement lldb-mi on top of the LLDB public API

2018-08-13 Thread Leonard Mosescu via lldb-dev
Can you please list the missing MI commands? This would be very valuable to both future contributors and also to the users of the LLDB MI. Thanks! On Mon, Aug 13, 2018 at 11:28 AM, Александр Поляков wrote: > Thank you, Leonard, > I'm going to keep contributing to LLVM, so I think this is not the

Re: [lldb-dev] Failing LIT-based lldb-mi tests

2018-08-13 Thread Александр Поляков via lldb-dev
Oops, I made a mistake, I typed break-insert main. Here is the right output: build/bin/lldb-mi a.out (gdb) -file-exec-and-symbols "a.out" ^done (gdb) =library-loaded,id="/home/alexander/workspace/gsoc/a.out",target-name="/home/alexander/workspace/gsoc/a.out",host-name="/home/alexander/workspace/gs

Re: [lldb-dev] Failing LIT-based lldb-mi tests

2018-08-13 Thread Александр Поляков via lldb-dev
Sure, this is the log with the typed commands: build/bin/lldb-mi a.out (gdb) -file-exec-and-symbols "a.out" ^done (gdb) =library-loaded,id="/home/alexander/workspace/gsoc/a.out",target-name="/home/alexander/workspace/gsoc/a.out",host-name="/home/alexander/workspace/gsoc/a.out",symbols-loaded="0",l

Re: [lldb-dev] [GSoC] Re-implement lldb-mi on top of the LLDB public API

2018-08-13 Thread Александр Поляков via lldb-dev
Thank you, Leonard, I'm going to keep contributing to LLVM, so I think this is not the end! On Mon, Aug 13, 2018 at 8:15 PM Leonard Mosescu wrote: > Nice to see great progress in this area! > > On Sun, Aug 12, 2018 at 2:49 PM, Александр Поляков via lldb-dev < > lldb-dev@lists.llvm.org> wrote: >

Re: [lldb-dev] [GSoC] Re-implement lldb-mi on top of the LLDB public API

2018-08-13 Thread Leonard Mosescu via lldb-dev
Nice to see great progress in this area! On Sun, Aug 12, 2018 at 2:49 PM, Александр Поляков via lldb-dev < lldb-dev@lists.llvm.org> wrote: > Hi LLVM folks, > > During this summer I was working on re-implementing of lldb-mi to > correctly use LLDB public API. You are welcome to read my final repor

Re: [lldb-dev] Failing LIT-based lldb-mi tests

2018-08-13 Thread Adrian Prantl via lldb-dev
> On Aug 11, 2018, at 3:58 AM, Александр Поляков wrote: > > I reproduced the test you suggested and got following output: > > build/bin/lldb-mi --synchronous a.out < > llvm/tools/lldb/lit/tools/lldb-mi/exec/lldb-mi-fail.test > (gdb) > -file-exec-and-symbols "a.out" > ^done > (gdb) > ^done >