"Robinson, Paul via Openmp-dev" writes:
> David Greene, will you be at the LLVM Dev Meeting? If so, could you sign
> up for a Round Table session on this topic? Obviously lots to discuss
> and concerns to be addressed.
That's a great idea. I will be there. I'm also hoping to help run a
routab
"Robinson, Paul via Openmp-dev" writes:
>> I always ran check-all before every patch, FWIW.
>
> Yep. Although I run check-all before *starting* on a patch, to make sure
> the starting point is clean. It usually is, but I've been caught enough
> times to be slightly wary.
This is interesting.
> I'm inclined to the direction suggested by others that the monorepo is
> orthogonal to this issue and top level tests might not be the right thing.
>
> lldb already does end-to-end testing in its tests, for instance.
>
> Clang does in some tests (the place I always hit is anything that's
> config
On Wed, Oct 16, 2019 at 6:05 PM David Greene wrote:
> > I'm inclined to the direction suggested by others that the monorepo is
> > orthogonal to this issue and top level tests might not be the right
> thing.
> >
> > lldb already does end-to-end testing in its tests, for instance.
> >
> > Clang do
On Wed, 16 Oct 2019 at 21:00, David Greene wrote:
> Can you elaborate? I'm talking about very small tests targeted to
> generate a specific instruction or small number of instructions.
> Vectorization isn't the best example. Something like verifying FMA
> generation is a better example.
To chec
Renato wrote:
> If you want to do the test in Clang all the way to asm, you need to
> make sure the back-end is built. Clang is not always build with all
> back-ends, possibly even none.
This is no different than today. Many tests in Clang require a specific
target to exist. Grep clang/test for "r
On Thu, 17 Oct 2019 at 16:28, Robinson, Paul wrote:
> This is no different than today. Many tests in Clang require a specific
> target to exist. Grep clang/test for "registered-target" for example;
> I get 577 hits. Integration tests (here called "end-to-end" tests)
> clearly need to specify thei
On Thu, 17 Oct 2019 at 18:10, David Greene wrote:
> From other discussion, it sounds like at least some people are open to
> asm tests under clang. I think that should be fine. But there are
> probably other kinds of end-to-end tests that should not live under
> clang.
That is my position as we
On Fri, 18 Oct 2019 at 16:30, David Greene wrote:
> I have been viewing test-suite as a kind of second-level/backup testing
> that catches things not flagged by "make check-all." Is that a
> reasonable interpretation? I was hoping to get some end-to-end tests
> under "make check-all" because tha
