> On Feb 23, 2018, at 3:17 PM, Vedant Kumar via lldb-dev
> wrote:
>
> Hi,
>
> At the moment, I'm seeing two issues with the unit tests on my machine.
>
> First, TestBase.LaunchModePreservesEnvironment is failing:
>
>> [ RUN ] TestBase.LaunchModePreservesEnvironment
>> /Users/vsk/src/llv
On 23 February 2018 at 16:19, Adrian McCarthy wrote:
> I'm also seeing windows appear and quickly vanish a several times while
> running the lit tests.
That's because the tests run inferiors and lldb on windows will always
run them in a separate console window. IIRC, there is a special hack
in do
Yeah, if a lit test fails, the dotest tests will not get run. That is
fine, but having a target which only runs dotest tests would probably
be nice as well.
On 23 February 2018 at 16:15, Vedant Kumar wrote:
> check-lldb-lit should just be a dependency of check-lldb, so the dotest.py
> tests shoul
Actually, it appears one of the lit tests is unexpectedly passing:
Unexpected Passing Tests (1):
lldb :: Expr/TestCallStdStringFunction.test
lit then returns an error code, and ninja bails before starting the
dotest.py tests:
FAILED: cmd.exe /C "cd /D D:\src\llvm\build\mono\tools\lldb\lit &&
check-lldb-lit should just be a dependency of check-lldb, so the dotest.py
tests should still run.
Are one of the lit tests failing? That might explain why subsequent tests
aren't run.
vedant
> On Feb 23, 2018, at 4:13 PM, Adrian McCarthy wrote:
>
> As of this afternoon, it seems ninja check
As of this afternoon, it seems ninja check-lldb runs *only* the lit tests
and not the dotest.py tests. Was this an intentional change?
On Fri, Feb 23, 2018 at 3:36 PM, Vedant Kumar via lldb-dev <
lldb-dev@lists.llvm.org> wrote:
> Cool, I'll work up a patch for this.
>
> And thanks for commenting
Cool, I'll work up a patch for this.
And thanks for commenting on PR36494, I'm testing a fix out right now :).
vedant
> On Feb 23, 2018, at 3:35 PM, Pavel Labath wrote:
>
> On 23 February 2018 at 15:17, Vedant Kumar wrote:
>> Second, TestClient::SendMessage is generating quite a lot of "INFO"
On 23 February 2018 at 15:17, Vedant Kumar wrote:
> Second, TestClient::SendMessage is generating quite a lot of "INFO" output
> which clutters up the terminal. Pavel, would you mind if I removed this
> logging?
>
Yeah, we should probably do that. The idea here was that the packet
log would pro
Hi,
At the moment, I'm seeing two issues with the unit tests on my machine.
First, TestBase.LaunchModePreservesEnvironment is failing:
> [ RUN ] TestBase.LaunchModePreservesEnvironment
> /Users/vsk/src/llvm.org-lldbsan/llvm/tools/lldb/unittests/tools/lldb-server/tests/LLGSTest.cpp:30:
> Fa