Re: [lldb-dev] Handling callable addresses

2018-06-22 Thread Tatyana Krasnukha via lldb-dev
Could you suggest any public buildbots where I can test such things for ARM, MIPS and others? > -Original Message- > From: Pavel Labath > Sent: Friday, 22 June, 2018 1:23 PM > To: Tatyana Krasnukha > Cc: Jim Ingham ; LLDB ; Greg > Clayton > Subject: Re: [lldb-d

Re: [lldb-dev] Handling callable addresses

2018-06-22 Thread Pavel Labath via lldb-dev
+1 While creating the architecture plugin, I noticed that this code could be moved there, but never got around to doing that. If the code is indeed equivalent, then we can make a utility function or a common base class that both plugins can then reuse. On Thu, 21 Jun 2018 at 23:34, Greg Clayton vi

Re: [lldb-dev] Handling callable addresses

2018-06-21 Thread Greg Clayton via lldb-dev
We now have architecture plug-ins. Target::GetCallableLoadAddress should defer to the architecture plug-ins and any functionality should be moved into those plug-ins. There is one for ARM. We will need to make one for MIPS. > On Jun 21, 2018, at 1:58 PM, Jim Ingham via lldb-dev > wrote: > >

Re: [lldb-dev] Handling callable addresses

2018-06-21 Thread Jim Ingham via lldb-dev
It's actually a little lame that we have a switch over architectures in generic Target code. This should be gotten from the architecture plugin. GetBreakableLoadAddress is even worse, there's ~150 lines of MIPS specific code in Target.cpp, which seems really wrong to me. Not really answering

[lldb-dev] Handling callable addresses

2018-06-21 Thread Tatyana Krasnukha via lldb-dev
Hi, It seems Target::GetCallableLoadAddress does equivalent things for arm/thumb and for mipses, just written in different forms. May I join these cases together? ___ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l