Re: [lldb-dev] Patch for ValueObjectPrinter::PrintChildrenIfNeeded

2019-03-06 Thread Ted Woodward via lldb-dev
/Contributing.html Ted > -Original Message- > From: lldb-dev On Behalf Of Nat! via lldb- > dev > Sent: Wednesday, March 6, 2019 8:47 AM > To: lldb-dev@lists.llvm.org > Subject: [EXT] [lldb-dev] Patch for ValueObjectPrinter::PrintChildrenIfNeeded > > I couldn'

[lldb-dev] Patch for ValueObjectPrinter::PrintChildrenIfNeeded

2019-03-06 Thread Nat! via lldb-dev
I couldn't figure out how to post a patch to reviews.llvm.org, so here it is per email, with the hope that someone adopts it :) Basically it's just moving the `bool print_oneline` out of the execution path, if no children are printed, since this value is then never used. This may not seem