Re: [lldb-dev] purpose of ProcessGDBRemote::m_flags

2017-11-03 Thread Pavel Labath via lldb-dev
clayb...@gmail.com] > Sent: Friday, 3 November, 2017 9:37 PM > To: Tatyana Krasnukha > Cc: lldb-dev@lists.llvm.org > Subject: Re: [lldb-dev] purpose of ProcessGDBRemote::m_flags > > > > If this isn't used, then this should be removed. Anything dynamic settings > that a

Re: [lldb-dev] purpose of ProcessGDBRemote::m_flags

2017-11-03 Thread Tatyana Krasnukha via lldb-dev
: Re: [lldb-dev] purpose of ProcessGDBRemote::m_flags If this isn't used, then this should be removed. Anything dynamic settings that are retrieved need to be abstracted into this class. There isn't a need for an extra plug-in as ProcessGDBRemote handles all variants of GDB remote serve

Re: [lldb-dev] purpose of ProcessGDBRemote::m_flags

2017-11-03 Thread Greg Clayton via lldb-dev
If this isn't used, then this should be removed. Anything dynamic settings that are retrieved need to be abstracted into this class. There isn't a need for an extra plug-in as ProcessGDBRemote handles all variants of GDB remote servers and it should encapsulate all that is needed to use any GDB

Re: [lldb-dev] purpose of ProcessGDBRemote::m_flags

2017-11-03 Thread Pavel Labath via lldb-dev
If it's not used, we should just remove it. Once we have a use case for something like that, we can consider whether the Architecture plugin would be the proper place for it. On 3 November 2017 at 14:27, Tatyana Krasnukha via lldb-dev wrote: > Hello, > > > > I have questions about ProcessGDBRemo

[lldb-dev] purpose of ProcessGDBRemote::m_flags

2017-11-03 Thread Tatyana Krasnukha via lldb-dev
Hello, I have questions about ProcessGDBRemote::m_flags member. Seems like it is never used. What is the purpose of it and what is the reason to do accessors protected, even constant getter? And other question: isn't it better to move this member to new plugin Architecture to be able to store d