[llvm-branch-commits] [mlir] [mlir][Transforms] Encapsulate dialect conversion options in `ConversionConfig` (PR #82250)

2024-02-22 Thread Jacques Pienaar via llvm-branch-commits
@@ -1070,6 +1072,30 @@ class PDLConversionConfig final { #endif // MLIR_ENABLE_PDL_IN_PATTERNMATCH +//===--===// +// ConversionConfig

[llvm-branch-commits] [mlir] [mlir][Transforms] Encapsulate dialect conversion options in `ConversionConfig` (PR #82250)

2024-02-22 Thread Jacques Pienaar via llvm-branch-commits
https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/82250 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms] Encapsulate dialect conversion options in `ConversionConfig` (PR #82250)

2024-02-22 Thread Jacques Pienaar via llvm-branch-commits
https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/82250 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn unresolved materializations into `IRRewrite`s (PR #81761)

2024-02-22 Thread Jacques Pienaar via llvm-branch-commits
https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/81761 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] ReleaseNotes: mention -mtls-dialect=desc (PR #82731)

2024-02-22 Thread Paul Kirth via llvm-branch-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/82731 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] ReleaseNotes: mention -mtls-dialect=desc (PR #82731)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/82731.diff 1 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) ``diff diff --git a/clang/docs/ReleaseNotes.rst

[llvm-branch-commits] [clang] ReleaseNotes: mention -mtls-dialect=desc (PR #82731)

2024-02-22 Thread Fangrui Song via llvm-branch-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/82731 None >From 9e42ddc522436a1129ba5a5e014035ca00262cc0 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 22 Feb 2024 19:57:15 -0800 Subject: [PATCH] ReleaseNotes: mention -mtls-dialect=desc ---

[llvm-branch-commits] [clang] ReleaseNotes: mention -mtls-dialect=desc (PR #82731)

2024-02-22 Thread Fangrui Song via llvm-branch-commits
https://github.com/MaskRay milestoned https://github.com/llvm/llvm-project/pull/82731 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Add details about string annotations (PR #82730)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Tacet (AdvenamTacet) Changes This commit adds information that only long strings are annotated, and with all allocators by default. To read why short string annotations are not turned on yet, read comments in a related PR:

[llvm-branch-commits] [libcxx] [libc++] Add details about string annotations (PR #82730)

2024-02-22 Thread via llvm-branch-commits
https://github.com/AdvenamTacet created https://github.com/llvm/llvm-project/pull/82730 This commit adds information that only long strings are annotated, and with all allocators by default. To read why short string annotations are not turned on yet, read comments in a related PR:

[llvm-branch-commits] [OpenMP][MLIR] Add new partial_map and members_index arguments to omp.map_info operations to help support record type mapping (PR #81509)

2024-02-22 Thread via llvm-branch-commits
agozillon wrote: a little ping for some reviewer attention if at all possible please to get some forward momentum on the PR stack, thank you very much ahead of time! https://github.com/llvm/llvm-project/pull/81509 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [OpenMP][MLIR] Extend explicit derived type member mapping support for OpenMP dialects lowering to LLVM-IR (PR #81510)

2024-02-22 Thread via llvm-branch-commits
agozillon wrote: a little ping for some reviewer attention if at all possible please to get some forward momentum on the PR stack, thank you very much ahead of time! https://github.com/llvm/llvm-project/pull/81510 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [Flang][OpenMP][MLIR] Extend derived (record) type map support in Flang OpenMP by adding some initial support for explicit member mapping (PR #81511)

2024-02-22 Thread via llvm-branch-commits
agozillon wrote: Rebased on recent changes to the OpenMP lowering! Plus a little ping for some reviewer attention if at all possible please to get some forward momentum on the PR stack, thank you very much ahead of time! https://github.com/llvm/llvm-project/pull/81511

[llvm-branch-commits] [Flang][OpenMP][MLIR] Extend derived (record) type map support in Flang OpenMP by adding some initial support for explicit member mapping (PR #81511)

2024-02-22 Thread via llvm-branch-commits
https://github.com/agozillon updated https://github.com/llvm/llvm-project/pull/81511 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [Flang][OpenMP][MLIR] Extend derived (record) type map support in Flang OpenMP by adding some initial support for explicit member mapping (PR #81511)

2024-02-22 Thread via llvm-branch-commits
https://github.com/agozillon updated https://github.com/llvm/llvm-project/pull/81511 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [OpenMP][MLIR] Extend explicit derived type member mapping support for OpenMP dialects lowering to LLVM-IR (PR #81510)

2024-02-22 Thread via llvm-branch-commits
https://github.com/agozillon updated https://github.com/llvm/llvm-project/pull/81510 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [OpenMP][MLIR] Extend explicit derived type member mapping support for OpenMP dialects lowering to LLVM-IR (PR #81510)

2024-02-22 Thread via llvm-branch-commits
https://github.com/agozillon updated https://github.com/llvm/llvm-project/pull/81510 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [OpenMP][MLIR] Add new partial_map and members_index arguments to omp.map_info operations to help support record type mapping (PR #81509)

2024-02-22 Thread via llvm-branch-commits
https://github.com/agozillon updated https://github.com/llvm/llvm-project/pull/81509 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [OpenMP][MLIR] Add new partial_map and members_index arguments to omp.map_info operations to help support record type mapping (PR #81509)

2024-02-22 Thread via llvm-branch-commits
https://github.com/agozillon updated https://github.com/llvm/llvm-project/pull/81509 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-22 Thread Tom Stellard via llvm-branch-commits
tstellar wrote: I'm OK with this kind of change if the AArch64 maintainers are on board. @AaronBallman Do you have a strong objection to this PR? https://github.com/llvm/llvm-project/pull/81857 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [llvm] release/18.x: Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (#82643) (PR #82688)

2024-02-22 Thread Tom Stellard via llvm-branch-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/82688 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] b9029ed - Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (#82643)

2024-02-22 Thread via llvm-branch-commits
Author: Thomas Preud'homme Date: 2024-02-22T21:08:58Z New Revision: b9029ed0053b93d94e0f133e6a44250f82bf0dc2 URL: https://github.com/llvm/llvm-project/commit/b9029ed0053b93d94e0f133e6a44250f82bf0dc2 DIFF: https://github.com/llvm/llvm-project/commit/b9029ed0053b93d94e0f133e6a44250f82bf0dc2.diff

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82718)

2024-02-22 Thread Brad Smith via llvm-branch-commits
brad0 wrote: > LGTM since this helps at least FreeBSD. Does OpenBSD want to try llvm binary > utilities? We're slowly moving in that direction with sparing use of objcopy and readelf in some places with a desire for more like ar, ranlib and strip.

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82718)

2024-02-22 Thread Fangrui Song via llvm-branch-commits
https://github.com/MaskRay approved this pull request. LGTM since this helps at least FreeBSD. Does OpenBSD want to try llvm binary utilities? https://github.com/llvm/llvm-project/pull/82718 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread Brad Smith via llvm-branch-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/82713 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82718)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities Author: None (llvmbot) Changes Backport 26d71d9ed56c4c23e6284dac7a9bdf603a5801f3 Requested by: @brad0 --- Full diff: https://github.com/llvm/llvm-project/pull/82718.diff 10 Files Affected: - (modified)

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82718)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @emaste What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/82718 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82718)

2024-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/82718 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82718)

2024-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/82718 Backport 26d71d9ed56c4c23e6284dac7a9bdf603a5801f3 Requested by: @brad0 >From 7b790b0ad947db820462799ac70722aa4a18a25f Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 22 Feb 2024 09:24:21 -0800 Subject:

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: Failed to cherry-pick: $commit_id` https://github.com/llvm/llvm-project/actions/runs/8013240633 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare)

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: Failed to cherry-pick: $commit_id` https://github.com/llvm/llvm-project/actions/runs/8013213107 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare)

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: Failed to cherry-pick: $commit_id` https://github.com/llvm/llvm-project/actions/runs/8013198408 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare)

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread Brad Smith via llvm-branch-commits
brad0 wrote: > Does `/cherry-pick $commit_id` work? I think it's the preferred way to > backport a commit. I tried. https://github.com/llvm/llvm-project/issues/82692 https://github.com/llvm/llvm-project/pull/82713 ___ llvm-branch-commits mailing

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread Fangrui Song via llvm-branch-commits
MaskRay wrote: Does `/cherry-pick $commit_id` work? I think it's the preferred way to backport a commit. https://github.com/llvm/llvm-project/pull/82713 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82693)

2024-02-22 Thread Brad Smith via llvm-branch-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/82693 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities Author: Brad Smith (brad0) Changes When a section has the SHF_COMPRESSED flag, -p/-x dump the compressed content by default. In GNU readelf, if --decompress/-z is specified, -p/-x will dump the decompressed content. This patch

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread Brad Smith via llvm-branch-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/82713 When a section has the SHF_COMPRESSED flag, -p/-x dump the compressed content by default. In GNU readelf, if --decompress/-z is specified, -p/-x will dump the decompressed content. This patch implements the option.

[llvm-branch-commits] [llvm] [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82713)

2024-02-22 Thread Brad Smith via llvm-branch-commits
https://github.com/brad0 milestoned https://github.com/llvm/llvm-project/pull/82713 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82693)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities Author: None (llvmbot) Changes Backport 26d71d9ed56c4c23e6284dac7a9bdf603a5801f3 Requested by: @brad0 --- Full diff: https://github.com/llvm/llvm-project/pull/82693.diff 10 Files Affected: - (modified)

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82693)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @emaste What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/82693 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82693)

2024-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/82693 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [llvm-readobj, ELF] Support --decompress/-z (#82594) (PR #82693)

2024-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/82693 Backport 26d71d9ed56c4c23e6284dac7a9bdf603a5801f3 Requested by: @brad0 >From 6ab419cea064195460c56a9e38e05fc25b8dc8c9 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 22 Feb 2024 09:24:21 -0800 Subject:

[llvm-branch-commits] [llvm] release/18.x: Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (#82643) (PR #82688)

2024-02-22 Thread Fangrui Song via llvm-branch-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/82688 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (#82643) (PR #82688)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-adt Author: None (llvmbot) Changes Backport 7f71fa909a10be182b82b9dfaf0fade6eb84796c Requested by: @RoboTux --- Full diff: https://github.com/llvm/llvm-project/pull/82688.diff 1 Files Affected: - (modified)

[llvm-branch-commits] [llvm] release/18.x: Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (#82643) (PR #82688)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @MaskRay What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/82688 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] release/18.x: Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (#82643) (PR #82688)

2024-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/82688 Backport 7f71fa909a10be182b82b9dfaf0fade6eb84796c Requested by: @RoboTux >From b9029ed0053b93d94e0f133e6a44250f82bf0dc2 Mon Sep 17 00:00:00 2001 From: Thomas Preud'homme Date: Thu, 22 Feb 2024 21:01:05 +

[llvm-branch-commits] [llvm] release/18.x: Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (#82643) (PR #82688)

2024-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/82688 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [scudo] Allow to resize allocation ring buffer (PR #82683)

2024-02-22 Thread Florian Mayer via llvm-branch-commits
https://github.com/fmayer edited https://github.com/llvm/llvm-project/pull/82683 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [scudo] Allow to resize allocation ring buffer (PR #82683)

2024-02-22 Thread Florian Mayer via llvm-branch-commits
https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/82683 >From af8afe08ee20a04b2ccb363cac66aa02cfaecd02 Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Thu, 22 Feb 2024 12:37:06 -0800 Subject: [PATCH] update message Created using spr 1.3.4 ---

[llvm-branch-commits] [scudo] Allow to resize allocation ring buffer (PR #82683)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Florian Mayer (fmayer) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/82683.diff 4 Files Affected: - (modified) compiler-rt/lib/scudo/standalone/combined.h (+34-10) - (modified)

[llvm-branch-commits] [scudo] Allow to resize allocation ring buffer (PR #82683)

2024-02-22 Thread Florian Mayer via llvm-branch-commits
https://github.com/fmayer created https://github.com/llvm/llvm-project/pull/82683 None ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-22 Thread Philipp Tomsich via llvm-branch-commits
ptomsich wrote: > > On a different note: the "+pauth" fix would be helpful in clang-18 as well, > > given that it brings the definition of "-march=armv8.3-a" in sync with the > > specification. > > OK, so sounds like the +pauth change is separate but included in this PR for > convenience.

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-22 Thread Tom Stellard via llvm-branch-commits
tstellar wrote: > On a different note: the "+pauth" fix would be helpful in clang-18 as well, > given that it brings the definition of "-march=armv8.3-a" in sync with the > specification. OK, so sounds like the +pauth change is separate but included in this PR for convenience.

[llvm-branch-commits] [llvm] release/18.x: [Loads] Fix crash in isSafeToLoadUnconditionally with scalable accessed type (#82650) (PR #82664)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: None (llvmbot) Changes Backport b0edc1c45284586fdb12edd666f95d99f5f62b43 Requested by: @OMaghiarIMG --- Full diff: https://github.com/llvm/llvm-project/pull/82664.diff 2 Files Affected: - (modified)

[llvm-branch-commits] [llvm] release/18.x: [Loads] Fix crash in isSafeToLoadUnconditionally with scalable accessed type (#82650) (PR #82664)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @lukel97 What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/82664 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] release/18.x: [Loads] Fix crash in isSafeToLoadUnconditionally with scalable accessed type (#82650) (PR #82664)

2024-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/82664 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [Loads] Fix crash in isSafeToLoadUnconditionally with scalable accessed type (#82650) (PR #82664)

2024-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/82664 Backport b0edc1c45284586fdb12edd666f95d99f5f62b43 Requested by: @OMaghiarIMG >From 5994086729d9c28d8ea4059871c39c022097dc6b Mon Sep 17 00:00:00 2001 From: Luke Lau Date: Fri, 23 Feb 2024 01:49:19 +0800

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paschalis Mpeis via llvm-branch-commits
paschalis-mpeis wrote: The benefits of having`getFRemInstrCost` in my view are the below: 1. frem is a special case anyway: It's an IR instruction that is not supported by all hw and targets have to specialize. Handling it in a dedicated switch case with a dedicated TTI function call, clearly

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Alexey Bataev via llvm-branch-commits
alexey-bataev wrote: > Changing `getArithmeticInstrCost` is just too dangerous. What if one opcode > needs TLI for a different reason? That should be fine, what's the dangerous in it? https://github.com/llvm/llvm-project/pull/82488 ___

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
paulwalker-arm wrote: Changing `getArithmeticInstrCost` is just too dangerous. What if one opcode needs TLI for a different reason? all of a sudden all existing callers are entered into the contract (FREM is guaranteed to be transformed into a math call) without ensuring that's actually the

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Alexey Bataev via llvm-branch-commits
alexey-bataev wrote: > Personally I'm happy with keeping this nuance outside of TTI but if we really > want this captured within TTI then I think it's time to break FREM into its > own cost function (i.e. implement getFRemInstrCost. That way > getArithmeticInstrCost can work as it does today

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
@@ -8362,9 +8362,12 @@ BoUpSLP::getEntryCost(const TreeEntry *E, ArrayRef VectorizedVals, unsigned OpIdx = isa(VL0) ? 0 : 1; TTI::OperandValueInfo Op1Info = getOperandInfo(E->getOperand(0)); TTI::OperandValueInfo Op2Info =

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
@@ -1031,6 +1032,22 @@ APInt llvm::possiblyDemandedEltsInMask(Value *Mask) { return DemandedElts; } +InstructionCost +llvm::getVecLibCallCost(const Instruction *I, const TargetTransformInfo *TTI, +const TargetLibraryInfo *TLI, VectorType *VecTy, +

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
@@ -869,6 +870,18 @@ TargetTransformInfo::getOperandInfo(const Value *V) { return {OpInfo, OpProps}; } +InstructionCost TargetTransformInfo::getVecLibCallCost( +const int OpCode, const TargetLibraryInfo *TLI, VectorType *VecTy, +TTI::TargetCostKind CostKind) { +

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
https://github.com/paulwalker-arm commented: I've review the patch from both side so most of the comment will be void if you opt for the new TTI hook. That advantage of the TTI hook is that because it is specific to FREM you can hardware things like numbers of operands, which should

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
@@ -410,6 +410,14 @@ bool maskIsAllOneOrUndef(Value *Mask); /// for each lane which may be active. APInt possiblyDemandedEltsInMask(Value *Mask); +/// Returns the cost of a call when a target has a vector library function for +/// the given \p VecTy, otherwise an invalid

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
@@ -1031,6 +1032,22 @@ APInt llvm::possiblyDemandedEltsInMask(Value *Mask) { return DemandedElts; } +InstructionCost +llvm::getVecLibCallCost(const Instruction *I, const TargetTransformInfo *TTI, +const TargetLibraryInfo *TLI, VectorType *VecTy, +

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
https://github.com/paulwalker-arm edited https://github.com/llvm/llvm-project/pull/82488 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Alexey Bataev via llvm-branch-commits
@@ -869,6 +870,18 @@ TargetTransformInfo::getOperandInfo(const Value *V) { return {OpInfo, OpProps}; } +InstructionCost TargetTransformInfo::getVecLibCallCost( +const int OpCode, const TargetLibraryInfo *TLI, VectorType *VecTy, +TTI::TargetCostKind CostKind) { +

[llvm-branch-commits] [clang] [llvm] [MC/DC][Coverage] Loosen the limit of NumConds from 6 (PR #82448)

2024-02-22 Thread NAKAMURA Takumi via llvm-branch-commits
https://github.com/chapuni commented: I know I still have a couple of arbitrary names. They come from my prototype. * `MCDCCoverageBuilder::cache` -- will be "NextIDs list" * `MCDCCoverageBuilder ::ccc(Expr, IDs)` -- just updates `cache`. I will try to dissolve them within a few days.

[llvm-branch-commits] [clang] [llvm] [MC/DC][Coverage] Loosen the limit of NumConds from 6 (PR #82448)

2024-02-22 Thread NAKAMURA Takumi via llvm-branch-commits
@@ -723,7 +737,15 @@ struct MCDCCoverageBuilder { if (I == CondIDs.end()) return -1; else - return I->second; + return I->second.ID; + } + + void ccc(const Expr *CondExpr, mcdc::ConditionIDs IDs) { +auto ID = getCondID(CondExpr); +if (ID < 0)

[llvm-branch-commits] [clang] [llvm] [MC/DC][Coverage] Loosen the limit of NumConds from 6 (PR #82448)

2024-02-22 Thread NAKAMURA Takumi via llvm-branch-commits
https://github.com/chapuni edited https://github.com/llvm/llvm-project/pull/82448 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] [MC/DC][Coverage] Loosen the limit of NumConds from 6 (PR #82448)

2024-02-22 Thread NAKAMURA Takumi via llvm-branch-commits
@@ -1979,6 +2069,9 @@ struct CounterCoverageMappingBuilder // Track RHS True/False Decision. const auto DecisionRHS = MCDCBuilder.back(); +MCDCBuilder.ccc(E->getLHS(), DecisionLHS); +MCDCBuilder.ccc(E->getRHS(), DecisionRHS); chapuni wrote: I

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
@@ -869,6 +870,18 @@ TargetTransformInfo::getOperandInfo(const Value *V) { return {OpInfo, OpProps}; } +InstructionCost TargetTransformInfo::getVecLibCallCost( +const int OpCode, const TargetLibraryInfo *TLI, VectorType *VecTy, +TTI::TargetCostKind CostKind) { +

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Alexey Bataev via llvm-branch-commits
@@ -869,6 +870,18 @@ TargetTransformInfo::getOperandInfo(const Value *V) { return {OpInfo, OpProps}; } +InstructionCost TargetTransformInfo::getVecLibCallCost( +const int OpCode, const TargetLibraryInfo *TLI, VectorType *VecTy, +TTI::TargetCostKind CostKind) { +

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paul Walker via llvm-branch-commits
@@ -869,6 +870,18 @@ TargetTransformInfo::getOperandInfo(const Value *V) { return {OpInfo, OpProps}; } +InstructionCost TargetTransformInfo::getVecLibCallCost( +const int OpCode, const TargetLibraryInfo *TLI, VectorType *VecTy, +TTI::TargetCostKind CostKind) { +

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Alexey Bataev via llvm-branch-commits
@@ -869,6 +870,18 @@ TargetTransformInfo::getOperandInfo(const Value *V) { return {OpInfo, OpProps}; } +InstructionCost TargetTransformInfo::getVecLibCallCost( +const int OpCode, const TargetLibraryInfo *TLI, VectorType *VecTy, +TTI::TargetCostKind CostKind) { +

[llvm-branch-commits] [clang] [Clang] Fixes to immediate-escalating functions (#82281) (PR #82609)

2024-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes * Consider that immediate escalating function can appear at global scope, fixing a crash * Lambda conversion to function pointer was sometimes not performed in an immediate function context when it

[llvm-branch-commits] [clang] [Clang] Fixes to immediate-escalating functions (#82281) (PR #82609)

2024-02-22 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/82609 * Consider that immediate escalating function can appear at global scope, fixing a crash * Lambda conversion to function pointer was sometimes not performed in an immediate function context when it should be.

[llvm-branch-commits] [clang] [Clang] Fixes to immediate-escalating functions (#82281) (PR #82609)

2024-02-22 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/82609 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn unresolved materializations into `IRRewrite`s (PR #81761)

2024-02-22 Thread Matthias Springer via llvm-branch-commits
https://github.com/matthias-springer updated https://github.com/llvm/llvm-project/pull/81761 >From 6d02f6d545fff81a41b7e40fa48f19c55483c77b Mon Sep 17 00:00:00 2001 From: Matthias Springer Date: Mon, 19 Feb 2024 10:29:29 + Subject: [PATCH] [WIP] UnresolvedMaterialization BEGIN_PUBLIC No

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn op creation into `IRRewrite` (PR #81759)

2024-02-22 Thread Matthias Springer via llvm-branch-commits
https://github.com/matthias-springer updated https://github.com/llvm/llvm-project/pull/81759 >From d15c439f166426a613ac0021a9101b774d544357 Mon Sep 17 00:00:00 2001 From: Matthias Springer Date: Fri, 16 Feb 2024 15:21:48 + Subject: [PATCH] [mlir][Transforms][NFC] Turn op creation into

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn op creation into `IRRewrite` (PR #81759)

2024-02-22 Thread Matthias Springer via llvm-branch-commits
@@ -2549,10 +2572,15 @@ LogicalResult OperationConverter::legalizeConvertedArgumentTypes( }); return liveUserIt == val.user_end() ? nullptr : *liveUserIt; }; - for (auto : rewriterImpl.rewrites) -if (auto *rewrite = dyn_cast(r.get())) - if

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paschalis Mpeis via llvm-branch-commits
@@ -8362,9 +8362,20 @@ BoUpSLP::getEntryCost(const TreeEntry *E, ArrayRef VectorizedVals, unsigned OpIdx = isa(VL0) ? 0 : 1; TTI::OperandValueInfo Op1Info = getOperandInfo(E->getOperand(0)); TTI::OperandValueInfo Op2Info =

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-22 Thread Philipp Tomsich via llvm-branch-commits
ptomsich wrote: On a different note: the "+pauth" fix would be helpful in clang-18 as well, given that it brings the definition of "-march=armv8.3-a" in sync with the specification. https://github.com/llvm/llvm-project/pull/81857 ___

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-22 Thread Philipp Tomsich via llvm-branch-commits
ptomsich wrote: > > Is this fixing a regression introduced in Clang 18? I'm wondering why the > > backport is needed in the first place, as this seems to be making > > potentially significant changes during the RC ("Make +pauth enabled in > > Armv8.3-a by default"). > > It is adding new CPU

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paschalis Mpeis via llvm-branch-commits
@@ -869,6 +870,18 @@ TargetTransformInfo::getOperandInfo(const Value *V) { return {OpInfo, OpProps}; } +InstructionCost TargetTransformInfo::getVecLibCallCost( +const int OpCode, const TargetLibraryInfo *TLI, VectorType *VecTy, +TTI::TargetCostKind CostKind) { +

[llvm-branch-commits] [llvm] [AArch64] SLP can vectorize frem (PR #82488)

2024-02-22 Thread Paschalis Mpeis via llvm-branch-commits
https://github.com/paschalis-mpeis updated https://github.com/llvm/llvm-project/pull/82488 >From 641aaf7c13d520bef52b092726f8346bfecb1c8d Mon Sep 17 00:00:00 2001 From: Paschalis Mpeis Date: Wed, 21 Feb 2024 11:53:00 + Subject: [PATCH 1/4] SLP cannot vectorize frem calls in AArch64. It

[llvm-branch-commits] [clang] [llvm] release/18.x: [AArch64] Backport Ampere1B support (#81297 , #81341, and #81744) (PR #81857)

2024-02-22 Thread David Green via llvm-branch-commits
davemgreen wrote: > Is this fixing a regression introduced in Clang 18? I'm wondering why the > backport is needed in the first place, as this seems to be making potentially > significant changes during the RC ("Make +pauth enabled in Armv8.3-a by > default"). It is adding new CPU support to