https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/96023
>From 03d5720d113ff3ce03694b27d376230d06d7693e Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 17 Jun 2024 21:39:08 -0300
Subject: [PATCH] [clang] Finish implementation of P0522
This finishes the
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
This finishes the clang implementation of P0522, getting rid of the fallback to
the old, pre-P0522 rules.
Before this patch, when partial ordering template template
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/96023
This finishes the clang implementation of P0522, getting rid of the fallback to
the old, pre-P0522 rules.
Before this patch, when partial ordering template template parameters, we would
perform, in order:
*
@@ -0,0 +1,10 @@
+// RUN: %clang_cc1 -triple arm64-apple-ios -fptrauth-calls
-fptrauth-intrinsics -emit-llvm %s -o - | FileCheck %s
ahatanak wrote:
We can probably consolidate some of the tests. I'll look into it later.
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 %s -triple arm64e-apple-ios13 -fptrauth-calls
-fptrauth-intrinsics -disable-llvm-passes -emit-llvm -o- | FileCheck %s
+// RUN: %clang_cc1 -xc++ %s -triple arm64e-apple-ios13 -fptrauth-calls
-fptrauth-intrinsics -disable-llvm-passes
@@ -0,0 +1,5 @@
+// RUN: %clang_cc1 -triple arm64e-apple-ios -fptrauth-calls %s -verify
-emit-llvm -o -
+
+void f(void);
+
+int *pf = (int *) + 1; // expected-error{{cannot compile this static
initializer yet}}
ahatanak wrote:
As commented in the test case,
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -triple arm64-apple-ios-emit-llvm %s
-o - | FileCheck %s --check-prefixes=ALL,OFF
ahatanak wrote:
I've added RUN lines for `aarch64-linux-gnu`.
https://github.com/llvm/llvm-project/pull/93906
@@ -0,0 +1,9 @@
+// RUN: %clang -target arm64-apple-macosx -fptrauth-calls -c %s -### 2>&1 |
FileCheck %s --check-prefix PTRAUTH_CALLS
ahatanak wrote:
I removed the file.
https://github.com/llvm/llvm-project/pull/93906
@@ -61,3 +79,28 @@ CodeGen::getConstantSignedPointer(CodeGenModule ,
llvm::Constant *Pointer,
return CGM.getConstantSignedPointer(Pointer, Key, StorageAddress,
OtherDiscriminator);
}
+
+/// If applicable, sign a given constant function
@@ -61,3 +79,28 @@ CodeGen::getConstantSignedPointer(CodeGenModule ,
llvm::Constant *Pointer,
return CGM.getConstantSignedPointer(Pointer, Key, StorageAddress,
OtherDiscriminator);
}
+
+/// If applicable, sign a given constant function
@@ -128,12 +136,12 @@ class CGCallee {
static CGCallee forDirect(llvm::Constant *functionPtr,
const CGCalleeInfo = CGCalleeInfo())
{
-return CGCallee(abstractInfo, functionPtr);
+return CGCallee(abstractInfo, functionPtr,
@@ -104,10 +109,13 @@ class CGCallee {
/// Construct a callee. Call this constructor directly when this
/// isn't a direct call.
- CGCallee(const CGCalleeInfo , llvm::Value *functionPtr)
+ CGCallee(
+ const CGCalleeInfo , llvm::Value *functionPtr,
+ const
@@ -351,6 +351,9 @@ def err_drv_omp_host_ir_file_not_found : Error<
"target regions but cannot be found">;
def err_drv_omp_host_target_not_supported : Error<
"target '%0' is not a supported OpenMP host target">;
+def err_drv_ptrauth_not_supported : Error<
+ "target '%0'
@@ -657,22 +657,22 @@
! V9: prefetcha [%i1+3968] %asi, #one_read! encoding:
[0xc3,0xee,0x6f,0x80]
prefetcha [ %i1 + 0xf80 ] %asi, #one_read
koachan wrote:
This is also suffering from the same issue as the membars, IAS doesn't seem to
@@ -11,7 +11,7 @@
! V9: unknown membar tag
membar #BadTag
-! V8: instruction requires a CPU feature not currently enabled
+! V8: unexpected token
! V9: invalid membar mask number
membar -127
koachan wrote:
llvmbot wrote:
@llvm/pr-subscribers-mc
Author: Koakuma (koachan)
Changes
This enables `ParseForAllFeatures` to report the correct error message
when trying to assemble instructions not available in V8 mode.
---
Full diff: https://github.com/llvm/llvm-project/pull/96021.diff
3 Files
llvmbot wrote:
@llvm/pr-subscribers-backend-sparc
Author: Koakuma (koachan)
Changes
This changes the ASI tag matching at `parseASITag` to use a similar
implementation to `parsePrefetchTag`. This introduces a slight regression
to error messages, but is needed so we can enable
https://github.com/koachan created
https://github.com/llvm/llvm-project/pull/96021
This enables `ParseForAllFeatures` to report the correct error message
when trying to assemble instructions not available in V8 mode.
___
llvm-branch-commits mailing
https://github.com/koachan created
https://github.com/llvm/llvm-project/pull/96020
This changes the ASI tag matching at `parseASITag` to use a similar
implementation to `parsePrefetchTag`. This introduces a slight regression
to error messages, but is needed so we can enable
https://github.com/aaupov commented:
Looks very good, but please address some minor issues.
https://github.com/llvm/llvm-project/pull/95821
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
@@ -383,6 +381,30 @@ Error YAMLProfileReader::readProfile(BinaryContext ) {
matchProfileToFunction(YamlBF, Function);
}
+ // Uses the strict hash of profiled and binary functions to match functions
+ // that are not matched by name or common name.
+
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/95821
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -383,6 +381,30 @@ Error YAMLProfileReader::readProfile(BinaryContext ) {
matchProfileToFunction(YamlBF, Function);
}
+ // Uses the strict hash of profiled and binary functions to match functions
+ // that are not matched by name or common name.
+
@@ -383,6 +381,30 @@ Error YAMLProfileReader::readProfile(BinaryContext ) {
matchProfileToFunction(YamlBF, Function);
}
+ // Uses the strict hash of profiled and binary functions to match functions
aaupov wrote:
Let's put this under `if
@@ -420,6 +442,7 @@ Error YAMLProfileReader::readProfile(BinaryContext ) {
errs() << "BOLT-WARNING: profile ignored for function " << YamlBF.Name
<< '\n';
+
aaupov wrote:
nit: please drop
https://github.com/llvm/llvm-project/pull/95821
@@ -0,0 +1,67 @@
+## Test YAMLProfileReader support for pass-through blocks in non-matching
edges:
+## match the profile edge A -> C to the CFG with blocks A -> B -> C.
+
+# REQUIRES: system-linux
+# RUN: split-file %s %t
+# RUN: llvm-mc -filetype=obj -triple
@@ -2126,14 +2219,16 @@ static ExprResult PointerAuthSignGenericData(Sema ,
CallExpr *Call) {
}
static ExprResult PointerAuthSignOrAuth(Sema , CallExpr *Call,
-PointerAuthOpKind OpKind) {
+
@@ -1856,6 +1856,12 @@ class ConstantLValueEmitter : public
ConstStmtVisitor
ahmedbougacha wrote:
The more interesting question is the usage of Constant; I think we can safely
assume the integer component is always going to be a ConstantInt (because it's
@@ -938,6 +938,11 @@ class CodeGenModule : public CodeGenTypeCache {
// Return the function body address of the given function.
llvm::Constant *GetFunctionStart(const ValueDecl *Decl);
+ llvm::Constant *getConstantSignedPointer(llvm::Constant *Pointer,
+
@@ -2030,8 +2030,25 @@ bool Sema::checkConstantPointerAuthKey(Expr *Arg,
unsigned ) {
return false;
}
+static std::pair
+findConstantBaseAndOffset(Sema , Expr *E) {
+ // Must evaluate as a pointer.
+ Expr::EvalResult Result;
+ if (!E->EvaluateAsRValue(Result, S.Context)
@@ -2074,16 +2091,91 @@ static bool checkPointerAuthValue(Sema , Expr *,
if (convertArgumentToType(S, Arg, ExpectedTy))
return true;
- // Warn about null pointers for non-generic sign and auth operations.
- if ((OpKind == PAO_Sign || OpKind == PAO_Auth) &&
-
@@ -2074,16 +2091,91 @@ static bool checkPointerAuthValue(Sema , Expr *,
if (convertArgumentToType(S, Arg, ExpectedTy))
return true;
- // Warn about null pointers for non-generic sign and auth operations.
- if ((OpKind == PAO_Sign || OpKind == PAO_Auth) &&
-
@@ -0,0 +1,21 @@
+// RUN: %clang_cc1 -triple arm64-apple-ios -fptrauth-intrinsics -emit-llvm %s
-o - | FileCheck %s
+// RUN: %clang_cc1 -triple aarch64-elf -fptrauth-intrinsics -emit-llvm %s
-o - | FileCheck %s
+
+extern int external;
+
+// CHECK: @ptr1 = global ptr
https://github.com/ahmedbougacha updated
https://github.com/llvm/llvm-project/pull/93904
>From 20bbad26fa9f068910baf50b5abb60a0f4557564 Mon Sep 17 00:00:00 2001
From: Ahmed Bougacha
Date: Thu, 30 May 2024 17:33:04 -0700
Subject: [PATCH 1/5] [clang] Define ptrauth_sign_constant builtin.
This
https://github.com/ahmedbougacha updated
https://github.com/llvm/llvm-project/pull/93904
>From 20bbad26fa9f068910baf50b5abb60a0f4557564 Mon Sep 17 00:00:00 2001
From: Ahmed Bougacha
Date: Thu, 30 May 2024 17:33:04 -0700
Subject: [PATCH 1/4] [clang] Define ptrauth_sign_constant builtin.
This
Author: Tom Stellard
Date: 2024-06-18T14:58:02-07:00
New Revision: 13a0c13519b356c004127cf23c79b57cd33fc969
URL:
https://github.com/llvm/llvm-project/commit/13a0c13519b356c004127cf23c79b57cd33fc969
DIFF:
https://github.com/llvm/llvm-project/commit/13a0c13519b356c004127cf23c79b57cd33fc969.diff
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95821
>From 92212c96ea169d26ac10bf8d750539bc5dd72c49 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Mon, 17 Jun 2024 15:39:02 -0700
Subject: [PATCH 1/6] spr amend
Created using spr 1.3.4
---
@@ -1735,8 +1737,11 @@ defm : SIBufferAtomicPat<"SIbuffer_atomic_dec", i64,
"BUFFER_ATOMIC_DEC_X2">;
let OtherPredicates = [HasAtomicCSubNoRtnInsts] in
defm : SIBufferAtomicPat<"SIbuffer_atomic_csub", i32, "BUFFER_ATOMIC_CSUB",
["noret"]>;
-let SubtargetPredicate =
@@ -1735,8 +1737,11 @@ defm : SIBufferAtomicPat<"SIbuffer_atomic_dec", i64,
"BUFFER_ATOMIC_DEC_X2">;
let OtherPredicates = [HasAtomicCSubNoRtnInsts] in
defm : SIBufferAtomicPat<"SIbuffer_atomic_csub", i32, "BUFFER_ATOMIC_CSUB",
["noret"]>;
-let SubtargetPredicate =
@@ -1735,8 +1737,11 @@ defm : SIBufferAtomicPat<"SIbuffer_atomic_dec", i64,
"BUFFER_ATOMIC_DEC_X2">;
let OtherPredicates = [HasAtomicCSubNoRtnInsts] in
defm : SIBufferAtomicPat<"SIbuffer_atomic_csub", i32, "BUFFER_ATOMIC_CSUB",
["noret"]>;
-let SubtargetPredicate =
@@ -743,6 +743,12 @@ def FeatureAtomicGlobalPkAddBF16Inst :
SubtargetFeature<"atomic-global-pk-add-bf
[FeatureFlatGlobalInsts]
>;
+def FeatureAtomicBufferPkAddBF16Inst :
SubtargetFeature<"atomic-buffer-pk-add-bf16-inst",
rampitec wrote:
I believe it is
@@ -1699,7 +1709,7 @@ multiclass SIBufferAtomicPat_Common RtnModes = ["ret", "noret"]> {
- let SubtargetPredicate = HasUnrestrictedSOffset in {
+ let OtherPredicates = [HasUnrestrictedSOffset] in {
arsenm wrote:
SubtargetPredicate is just one thing, and
https://github.com/shiltian approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/95592
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1699,7 +1709,7 @@ multiclass SIBufferAtomicPat_Common RtnModes = ["ret", "noret"]> {
- let SubtargetPredicate = HasUnrestrictedSOffset in {
+ let OtherPredicates = [HasUnrestrictedSOffset] in {
shiltian wrote:
A side question, what is the difference
ilya-biryukov wrote:
I am happy to take a look, but will run out of time for it today. I will
definitely do it tomorrow, though.
https://github.com/llvm/llvm-project/pull/92511
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
@@ -76,12 +81,71 @@ class zoned_time {
_LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name)
requires(requires { __traits::locate_zone(string_view{}); } &&
- // constructible_from
- // would create a dependency on itself. Instead depend
@@ -76,12 +81,71 @@ class zoned_time {
_LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name)
requires(requires { __traits::locate_zone(string_view{}); } &&
- // constructible_from
- // would create a dependency on itself. Instead depend
@@ -76,12 +81,71 @@ class zoned_time {
_LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name)
requires(requires { __traits::locate_zone(string_view{}); } &&
- // constructible_from
- // would create a dependency on itself. Instead depend
@@ -0,0 +1,105 @@
+//===--===/
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,105 @@
+//===--===/
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/95010
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -76,12 +81,71 @@ class zoned_time {
_LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name)
requires(requires { __traits::locate_zone(string_view{}); } &&
- // constructible_from
- // would create a dependency on itself. Instead depend
https://github.com/ldionne requested changes to this pull request.
This generally LGTM but the constraints seem wrong, so I'd like to see again
once that is figured out.
https://github.com/llvm/llvm-project/pull/95010
___
llvm-branch-commits mailing
@@ -76,12 +81,71 @@ class zoned_time {
_LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name)
requires(requires { __traits::locate_zone(string_view{}); } &&
- // constructible_from
- // would create a dependency on itself. Instead depend
https://github.com/tmatheson-arm edited
https://github.com/llvm/llvm-project/pull/92882
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/95930
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
Annoyingly gfx90a/940 support this for global/flat but not buffer.
---
Full diff: https://github.com/llvm/llvm-project/pull/95930.diff
5 Files Affected:
- (modified)
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/95930?utm_source=stack-comment-downstack-mergeability-warning;
>
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/95930
Annoyingly gfx90a/940 support this for global/flat but not buffer.
>From 3bf1ef74e41889bfc70f8795e0fadb6031122286 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Tue, 18 Jun 2024 15:48:20 +0200
Subject:
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/95396
>From 62be4ae64075ec326ed81e0905f3eb3979ad Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Mon, 10 Jun 2024 19:48:13 +0200
Subject: [PATCH] AMDGPU: Remove ds atomic fadd intrinsics
These have been
Author: Balazs Benics
Date: 2024-06-18T14:50:00+02:00
New Revision: bbcee744465c72b8000321defd85ed3daa290502
URL:
https://github.com/llvm/llvm-project/commit/bbcee744465c72b8000321defd85ed3daa290502
DIFF:
https://github.com/llvm/llvm-project/commit/bbcee744465c72b8000321defd85ed3daa290502.diff
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/95129
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/95129
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
nikic wrote:
@tstellar Per
https://github.com/llvm/llvm-project/issues/95454#issuecomment-2166748656 this
is not an LLVM 18 regression, so I'm not sure it counts as critical. The fix
does look safe though.
https://github.com/llvm/llvm-project/pull/95463
steakhal wrote:
Ah, it mixed the messages... Here it is:
- Removed unused `NumZ3QueriesDoneInEqClass`
- Added a new `crosscheck-with-z3-eqclass-timeout-threshold` config option.
- Removed misleading `// unsat` comment on return statement.
- Removed unnecessary `// sat` comment on return
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/95129
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/95129
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/95592
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/95590
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-bolt
Author: shaw young (shawbyoung)
Changes
Matching functions based on edit
distance.
Test Plan: tbd
---
Full diff: https://github.com/llvm/llvm-project/pull/95884.diff
1 Files Affected:
- (modified) bolt/lib/Profile/YAMLProfileReader.cpp (+29)
https://github.com/shawbyoung created
https://github.com/llvm/llvm-project/pull/95884
Matching functions based on edit
distance.
Test Plan: tbd
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
71 matches
Mail list logo
