[llvm-branch-commits] [compiler-rt] release/21.x: [rtsan] Add versioned pthread_cond interceptors (#155970) (PR #156196)

2025-09-04 Thread Chris Apple via llvm-branch-commits
cjappl wrote: Closing - the original reporter has a viable workaround and is OK waiting until 22. https://github.com/llvm/llvm-project/pull/156196 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[llvm-branch-commits] [compiler-rt] release/21.x: [rtsan] Add versioned pthread_cond interceptors (#155970) (PR #156196)

2025-09-04 Thread Chris Apple via llvm-branch-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/156196 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] release/21.x: [rtsan] Add versioned pthread_cond interceptors (#155970) (PR #156196)

2025-09-03 Thread Chris Apple via llvm-branch-commits
cjappl wrote: Sounds good, and totally understood. Thanks for helping us understand the general process and precedent @tru We have reached out to the original bug reporter and are going to ask if some proposed workarounds will service until LLVM 22. I will ping you on here when I have an ide

[llvm-branch-commits] [compiler-rt] release/21.x: [rtsan] Add versioned pthread_cond interceptors (#155970) (PR #156196)

2025-09-03 Thread Chris Apple via llvm-branch-commits
cjappl wrote: > Hm - is this really a regression? It seems to be a new feature to me? Hi @tru, Not a regression in LLVM 21, but a crashing bug that was reported by a user here: https://github.com/llvm/llvm-project/issues/146120 We know that it is actively blocking their use of rtsan, so it wo

[llvm-branch-commits] [compiler-rt] release/21.x: [rtsan] Add versioned pthread_cond interceptors (#155970) (PR #156196)

2025-08-30 Thread Chris Apple via llvm-branch-commits
cjappl wrote: @fmayer adding you as a reviewer here for visibility, this is our first time porting something to the release branch and want to make sure we don't mess something up https://github.com/llvm/llvm-project/pull/156196 ___ llvm-branch-comm

[llvm-branch-commits] [compiler-rt] [RTSan] Cherry pick rtsan osspinlock fix to release/20.x (PR #137353)

2025-04-25 Thread Chris Apple via llvm-branch-commits
https://github.com/cjappl approved this pull request. https://github.com/llvm/llvm-project/pull/137353 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [nfc][tsan] Eliminate a few macros (PR #114931)

2024-12-27 Thread Chris Apple via llvm-branch-commits
https://github.com/cjappl approved this pull request. https://github.com/llvm/llvm-project/pull/114931 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port MachineSink to NPM (PR #115434)

2024-11-08 Thread Chris Apple via llvm-branch-commits
cjappl wrote: (sorry I don't know anything about this part of the codebase, so I am removing myself from the reviewers) https://github.com/llvm/llvm-project/pull/115434 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://l

[llvm-branch-commits] [compiler-rt] [TySan] Improved compatability for tests (PR #96507)

2024-10-23 Thread Chris Apple via llvm-branch-commits
@@ -4,6 +4,7 @@ // https://github.com/llvm/llvm-project/issues/47137 #include #include +#include cjappl wrote: Cool, thanks for the confirmation, resolving this comment https://github.com/llvm/llvm-project/pull/96507 ___

[llvm-branch-commits] [compiler-rt] [TySan] Improved compatability for tests (PR #96507)

2024-10-22 Thread Chris Apple via llvm-branch-commits
@@ -4,6 +4,7 @@ // https://github.com/llvm/llvm-project/issues/47137 #include #include +#include cjappl wrote: This line seems unrelated to the other changes, any reason for it? https://github.com/llvm/llvm-project/pull/96507 __

[llvm-branch-commits] [compiler-rt] [TySan] Improved compatability for tests (PR #96507)

2024-10-22 Thread Chris Apple via llvm-branch-commits
https://github.com/cjappl commented: This seems reasonable enough to me, I'm far from a tysan expert, but I requested review for you. 👍 https://github.com/llvm/llvm-project/pull/96507 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llv

[llvm-branch-commits] [compiler-rt] [TySan] Improved compatability for tests (PR #96507)

2024-10-22 Thread Chris Apple via llvm-branch-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/96507 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [compiler-rt] [rtsan] Revert openat interceptor that breaks fortify-source builds (PR #100876)

2024-07-27 Thread Chris Apple via llvm-branch-commits
cjappl wrote: Cc @davidtrevelyan so he is in the know https://github.com/llvm/llvm-project/pull/100876 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [compiler-rt] [rtsan] Revert openat interceptor that breaks fortify-source builds (PR #100876)

2024-07-27 Thread Chris Apple via llvm-branch-commits
cjappl wrote: Approved from the rtsan team (we don't have official access, so this comment is our thumbs up) 👍 https://github.com/llvm/llvm-project/pull/100876 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.