[llvm-branch-commits] [libcxx] [lldb] release/21.x: [libc++] Ensure that we restore invariants in basic_filebuf::overflow (#147389) (PR #155712)

2025-09-03 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: Actually the problem is that there is a pipeline wide timeout of 2 hours. This is reasonable most of the time but sometimes our AArch64 builds are taking > 2h. I will address this on our side. Could that be due to a test taking ages, maybe, but probably not given we've ha

[llvm-branch-commits] [llvm] [llvm][release] Correct formatting field in release message (PR #155380)

2025-08-26 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/155380 Extra } needed removing. Cherry-picked to 21.x from 6a81dac65c1c5ee891d0ee8530bd73a63c5fa204. For #153154. >From f01726bfef387bfa977a7038fe2e2b6e3881c631 Mon Sep 17 00:00:00 2001 From: David Spickett Da

[llvm-branch-commits] [llvm] [CI] Setup generate_report to describe ninja failures (PR #152621)

2025-08-08 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: > especially given we run ninja with -k 0. To explain to future readers / current reviewers, add: "-k 0 builds as much as possible until everything has completed or failed, rather than stopping after 1 command fails". At least that's my understanding of it. This gets me i

[llvm-branch-commits] [llvm] [CI] Setup generate_report to describe ninja failures (PR #152621)

2025-08-08 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. I have trouble keeping all the combinations of build and test state in my head, but I think you've got good test coverage anyway and we're bound to find corner cases in practice. So this LGTM. Thanks for working on this, it's so muc

[llvm-branch-commits] [CI] Setup generate_report to describe ninja failures (PR #152621)

2025-08-08 Thread David Spickett via llvm-branch-commits
@@ -246,6 +288,58 @@ def test_no_failures_build_failed(self): ), ) +def test_no_failures_build_failed_ninja_log(self): +self.assertEqual( +generate_test_report_lib.generate_report( +"Foo", +1, +

[llvm-branch-commits] [CI] Setup generate_report to describe ninja failures (PR #152621)

2025-08-08 Thread David Spickett via llvm-branch-commits
@@ -246,6 +288,58 @@ def test_no_failures_build_failed(self): ), ) +def test_no_failures_build_failed_ninja_log(self): +self.assertEqual( +generate_test_report_lib.generate_report( +"Foo", +1, +

[llvm-branch-commits] [llvm] [llvm][cmake] Turn runtime in PROJECTS warnings into FATAL_ERROR (PR #152302)

2025-08-07 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett demilestoned https://github.com/llvm/llvm-project/pull/152302 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CI] Refactor monolithic-* scripts to use common utils.sh (PR #152199)

2025-08-06 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/152199 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [llvm] [llvm][cmake] Turn runtime in PROJECTS warnings into FATAL_ERROR (PR #152302)

2025-08-06 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: > but I think we should make sure there is a release note for this as well Done, and updated the cmake docs page. https://github.com/llvm/llvm-project/pull/152302 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm

[llvm-branch-commits] [llvm] [llvm][cmake] Turn runtime in PROJECTS warnings into FATAL_ERROR (PR #152302)

2025-08-06 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/152302 >From afc78ab30f7ec81b7163fb4c3928cb08bd902766 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 6 Aug 2025 12:35:05 + Subject: [PATCH 1/2] [llvm][cmake] Turn runtime in PROJECTS warnings into

[llvm-branch-commits] [llvm] [llvm][cmake] Turn runtime in PROJECTS warnings into FATAL_ERROR (PR #152302)

2025-08-06 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/152302 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][cmake] Turn runtime in PROJECTS warnings into FATAL_ERROR (PR #152302)

2025-08-06 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: The alternative is to bump 21 to 22 in the messages on the 21.x branch, and turn them into errors on main instead. https://github.com/llvm/llvm-project/pull/152302 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llv

[llvm-branch-commits] [llvm] [llvm][cmake] Turn runtime in PROJECTS warnings into FATAL_ERROR (PR #152302)

2025-08-06 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/152302 As promised by the current warning message: CMake Warning at CMakeLists.txt:209 (message): Using LLVM_ENABLE_PROJECTS=openmp is deprecated now, and will become a fatal error in the LLVM 21 release. Ple

[llvm-branch-commits] [llvm] [llvm][cmake] Turn runtime in PROJECTS warnings into FATAL_ERROR (PR #152302)

2025-08-06 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/152302 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [CI] Refactor monolithic-* scripts to use common utils.sh (PR #152199)

2025-08-06 Thread David Spickett via llvm-branch-commits
@@ -13,50 +13,15 @@ # run only the relevant tests. # -set -ex -set -o pipefail +source ./utils.sh -MONOREPO_ROOT="${MONOREPO_ROOT:="$(git rev-parse --show-toplevel)"}" -BUILD_DIR="${BUILD_DIR:=${MONOREPO_ROOT}/build}" INSTALL_DIR="${BUILD_DIR}/install" -rm -rf "${BUILD_DIR}

[llvm-branch-commits] [CI] Refactor monolithic-* scripts to use common utils.sh (PR #152199)

2025-08-06 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/152199 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [CI] Refactor monolithic-* scripts to use common utils.sh (PR #152199)

2025-08-06 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett commented: Agree with the changes overall but there are problems in the CI runs to deal with. Unless they are because this is part of a stack of PRs? https://github.com/llvm/llvm-project/pull/152199 ___ llvm-branch-com

[llvm-branch-commits] [CI] Move platform specific test report titles to python (PR #152198)

2025-08-06 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. Nice improvement, LGTM. https://github.com/llvm/llvm-project/pull/152198 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[llvm-branch-commits] [lldb] [llvm] Backport Wasm Debugging changes to the LLVM 21.x Release (PR #151559)

2025-08-05 Thread David Spickett via llvm-branch-commits
@@ -326,6 +326,8 @@ Changes to LLDB RISC-V code with `disassemble`'s `--byte` option. * LLDB added native support for the Model Context Protocol (MCP). An MCP server can be started with the `protocol-server start MCP` command. +* LLDB can now set breakpoints, show backtrac

[llvm-branch-commits] [lldb] [llvm] Backport Wasm Debugging changes to the LLVM 21.x Release (PR #151559)

2025-08-01 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: I reviewed a lot of the changes on main but was not involved in writing them or the work that they are being written for (Swift compiled to WASM, I believe). The release note is the best place to start to understand it: > * LLDB can now set breakpoints, show backtraces, and

[llvm-branch-commits] [lldb] release/21.x: [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (#145033) (PR #151111)

2025-07-31 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: Release note is https://github.com/llvm/llvm-project/pull/151548. https://github.com/llvm/llvm-project/pull/15 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[llvm-branch-commits] [llvm] [llvm][docs] Add release note for LLDB MTE changes (PR #151548)

2025-07-31 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/151548 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][docs] Add release note for LLDB MTE changes (PR #151548)

2025-07-31 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/151548 Goes with https://github.com/llvm/llvm-project/pull/15. >From 7cc104eb0363522f2be1d5be0697498c697c61b0 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 31 Jul 2025 16:56:39 +0100 Subject: [PAT

[llvm-branch-commits] [lldb] release/21.x: [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (#145033) (PR #151111)

2025-07-29 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: My pitch for backporting this is that it was intended to make this branch but missed it by a couple of weeks. It displays a new feature bit in a Linux control register, if the hardware has FEAT_MTE_STORE_ONLY. So the impact of a bug here is very low, and only visible on t

[llvm-branch-commits] [lldb] release/21.x: [lldb] [Windows] Silence format string warnings (#150886) (PR #150919)

2025-07-28 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. LGTM on the grounds that in theory, this is not just fixing a warning, it could lead to incorrect output in the errors. Though in practice I expect the pointer to be an arbitrary value and it wouldn't be that important. That combined

[llvm-branch-commits] [lldb] release/21.x: [lldb] Allow building using Mingw-w64 on Windows. (#150398) (PR #150591)

2025-07-28 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: > Can we get a review and it approved? Sorry, forgot to actually review. Done now. https://github.com/llvm/llvm-project/pull/150591 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi

[llvm-branch-commits] [lldb] release/21.x: [lldb] Allow building using Mingw-w64 on Windows. (#150398) (PR #150591)

2025-07-28 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/150591 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lldb] [llvm] release/21.x: [LLDB] Switch to using DIL as default implementation for 'frame var' (#149117) (PR #150600)

2025-07-28 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: The cherry pick used the title of the follow up that just adjusted the phrasing of the release note. 99.9% of the changes are as the title now says. There is some risk with this change but there is an easy fallback which is noted in the release note. @JDevlieghere has othe

[llvm-branch-commits] [lldb] [llvm] release/21.x: [LLDB] Switch to using DIL as default implementation for 'frame var' (#149117) (PR #150600)

2025-07-28 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/150600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lldb] release/21.x: [lldb] Allow building using Mingw-w64 on Windows. (#150398) (PR #150591)

2025-07-25 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: This change fixes an issue building in specific Mingw configurations. All it does is make some uses more explicit, should not, and has not been reported to, impact any other configuration. https://github.com/llvm/llvm-project/pull/150591 ___

[llvm-branch-commits] [llvm] [lldb] Add a release note for MCP support (PR #149143)

2025-07-17 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/149143 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [lldb] Add a release note for MCP support (PR #149143)

2025-07-17 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/149143 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [lldb] Add a release note for MCP support (PR #149143)

2025-07-17 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/149143 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lldb] release/21.x: [lldb] Document MCP tools & resources (#148708) (PR #149146)

2025-07-17 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: > Sounds good to me `` > let's hear from @DavidSpickett who suggested the backport. It's true the vast majority of people will go to the website no matter what, but I consider documentation part of a feature and this completes the MCP feature for 21 so I'd like it to be

[llvm-branch-commits] [llvm] [lldb] Add a release note for MCP support (PR #149143)

2025-07-17 Thread David Spickett via llvm-branch-commits
@@ -315,6 +315,8 @@ Changes to LLDB nothing at all * Changed the format of opcode bytes to match llvm-objdump when disassembling RISC-V code with `disassemble`'s `--byte` option. +* LLDB added native support for the Model Context Protocol (MCP). An MCP Dav

[llvm-branch-commits] [llvm] [lldb] Add a release note for MCP support (PR #149143)

2025-07-17 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. LGTM Context for the release managers is that the MCP support is already in the 21 branch, and there is a backport request for the documentation also opened. https://github.com/llvm/llvm-project/pull/149143 __

[llvm-branch-commits] [llvm] [lldb] Add a release note for MCP support (PR #149143)

2025-07-17 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: Not sure that this has to have the 21 milestone but I added it anyway to be safe. https://github.com/llvm/llvm-project/pull/149143 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-

[llvm-branch-commits] [CI] Remove Style from generate_test_report_lib (PR #147791)

2025-07-10 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/147791 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [clang] [clan-reply] Backport PTU error recovery to 20.x (PR #143893)

2025-06-12 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/143893 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [clang][Interpreter] Disable part of lambda test on Windows (PR #143851)

2025-06-12 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/143851 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [clang][Interpreter] Disable part of lambda test on Windows (PR #143851)

2025-06-12 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: Closing this in favour of https://github.com/llvm/llvm-project/pull/143893, where I am able to address the reviewer feedback. https://github.com/llvm/llvm-project/pull/143851 ___ llvm-branch-commits mailing list llvm-branch-commit

[llvm-branch-commits] [clang] release/20.x: [clang][Interpreter] Disable part of lambda test on Windows (PR #143851)

2025-06-12 Thread David Spickett via llvm-branch-commits
@@ -1,7 +1,10 @@ // REQUIRES: host-supports-jit // UNSUPPORTED: system-aix // RUN: cat %s | clang-repl | FileCheck %s -// RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s +// At -O2, somehow "x = 42" appears first when piped into FileCheck, +// see https://github.com/llvm/llvm-

[llvm-branch-commits] [clang] [clan-reply] Backport PTU error recovery to 20.x (PR #143893)

2025-06-12 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/143893 This cherry-picks 3b4c51bb3243a02526313c51207a674139b67a00 and beffd1509af7b12eeab0d5ae85b2f8322e039287 to 20.x. Which are: [clang-repl] Fix error recovery while PTU cleanup (#127467) [clang][Interpreter

[llvm-branch-commits] [clang] [clan-reply] Backport PTU error recovery to 20.x (PR #143893)

2025-06-12 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/143893 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [clang][Interpreter] Disable part of lambda test on Windows (PR #143851)

2025-06-12 Thread David Spickett via llvm-branch-commits
@@ -1,7 +1,10 @@ // REQUIRES: host-supports-jit // UNSUPPORTED: system-aix // RUN: cat %s | clang-repl | FileCheck %s -// RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s +// At -O2, somehow "x = 42" appears first when piped into FileCheck, +// see https://github.com/llvm/llvm-

[llvm-branch-commits] [clang] release/20.x: [clang-repl] Fix error recovery while PTU cleanup (#127467) (PR #142445)

2025-06-12 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/pull/143851 has both. https://github.com/llvm/llvm-project/pull/142445 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llv

[llvm-branch-commits] [llvm] [CI] Cleanup buildkite test report script (PR #143480)

2025-06-10 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/143480 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [CI] Use Github Native Groups in monolithic-* scripts (PR #143481)

2025-06-10 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. LGTM Looking forward to the other things we can do once there is only GitHub to think about. https://github.com/llvm/llvm-project/pull/143481 ___ llvm-branch-commits mailing list llvm-branc

[llvm-branch-commits] [CI] Use LLVM_ENABLE_RUNTIMES for runtimes builds on Linux (PR #142694)

2025-06-04 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. CMake once with the runtimes enabled. Modify the test parameters each time. Looks good to me. https://github.com/llvm/llvm-project/pull/142694 ___ llvm-branch-commits mailing list llvm-branc

[llvm-branch-commits] [CI] Explicitly compute needed runtime targets (PR #142695)

2025-06-04 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/142695 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [CI] Explicitly compute needed runtime targets (PR #142695)

2025-06-04 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett commented: Agree that `_compute_runtimes_to_test` is a confusing name but if it's going to change anyway, this LGTM. https://github.com/llvm/llvm-project/pull/142695 ___ llvm-branch-commits mailing list llvm-branch-com

[llvm-branch-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #136034)

2025-04-22 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: One of the release managers will do that for us at some point. https://github.com/llvm/llvm-project/pull/136034 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[llvm-branch-commits] [clang] Revert "[clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (#122095)" (PR #134407)

2025-04-07 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/134407 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lldb] release/20.x: [lldb] Use correct path for lldb-server executable (#131519) (PR #134072)

2025-04-05 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: My justification to backport: this was fixing a regression introduced by lldb 20, and https://github.com/llvm/llvm-project/issues/132024 is a separate report of what I think is the same issue. https://github.com/llvm/llvm-project/pull/134072 ___

[llvm-branch-commits] [lldb] release/20.x: [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (#133093) (PR #134079)

2025-04-02 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: My justification for this: this is 1 part (2nd part is https://github.com/llvm/llvm-project/pull/134072) of fixing https://github.com/llvm/llvm-project/issues/132024. Which was a bug introduced in lldb 20. https://github.com/llvm/llvm-project/pull/134079 _

[llvm-branch-commits] [lldb] release/20.x: [lldb] Use correct path for lldb-server executable (#131519) (PR #134072)

2025-04-02 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: > I think it's fine, but I believe you'll also need > https://github.com/llvm/llvm-project/pull/133093 for this to make a > difference. Thanks for pointing that out, I've reproduced the issue and confirmed that we need both changes. https://github.com/llvm/llvm-project/p

[llvm-branch-commits] [CI] Add rich build information for github workflows (PR #133197)

2025-03-27 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/133197 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [CI] Add rich build information for github workflows (PR #133197)

2025-03-27 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/133197 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [CI] Add rich build information for github workflows (PR #133197)

2025-03-27 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,23 @@ +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +"""Script to generate a build report for Github.""" + +import

[llvm-branch-commits] [CI] Add rich build information for github workflows (PR #133197)

2025-03-27 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: TIL that https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#adding-a-job-summary exists, very cool. The title of the PR implies that you are adding more than test results, but the PR description says

[llvm-branch-commits] [libcxx] release/20.x: [libc++][test] extend XFAIL clauses to cover Amazon Linux too (#129377) (PR #129566)

2025-03-08 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: That's expected, PRs to release branches can only be merged by a release manager. They'll do that if they judge it to be valid and the timing is right. https://github.com/llvm/llvm-project/pull/129566 ___ llvm-branch-commits maili

[llvm-branch-commits] [mlir] [mlir][cmake] Add missing MLIRTestDialect dependencies (PR #125834)

2025-02-05 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/125834 >From 0e17c1507085e0d2efb87e6d4064ef2482854804 Mon Sep 17 00:00:00 2001 From: Diego Caballero Date: Thu, 30 Jan 2025 16:09:19 -0800 Subject: [PATCH] [mlir][cmake] Add missing MLIRTestDialect dependencies

[llvm-branch-commits] [mlir] [mlir][cmake] Add missing MLIRTestDialect dependencies (PR #125834)

2025-02-05 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: Actually, I see @nikic doing more fixes. So I will wait for you to finish your work and we can coordinate what needs to go into 20.x. https://github.com/llvm/llvm-project/pull/125834 ___ llvm-branch-commits mailing list llvm-branc

[llvm-branch-commits] [mlir] [mlir][cmake] Add missing MLIRTestDialect dependencies (PR #125834)

2025-02-05 Thread David Spickett via llvm-branch-commits
@@ -27,7 +27,11 @@ add_mlir_library(MLIRTestIR TestVisitorsGeneric.cpp EXCLUDE_FROM_LIBMLIR + + DEPENDS DavidSpickett wrote: I do, in fact - ad152f4bcfe465b57562fa003b93f44e1a3b2287. Will pick this too. https://github.com/llvm/llvm-project/pull/125834

[llvm-branch-commits] [mlir] [mlir][cmake] Add missing MLIRTestDialect dependencies (PR #125834)

2025-02-05 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/125834 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][cmake] Add missing MLIRTestDialect dependencies (PR #125834)

2025-02-05 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: These would be clean cherry-picks but I put them into one commit so I could include the details of what it fixes. I hope that's ok. https://github.com/llvm/llvm-project/pull/125834 ___ llvm-branch-commits mailing list llvm-branch-

[llvm-branch-commits] [mlir] [mlir][cmake] Add missing MLIRTestDialect dependencies (PR #125834)

2025-02-05 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/125834 This cherry picks [mlir][cmake] Add missing MLIRTestDialect dependency (#125004) (72b73c9af694198096b2e0c47a1625e5b94c76a5) and [mlir] Fix build race condition in Pass Manager tests (d906da5ead2764579395e

[llvm-branch-commits] [lldb] release/20.x: [lldb] Add support for gdb-style 'x' packet (#124733) (PR #125653)

2025-02-04 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: I agree with backporting this. There should be a release note for it. I know we could get away without it because the relevant GDB has not been out (maybe not at all) at this point, but it'll be something easy to point to for us in a few years time, and GDB folks who want

[llvm-branch-commits] [compiler-rt] [compiler-rt] Convert Maintainers.txt into Maintainers.md (PR #119169)

2024-12-27 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. Nice! LGTM. https://github.com/llvm/llvm-project/pull/119169 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc

[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

2024-12-12 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: Linux Arm and AArch64, Windows on Arm and x86 bots are fine with the refactoring PR before this. If you haven't had any complaints from the Apple bots (it's native code, so I'd hope not), then this can land. Thanks for putting in the work on the refactoring! https://githu

[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

2024-12-10 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,34 @@ +//===-- NativeRegisterContextDBReg_loongarch.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

2024-12-10 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,34 @@ +//===-- NativeRegisterContextDBReg_loongarch.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

2024-12-10 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett commented: Some small comments but otherwise fine. As usual, approval should come from the architecture expert, which I assume is @SixWeining. Please do not land this right after https://github.com/llvm/llvm-project/pull/118043, wait at least a day to see if a

[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

2024-12-10 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,34 @@ +//===-- NativeRegisterContextDBReg_loongarch.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

2024-12-10 Thread David Spickett via llvm-branch-commits
@@ -58,10 +59,21 @@ NativeRegisterContextLinux_loongarch64::NativeRegisterContextLinux_loongarch64( std::unique_ptr register_info_up) : NativeRegisterContextRegisterInfo(native_thread, register_info_up.release()), - NativeRe

[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

2024-12-10 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/118770 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)

2024-12-05 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,170 @@ +//===-- NativeRegisterContextDBReg_loongarch.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-05 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett commented: LGTM but a LoongArch expert should give the final approval. https://github.com/llvm/llvm-project/pull/114742 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-05 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,104 @@ +//===-- ABISysV_loongarch.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,104 @@ +//===-- ABISysV_loongarch.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [lldb] [lldb][LoongArch] Function calls support in lldb expressions (PR #114742)

2024-11-04 Thread David Spickett via llvm-branch-commits
@@ -0,0 +1,664 @@ +//===-- ABISysV_loongarch.cpp--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm-branch-commits] [llvm] [LoongArch] Optimize for immediate value materialization using BSTRINS_D instruction (PR #106332)

2024-08-30 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: Fixed with https://github.com/llvm/llvm-project/commit/c55e24b8507d47a8cc04b5d9570e8e3d02be1ca3. Some UL that should have been ULL, very easy mistake to make. https://github.com/llvm/llvm-project/pull/106332 ___ llvm-branch-commi

[llvm-branch-commits] [llvm] [LoongArch] Optimize for immediate value materialization using BSTRINS_D instruction (PR #106332)

2024-08-30 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: We have some tests failing on our 32 bit single stage Arm builder. I'm looking into it locally. Usually this is some assumption about type sizes such as size_t. https://lab.llvm.org/buildbot/#/builders/39/builds/1338 https://github.com/llvm/llvm-project/pull/106332 __

[llvm-branch-commits] [clang] [llvm] [AArch64] Add a check for invalid default features (PR #104752)

2024-08-19 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: > This adds a check that all ExtensionWithMArch which are marked as implied > features for an architecture are also present in the list of default features. And do I understand correctly that though this PR is titled "Add a check", it also fixes instances that the check di

[llvm-branch-commits] [clang] [llvm] [AArch64] Add a check for invalid default features (PR #104752)

2024-08-19 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: This needs a summary on the impact of not including the change, for folks who are not familiar with Arm's extension details. > This resulted in a bug where if a feature was marked as Implies but was not > added to DefaultExt, then for -march=base_arch+nofeat the Driver wou

[llvm-branch-commits] [lld] release/18.x: [LLD] [test] Avoid printing timestamps past INT32_MAX with llvm-readobj (#81463) (PR #81468)

2024-02-12 Thread David Spickett via llvm-branch-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/81468 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] release/18.x: [LLD] [test] Avoid printing timestamps past INT32_MAX with llvm-readobj (#81463) (PR #81468)

2024-02-12 Thread David Spickett via llvm-branch-commits
DavidSpickett wrote: I've confirmed locally that this fixes the test as claimed, let's merge it. https://github.com/llvm/llvm-project/pull/81468 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[llvm-branch-commits] [clang] [llvm] [lld] [docs] Add release notes for Windows specific changes in 18.x (PR #80011)

2024-01-31 Thread David Spickett via llvm-branch-commits
Martin =?utf-8?q?Storsj=C3=B6?= Message-ID: In-Reply-To: https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/80011 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https:

[llvm-branch-commits] [lld] [clang] [llvm] [docs] Add release notes for Windows specific changes in 18.x (PR #80011)

2024-01-30 Thread David Spickett via llvm-branch-commits
@@ -319,6 +319,18 @@ Changes to the LLVM tools * llvm-objcopy now supports ``--gap-fill`` and ``--pad-to`` options, for ELF input and binary output files only. +* llvm-rc and llvm-windres now accept file path references in ``.rc`` files + concatenated from multiple string l

  1   2   >