[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

giulianobelinassi wrote: The branch is marked as ` Changes requested ` but no change was pointed in the code. Is everything correct? https://github.com/llvm/llvm-project/pull/88453 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

giulianobelinassi wrote: > I think the 18.1 behavior is already correct? > > https://godbolt.org/z/v3G7h44E1 It is not: https://godbolt.org/z/96rWese3P https://github.com/llvm/llvm-project/pull/88453 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

giulianobelinassi wrote: > I don't think we should add this to the 18.x release -- we're already getting > requests from users to not do that: > https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20240408/566402.html This doesn't affect the number of spaces and it is not based on

[llvm-branch-commits] [clang] Fix override keyword being print to the left side (PR #88453)

https://github.com/giulianobelinassi created https://github.com/llvm/llvm-project/pull/88453 Previously, the `override` keyword in C++ was being print in the left side of a method decl, which is unsupported by C++ standard. This commit fixes that by setting the `CanPrintOnLeft` field to 0,