[llvm-branch-commits] [mlir] [mlir][Interfaces][WIP] `Variable` abstraction for `ValueBoundsOpInterface` (PR #87980)

https://github.com/jpienaar approved this pull request. Nice refactor, I think easier to read https://github.com/llvm/llvm-project/pull/87980 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [mlir] [mlir][Interfaces][WIP] `Variable` abstraction for `ValueBoundsOpInterface` (PR #87980)

https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/87980 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Interfaces][WIP] `Variable` abstraction for `ValueBoundsOpInterface` (PR #87980)

@@ -67,6 +73,83 @@ static std::optional getConstantIntValue(OpFoldResult ofr) { return std::nullopt; } +ValueBoundsConstraintSet::Variable::Variable(OpFoldResult ofr) +: Variable(ofr, std::nullopt) {} + +ValueBoundsConstraintSet::Variable::Variable(Value indexValue) +

[llvm-branch-commits] [mlir] [mlir][Transforms] Add listener support to dialect conversion (PR #83425)

https://github.com/jpienaar approved this pull request. > *[Reviewable](https://reviewable.io/reviews/llvm/llvm-project/83425)* status: > 0 of 4 files reviewed, 1 unresolved discussion (waiting on @ftynse, > @joker-eph, and @matthias-springer) ___

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Simplify handling of erased IR (PR #83423)

https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/83423 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Simplify `BlockTypeConversionRewrite` (PR #83286)

https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/83286 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms] Encapsulate dialect conversion options in `ConversionConfig` (PR #82250)

@@ -1070,6 +1072,30 @@ class PDLConversionConfig final { #endif // MLIR_ENABLE_PDL_IN_PATTERNMATCH +//===--===// +// ConversionConfig

[llvm-branch-commits] [mlir] [mlir][Transforms] Encapsulate dialect conversion options in `ConversionConfig` (PR #82250)

https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/82250 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms] Encapsulate dialect conversion options in `ConversionConfig` (PR #82250)

https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/82250 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn unresolved materializations into `IRRewrite`s (PR #81761)

https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/81761 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [mlir][Transforms] Make `ConversionPatternRewriter` constructor private (PR #82244)

https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/82244 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn op creation into `IRRewrite` (PR #81759)

@@ -1110,7 +1120,18 @@ void ReplaceOperationRewrite::rollback() { void ReplaceOperationRewrite::cleanup() { eraseOp(op); } +void CreateOperationRewrite::rollback() { + for (Region : op->getRegions()) { +while (!region.getBlocks().empty()) +

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn op creation into `IRRewrite` (PR #81759)

@@ -372,7 +368,11 @@ class CreateBlockRewrite : public BlockRewrite { auto = block->getOperations(); while (!blockOps.empty()) blockOps.remove(blockOps.begin()); -eraseBlock(block); +if (block->getParent()) { jpienaar wrote: Nit:

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn op creation into `IRRewrite` (PR #81759)

@@ -2549,10 +2572,15 @@ LogicalResult OperationConverter::legalizeConvertedArgumentTypes( }); return liveUserIt == val.user_end() ? nullptr : *liveUserIt; }; - for (auto : rewriterImpl.rewrites) -if (auto *rewrite = dyn_cast(r.get())) - if

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn op creation into `IRRewrite` (PR #81759)

@@ -299,7 +294,8 @@ class IRRewrite { ReplaceBlockArg, MoveOperation, ModifyOperation, -ReplaceOperation jpienaar wrote: Mmm, come to think of it: would it make sense to have "marker" types here so that you wouldn't need to change below if

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn op creation into `IRRewrite` (PR #81759)

https://github.com/jpienaar approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/81759 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn op creation into `IRRewrite` (PR #81759)

https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/81759 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn block type conversion into `IRRewrite` (PR #81756)

https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/81756 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn block type conversion into `IRRewrite` (PR #81756)

@@ -1173,29 +936,110 @@ struct ConversionPatternRewriterImpl : public RewriterBase::Listener { } // namespace detail } // namespace mlir +void IRRewrite::eraseOp(Operation *op) { + rewriterImpl.eraseRewriter.eraseOp(op); +} + +void IRRewrite::eraseBlock(Block *block) { +

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn block type conversion into `IRRewrite` (PR #81756)

https://github.com/jpienaar approved this pull request. Nice, just small nits. Thanks https://github.com/llvm/llvm-project/pull/81756 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Turn block type conversion into `IRRewrite` (PR #81756)

@@ -1173,29 +936,110 @@ struct ConversionPatternRewriterImpl : public RewriterBase::Listener { } // namespace detail } // namespace mlir +void IRRewrite::eraseOp(Operation *op) { + rewriterImpl.eraseRewriter.eraseOp(op); +} + +void IRRewrite::eraseBlock(Block *block) { +

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Decouple `ConversionPatternRewriterImpl` from `ConversionPatternRewriter` (PR #82333)

https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/82333 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Simplify `ArgConverter` state (PR #81462)

https://github.com/jpienaar approved this pull request. Nice, thanks! https://github.com/llvm/llvm-project/pull/81462 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [mlir] release/18.x: [mlir] Skip invalid test on big endian platform (s390x) (#80246) (PR #81373)

https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/81373 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] 73de3df - Add more explicit assert for failures

Author: Jacques Pienaar Date: 2021-01-22T11:45:25-08:00 New Revision: 73de3df1d28523dbd67dd54594480d126e27b559 URL: https://github.com/llvm/llvm-project/commit/73de3df1d28523dbd67dd54594480d126e27b559 DIFF:

[llvm-branch-commits] [mlir] aee622f - [mlir] Enable passing crash reproducer stream factory method

Author: Jacques Pienaar Date: 2021-01-21T20:03:15-08:00 New Revision: aee622fa200de9ad28334cf74416f2fd5391e2ee URL: https://github.com/llvm/llvm-project/commit/aee622fa200de9ad28334cf74416f2fd5391e2ee DIFF:

[llvm-branch-commits] [mlir] cad16e4 - Avoid unused variable warning in opt mode

Author: Jacques Pienaar Date: 2021-01-20T09:45:22-08:00 New Revision: cad16e4a9267f08229c59e473db6dedd730a5d93 URL: https://github.com/llvm/llvm-project/commit/cad16e4a9267f08229c59e473db6dedd730a5d93 DIFF:

[llvm-branch-commits] [mlir] 8d541a1 - [mlir][shape] Add shape.lib attribute

Author: Jacques Pienaar Date: 2020-12-31T14:46:08-08:00 New Revision: 8d541a1fbe6d92a3fadf6d7d8e8209ed6c76e092 URL: https://github.com/llvm/llvm-project/commit/8d541a1fbe6d92a3fadf6d7d8e8209ed6c76e092 DIFF:

[llvm-branch-commits] [mlir] 8c1f553 - Avoid using /dev/null in test

Author: Jacques Pienaar Date: 2020-12-30T14:16:13-08:00 New Revision: 8c1f55384450a26f6ca391dd25905c32f9ed5644 URL: https://github.com/llvm/llvm-project/commit/8c1f55384450a26f6ca391dd25905c32f9ed5644 DIFF:

[llvm-branch-commits] [mlir] 453b6aa - [mlir] Add option to read reproducer options from file

Author: Jacques Pienaar Date: 2020-12-30T10:46:01-08:00 New Revision: 453b6aadcef9625599d6099011bede710d4524f1 URL: https://github.com/llvm/llvm-project/commit/453b6aadcef9625599d6099011bede710d4524f1 DIFF:

[llvm-branch-commits] [llvm] 2016f2c - Fixes warning 'enumeration value not handled in switch'.

Author: Bogdan Graur Date: 2020-12-30T06:56:29-08:00 New Revision: 2016f2c8a76d67d8cd4771796b6cd19fd66e3f37 URL: https://github.com/llvm/llvm-project/commit/2016f2c8a76d67d8cd4771796b6cd19fd66e3f37 DIFF: https://github.com/llvm/llvm-project/commit/2016f2c8a76d67d8cd4771796b6cd19fd66e3f37.diff

[llvm-branch-commits] [mlir] 5fd2b3a - [mlir] Add error message when failing to add pass

Author: Jacques Pienaar Date: 2020-12-29T14:20:19-08:00 New Revision: 5fd2b3a1246fee0ce1613931fcf1ed51412a6b3f URL: https://github.com/llvm/llvm-project/commit/5fd2b3a1246fee0ce1613931fcf1ed51412a6b3f DIFF:

[llvm-branch-commits] [mlir] e032669 - [mlir] Skip empty op-pipelines in inliner textual opt parsing

Author: Jacques Pienaar Date: 2020-12-29T13:59:53-08:00 New Revision: e03266994af898efcde7b27936250e85f774f39f URL: https://github.com/llvm/llvm-project/commit/e03266994af898efcde7b27936250e85f774f39f DIFF:

[llvm-branch-commits] [mlir] ca1ab0c - [mlir] Add tensor passes to passes.md

Author: Jacques Pienaar Date: 2020-12-23T16:13:03-08:00 New Revision: ca1ab0c66d1c499d4ddcf723dcba692792d531a7 URL: https://github.com/llvm/llvm-project/commit/ca1ab0c66d1c499d4ddcf723dcba692792d531a7 DIFF:

[llvm-branch-commits] [llvm] 44f399c - [FileCheck] Add a literal check directive modifier

Author: Jacques Pienaar Date: 2020-12-18T17:26:15-08:00 New Revision: 44f399ccc12e27d20bae1ea7e712ef7f71e2ff3a URL: https://github.com/llvm/llvm-project/commit/44f399ccc12e27d20bae1ea7e712ef7f71e2ff3a DIFF:

[llvm-branch-commits] [mlir] 9c3fa3d - Don't emit on op diagnostic in reproducer emission

Author: Jacques Pienaar Date: 2020-12-13T07:21:32-08:00 New Revision: 9c3fa3d84d5cdcdcdb5b6961f2c587f84e7caa39 URL: https://github.com/llvm/llvm-project/commit/9c3fa3d84d5cdcdcdb5b6961f2c587f84e7caa39 DIFF:

[llvm-branch-commits] [mlir] e534cee - [mlir] Add a shape function library op

Author: Jacques Pienaar Date: 2020-11-29T11:15:30-08:00 New Revision: e534cee26ae3626ced20438ea82e11291cc768e8 URL: https://github.com/llvm/llvm-project/commit/e534cee26ae3626ced20438ea82e11291cc768e8 DIFF:

[llvm-branch-commits] [mlir] 6dd9596 - [mlir] Add a shape function library op

Author: Jacques Pienaar Date: 2020-11-28T15:53:59-08:00 New Revision: 6dd9596b19d7679c562f8e866be6d0c3d7c21994 URL: https://github.com/llvm/llvm-project/commit/6dd9596b19d7679c562f8e866be6d0c3d7c21994 DIFF:

[llvm-branch-commits] [mlir] 7e3b047 - [mlir] Change include image to be toplevel

Author: Jacques Pienaar Date: 2020-03-22T12:56:57-07:00 New Revision: 7e3b0471715383330c0ea819041497de68051f2d URL: https://github.com/llvm/llvm-project/commit/7e3b0471715383330c0ea819041497de68051f2d DIFF: