https://github.com/DeinAlptraum approved this pull request.
https://github.com/llvm/llvm-project/pull/153876
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/153876
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/DeinAlptraum commented:
Sounds good. A few comments:
Please also remove the `.github/workflows/llvm-project-tests.yml` entry under
`on.push.paths` & `on.pull_request.paths` in the workflow file.
https://github.com/llvm/llvm-project/pull/153876
@@ -25,17 +25,36 @@ on:
jobs:
check-clang-python:
# Build libclang and then run the libclang Python binding's unit tests.
+# There is an issue running on "windows-2019".
+# See
https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
name:
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/148012
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/148012
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/DeinAlptraum commented:
Re: Python bindings changes.
The tests currently fail because the libclang.so cannot even be built. Is this
expected, as in, can it only be built after the last patch again? (I see that
the tests passed on patch 6/6).
This should also probably get an
@@ -63,7 +63,7 @@ def test_a_struct(self):
self.assertIsNotNone(fields[1].translation_unit)
self.assertEqual(fields[1].spelling, "b")
self.assertFalse(fields[1].type.is_const_qualified())
-self.assertEqual(fields[1].type.kind, TypeKind.ELABORATED
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/148012
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/DeinAlptraum approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/149570
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit
10 matches
Mail list logo