[llvm-branch-commits] Prepare libcxx and libcxxabi for pointer field protection. (PR #151651)

@@ -109,4 +109,14 @@ # define _LIBCXXABI_NOEXCEPT noexcept #endif +#if defined(_LIBCXXABI_COMPILER_CLANG) +# if defined(__POINTER_FIELD_PROTECTION__) +#define _LIBCXXABI_NO_PFP [[clang::no_field_protection]] +# else +#define _LIBCXXABI_NO_PFP +# endif +#else +# de

[llvm-branch-commits] Prepare libcxx and libcxxabi for pointer field protection. (PR #151651)

@@ -256,9 +256,12 @@ void unique_ptr_test() { ComparePrettyPrintToRegex(std::move(forty_two), R"(std::unique_ptr containing = {__ptr_ = 0x[a-f0-9]+})"); +#if !defined(__POINTER_FIELD_PROTECTION__) + // GDB doesn't know how to read PFP fields correctly yet. ---

[llvm-branch-commits] [libc++] Add build and CI support for pointer field protection (PR #152414)

@@ -411,6 +411,42 @@ bootstrapping-build) ccache -s ;; +bootstrapping-build-pfp) philnik777 wrote: A bootstrapping build is incredibly heavy weight. Why is this required? https://github.com/llvm/llvm-project/pull/152414 __

[llvm-branch-commits] Prepare libcxx and libcxxabi for pointer field protection. (PR #151651)

@@ -484,8 +484,21 @@ typedef __char32_t char32_t; #define _LIBCPP_EXCEPTIONS_SIG e # endif +# if !_LIBCPP_HAS_EXCEPTIONS +#define _LIBCPP_EXCEPTIONS_SIG n +# else +#define _LIBCPP_EXCEPTIONS_SIG e +# endif + +# if defined(__POINTER_FIELD_PROTECTION__) +#de

[llvm-branch-commits] Prepare libcxx and libcxxabi for pointer field protection. (PR #151651)

@@ -1262,6 +1275,14 @@ typedef __char32_t char32_t; #define _LIBCPP_HAS_EXPLICIT_THIS_PARAMETER 0 # endif +# if defined(__POINTER_FIELD_PROTECTION__) +#define _LIBCPP_PFP [[clang::pointer_field_protection]] +#define _LIBCPP_NO_PFP [[clang::no_field_protection]] -

[llvm-branch-commits] Prepare libcxx and libcxxabi for pointer field protection. (PR #151651)

@@ -26,6 +26,12 @@ # include #endif +#if defined(__POINTER_FIELD_PROTECTION__) +constexpr bool pfp_disabled = false; +#else +constexpr bool pfp_disabled = true; +#endif philnik777 wrote: Again, can we just disable the test instead? https://github.com/llvm/

[llvm-branch-commits] [libcxx] release/21.x: [libc++] Fix broken precondition of __bit_log2 (#155476) (PR #155932)

https://github.com/philnik777 approved this pull request. > > I'd really like to know what the "fallout" here is before we merge > > something into a release branch that has perfectly defined behaviour. > > The fallout is that some people are running with > `-fsanitize=unsigned-integer-overflo

[llvm-branch-commits] [libcxx] release/21.x: [libc++][AIX] Fixup problems with ABI list checking (#155643) (PR #156502)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/156502 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [lldb] release/21.x: [libc++] Ensure that we restore invariants in basic_filebuf::overflow (#147389) (PR #155712)

philnik777 wrote: > > Yeah, this should be good. We should probably also backport the AIX CI fix > > (I just have to remember where it was). > > @philnik777 Are you looking for #156502 ? Yes, thanks! https://github.com/llvm/llvm-project/pull/155712

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/147681 >From a579a8e50acb5fe02004ca8ecbae05b15d54e07c Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 10 Jun 2025 05:56:20 +0200 Subject: [PATCH] [libc++] Add ABI flag to make __tree nodes more compact --

[llvm-branch-commits] [libcxx] [lldb] release/21.x: [libc++] Ensure that we restore invariants in basic_filebuf::overflow (#147389) (PR #155712)

philnik777 wrote: Yeah, this should be good. We should probably also backport the AIX CI fix (I just have to remember where it was). https://github.com/llvm/llvm-project/pull/155712 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.o

[llvm-branch-commits] [libcxx] [lldb] release/21.x: [libc++] Ensure that we restore invariants in basic_filebuf::overflow (#147389) (PR #155712)

philnik777 wrote: I've re-triggered the CI. Let's see if it's happy now. https://github.com/llvm/llvm-project/pull/155712 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc

[llvm-branch-commits] [libcxx] [lldb] release/21.x: [libc++] Ensure that we restore invariants in basic_filebuf::overflow (#147389) (PR #155712)

philnik777 wrote: @Michael137 Do you think the lldb patch should be back-ported? https://github.com/llvm/llvm-project/pull/155712 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[llvm-branch-commits] [libcxx] [lldb] release/21.x: [libc++] Ensure that we restore invariants in basic_filebuf::overflow (#147389) (PR #155712)

https://github.com/philnik777 approved this pull request. The libc++ parts LGTM. I don't know enough about lldb to feel comfortable approving back-ports there. https://github.com/llvm/llvm-project/pull/155712 ___ llvm-branch-commits mailing list llvm-

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix a bunch of random tests (PR #144117)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/144117 >From 7b76244ee066889046d96d7c12d20a89b59e6817 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 13 Jun 2025 18:51:26 +0200 Subject: [PATCH] [libc++][C++03] Fix a bunch of random tests --- .../conta

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix tests which only fail due to incorrect includes (PR #144110)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/144110 >From 40bae50f12fd486508e388c8445f78558ea73086 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 13 Jun 2025 18:14:22 +0200 Subject: [PATCH] [libc++][C++03] Fix tests which only fail due to incorrect

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove XFAILs from the non-frozen libc++-specific tests (PR #144101)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/144101 >From 219ba169840842e131bdb11cf18ee7730a6d1bab Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 13 Jun 2025 17:49:01 +0200 Subject: [PATCH] [libc++][C++03] Remove XFAILs from the non-frozen libc++-s

[llvm-branch-commits] [libcxx] release/21.x [libc++] Fix ABI break introduced by switching to _LIBCPP_COMPRESSED_PAIR (#154686) (PR #155251)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/155251 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/21.x [libc++] Fix ABI break introduced by switching to _LIBCPP_COMPRESSED_PAIR (#154686) (PR #155251)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/155251 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Fix ABI break introduced by switching to _LIBCPP_COMPRESSED_PAIR (#154686) (PR #155251)

https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/155251 LLVM 20 contained an ABI break that can result in the size of `std::unordered_{map,set,multimap,multiset}` and `std::deque` changing when used with an allocator type that is empty and contains a base class tha

[llvm-branch-commits] [clang] release/21.x: [clang] Remove hasValue() check in `RecordExprEvaluator::VisitCXXConstructExpr()` (#154610) (PR #155218)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/155218 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/21.x: [clang] Remove hasValue() check in `RecordExprEvaluator::VisitCXXConstructExpr()` (#154610) (PR #155218)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/155218 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] Remove hasValue() check in `RecordExprEvaluator::VisitCXXConstructExpr()` (#154610) (PR #155218)

https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/155218 When initializing an anonymous struct via an `IndirectFieldDecl`, we create an `APValue` for the struct, but we leave the fields uninitialized. This would later cause the `CXXConstructExpr` that initializes th

[llvm-branch-commits] [libcxx] release/21.x: [libc++] Add tests for the ABI break introduced by switching to _LIBCPP_COMPRESSED_PAIR (#154559) (PR #154945)

https://github.com/philnik777 approved this pull request. This is as green as it gets currently. https://github.com/llvm/llvm-project/pull/154945 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[llvm-branch-commits] [libcxx] release/21.x: [libc++] Fix uses of non-empty transparent comparator in `` (#152624) (PR #152776)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/152776 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/21.x: [libc++] Add checks for misused hardening macros (#150669) (PR #151582)

philnik777 wrote: > Who can review? > > btw what's up with the buildkite ci never ending? I don't know; I've pinged the owner. I don't think it should be blocking though. https://github.com/llvm/llvm-project/pull/151582 ___ llvm-branch-commits mailin

[llvm-branch-commits] [libcxx] release/21.x: [libc++] Add checks for misused hardening macros (#150669) (PR #151582)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/151582 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/21.x: [libc++] Fix tests after #144220 (PR #152105)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/152105 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/21.x: [libc++] Implement comparison operators for `tuple` added in C++23 (#148799) (PR #151808)

https://github.com/philnik777 requested changes to this pull request. Why do we want to back-port this? This looks to me very much like feature work. https://github.com/llvm/llvm-project/pull/151808 ___ llvm-branch-commits mailing list llvm-branch-comm

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

@@ -593,6 +594,43 @@ public: __tree_node_base& operator=(__tree_node_base const&) = delete; }; +#ifdef _LIBCPP_ABI_TREE_POINTER_INT_PAIR +template <> +class __tree_node_base : public __tree_end_node<__tree_node_base*> { +public: + using pointer=

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/147681 >From 019af0059fa1d33deb0aaf278212f9a37dcbf8de Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 10 Jun 2025 05:56:20 +0200 Subject: [PATCH] [libc++] Add ABI flag to make __tree nodes more compact --

[llvm-branch-commits] [libcxx] release/21.x: [libc++][Android] Reenable 2 tests for Android (#149415) (PR #150002)

https://github.com/philnik777 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/150002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [libcxx] release/21.x: [libc++] Fix hash_multi{map, set}::insert (#149290) (PR #149435)

philnik777 wrote: The failures are unrelated. It's #149415. https://github.com/llvm/llvm-project/pull/149435 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Add accessor functions to __tree_node_base (PR #147679)

philnik777 wrote: > I think this could be rebased onto `main` -- it doesn't depend on > `__pointer_int_pair` in itself. That is true, but there is no way to stack a PR from two independent PRs AFAIK. https://github.com/llvm/llvm-project/pull/147679 _

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

https://github.com/philnik777 ready_for_review https://github.com/llvm/llvm-project/pull/147681 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Add accessor functions to __tree_node_base (PR #147679)

https://github.com/philnik777 ready_for_review https://github.com/llvm/llvm-project/pull/147679 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/147681 >From 2335111d19903652229a8e3fb25cd03b5ffa5e48 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 10 Jun 2025 05:56:20 +0200 Subject: [PATCH] [libc++] Add ABI flag to make __tree nodes more compact --

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/147681 >From 920e83463665654fd7b48b5e70591fb978b7b50e Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 10 Jun 2025 05:56:20 +0200 Subject: [PATCH] [libc++] Add ABI flag to make __tree nodes more compact --

[llvm-branch-commits] [libcxx] [libc++] Add accessor functions to __tree_node_base (PR #147679)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/147679 >From 8e5e6f010dd8c3aaab2de28b7c33c10d3cbf8a55 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Mon, 9 Jun 2025 18:17:31 +0200 Subject: [PATCH] [libc++] Add accessor functions to __tree_node_base --- li

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/147681 >From bed3297d32d7a270d216ee3efb706b914fc32f2b Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 10 Jun 2025 05:56:20 +0200 Subject: [PATCH] [libc++] Add ABI flag to make __tree nodes more compact --

[llvm-branch-commits] [libcxx] [libc++] Add ABI flag to make __tree nodes more compact (PR #147681)

https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/147681 None >From bd3919aed4aa6cae451541d2ad29f914e2785dc0 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 10 Jun 2025 05:56:20 +0200 Subject: [PATCH] [libc++] Add ABI flag to make __tree nodes more compa

[llvm-branch-commits] [libcxx] [libc++] Add accessor functions to __tree_node_base (PR #147679)

https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/147679 None >From f1fc048e52e5c57898fcb226a1fe3c8519cb5923 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Mon, 9 Jun 2025 18:17:31 +0200 Subject: [PATCH] [libc++] Add accessor functions to __tree_node_base -

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix a bunch of random tests (PR #144117)

https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/144117 This fixes/removes a bunch of random tests. They all failed in relatively simple to fix ways. Specificially (all inside `libcxx/test/libcxx-03`): - `utilities/template.bitset/includes.pass.cpp`: the header g

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix tests which only fail due to incorrect includes (PR #144110)

https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/144110 Quite a few of the frozen header tests only fail because the include path is incorrect due to copying the headers. This patch fixes the tests where that's the only problem. This is part of https://discourse

[llvm-branch-commits] [libcxx] [libc++][C++03] Remove XFAILs from the non-frozen libc++-specific tests (PR #144101)

https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/144101 The tests in `libcxx/test/libcxx` aren't run against the frozen headers anymore, so we can remove any XFAILs in them. This is part of https://discourse.llvm.org/t/rfc-freezing-c-03-headers-in-libc. >From e

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Add _LIBCPP_NO_UNIQUE_ADDRESS to flat_{, multi}map::value_compare (#137594) (PR #138880)

philnik777 wrote: @tstellar The CI failures are most certainly unrelated. https://github.com/llvm/llvm-project/pull/138880 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bran

[llvm-branch-commits] [libcxx] [libcxx] Include __fwd/span.h in (PR #142925)

https://github.com/philnik777 approved this pull request. LGTM with added comment. https://github.com/llvm/llvm-project/pull/142925 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[llvm-branch-commits] [libcxx] [libcxx] Include __fwd/span.h in (PR #142925)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/142925 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libcxx] Include __fwd/span.h in (PR #142925)

@@ -451,6 +451,7 @@ namespace std { # if _LIBCPP_STD_VER >= 23 #include <__fwd/mdspan.h> +#include <__fwd/span.h> philnik777 wrote: Can you add a comment with the LWG issue number? If the answer is that we indeed expect users to include `` we should

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] [test] Extend mingw workarounds for armv7/aarch64 too (#136419) (PR #136752)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/136752 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [libc++][CI] Pin the XCode version. (PR #135412)

https://github.com/philnik777 approved this pull request. @ldionne Should make sure this is correct when he is back. I'm not entirely sure whether "latest stable release" means latest minor or latest major (also, we're not up-to-date in the docs which XCode we're supporting). https://github.co

[llvm-branch-commits] [libcxx] libcxx: In gdb test detect execute_mi with feature check instead of version check. (PR #132291)

philnik777 wrote: It looks like your merge base is wrong. https://github.com/llvm/llvm-project/pull/132291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] libcxx: In gdb test detect execute_mi with feature check instead of version check. (PR #132291)

https://github.com/philnik777 approved this pull request. LGTM assuming the diff landed is the same I see. I'm really not a fan of complicating things unnecessarily though. https://github.com/llvm/llvm-project/pull/132291 ___ llvm-branch-commits mail

[llvm-branch-commits] [libcxx] libcxx: In gdb test detect execute_mi with feature check instead of version check. (PR #132291)

philnik777 wrote: Could you not use spr in that case? I can't see the diff as it would be merged AFAICT. https://github.com/llvm/llvm-project/pull/132291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cg

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/133010 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Remove the need for _LIBCPP_TEMPLATE_VIS (PR #133010)

https://github.com/philnik777 ready_for_review https://github.com/llvm/llvm-project/pull/133010 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/128366 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

@@ -0,0 +1,47 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

https://github.com/philnik777 requested changes to this pull request. @denzor200 It's a lot easier for us to add a libc++-speicific clang-tidy check than a general one. libc++ checks have significantly lower quality requirements, since they only have to work for libc++ (making "seems to work f

[llvm-branch-commits] [libcxx] [libc++][CI] Update action runner base image. (PR #130433)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/130433 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Guard contents on _LIBCPP_HAS_LOCALIZATION (#129112) (PR #129305)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/129305 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [libc++][ci] Update the Windows toolchains to Clang 19 (#129232) (PR #129303)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/129303 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Set feature-test macro `__cpp_lib_atomic_float` (#127559) (PR #127732)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/127732 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/20.x: [libc++] Replace __is_trivially_relocatable by is_trivially_copyable (#124970) (PR #125996)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/125996 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang] cherry-pick "Fix __{add, remove}_pointer in Objective-C++" (PR #125185)

https://github.com/philnik777 milestoned https://github.com/llvm/llvm-project/pull/125185 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang] cherry-pick "Fix __{add, remove}_pointer in Objective-C++" (PR #125185)

https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/125185 This aligns the builtins with how implementations work which don't use the buitins. >From a729e9190f8047b455d80224e92844b12e493e3c Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Thu, 30 Jan 2025 20:34

[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Use _ftelli64/_fseeki64 on Windows (#123128) (PR #124922)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/124922 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/109002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -587,42 +587,48 @@ template */ -#include <__config> - -#include <__atomic/aliases.h> -#include <__atomic/atomic.h> -#include <__atomic/atomic_base.h> -#include <__atomic/atomic_flag.h> -#include <__atomic/atomic_init.h> -#include <__atomic/atomic_lock_free.h> -#include <_

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

@@ -1827,232 +1827,147 @@ template */ -#include <__config> - -#include <__algorithm/adjacent_find.h> -#include <__algorithm/all_of.h> -#include <__algorithm/any_of.h> -#include <__algorithm/binary_search.h> -#include <__algorithm/copy.h> -#include <__algorithm/copy_backward.

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

@@ -1021,17 +1021,8 @@ set(files configure_file("__config_site.in" "${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY) philnik777 wrote: I think this change is fine. I'll have to modify this anyways and removing the copying now means I won't introduc

[llvm-branch-commits] [libcxx] [libc++] Stop copying headers to the build directory (PR #115380)

@@ -1021,17 +1021,8 @@ set(files configure_file("__config_site.in" "${LIBCXX_GENERATED_INCLUDE_TARGET_DIR}/__config_site" @ONLY) philnik777 wrote: This isn't used _yet_. https://github.com/llvm/llvm-project/pull/115380 _

[llvm-branch-commits] [libcxx] [libc++][C++03] Update include guards (PR #109001)

https://github.com/philnik777 ready_for_review https://github.com/llvm/llvm-project/pull/109001 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

https://github.com/philnik777 ready_for_review https://github.com/llvm/llvm-project/pull/109002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix libc++ includes (PR #109000)

https://github.com/philnik777 ready_for_review https://github.com/llvm/llvm-project/pull/109000 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [llvm] [libc++][C++03] Use `__cxx03/` headers in C++03 mode (PR #109002)

philnik777 wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/109002?utm_source=stack-comment-downstack-mergeability-warnin

[llvm-branch-commits] [libcxx] [libc++][C++03] Update include guards (PR #109001)

philnik777 wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/109001?utm_source=stack-comment-downstack-mergeability-warnin

[llvm-branch-commits] [libcxx] [libc++][C++03] Fix libc++ includes (PR #109000)

philnik777 wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/109000?utm_source=stack-comment-downstack-mergeability-warnin

[llvm-branch-commits] [libcxx] [libc++][format][2/7] Optimizes c-string arguments. (PR #101805)

philnik777 wrote: It's also worth noting that compilers can constant-fold `strlen`, so in cases where the string is known this doesn't even result in multiple iterations. https://github.com/llvm/llvm-project/pull/101805 ___ llvm-branch-commits mailing

[llvm-branch-commits] [libcxx] release/19.x: [NFC][libc++][test][AIX] UnXFAIL LIT test transform.pass.cpp (#102338) (PR #102466)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/102466 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] b2eab34 - [Clang] Add a release note deprecating __is_nullptr

Author: Nikolas Klauser Date: 2024-08-02T10:53:33+02:00 New Revision: b2eab3486499656ec6ef30ace5033f80d4d9dfc9 URL: https://github.com/llvm/llvm-project/commit/b2eab3486499656ec6ef30ace5033f80d4d9dfc9 DIFF: https://github.com/llvm/llvm-project/commit/b2eab3486499656ec6ef30ace5033f80d4d9dfc9.dif

[llvm-branch-commits] [clang] [Clang] Add a release note deprecating __is_nullptr (PR #101638)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/101638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang] Add a release note deprecating __is_nullptr (PR #101638)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/101638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release note is nullptr removal (PR #101638)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/101638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release note is nullptr removal (PR #101638)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/101638 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/19.x: [libc++] Add missing xlocale.h include on Apple and FreeBSD (#99689) (PR #100604)

https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/100604 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

@@ -0,0 +1,93 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [clang] [libcxx] [clang] Finish implementation of P0522 (PR #96023)

@@ -18,5 +18,9 @@ #include #include -// expected-error@+1 {{template template argument has different template parameters than its corresponding template template parameter}} -static_assert(!std::__is_specialization_v, std::array>); +#if defined(__clang__) && __clang_major_

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

@@ -0,0 +1,233 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

@@ -0,0 +1,233 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

@@ -0,0 +1,233 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

philnik777 wrote: @EricWF When switching to `__libcpp_operator_{new,delete}` everything gets compiled exactly the same on my system. Could you disclose which test you used for this code? You also claim that the `__pointer_int_pair` causes the optimizer to lose track of the function pointer cau

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

@@ -0,0 +1,46 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

@@ -0,0 +1,233 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

@@ -0,0 +1,46 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

@@ -0,0 +1,233 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/94670 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Add [[nodiscard]] to (PR #89181)

https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/89181 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Add [[nodiscard]] to (PR #89181)

https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/89181 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang][Driver] Add special-casing for including libc++ in C++03 (PR #83723)

https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/83723 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

  1   2   >