[llvm-branch-commits] [llvm] release/18.x: [cmake] Add minor version to library SONAME (#79376) (PR #82409)

2024-03-04 Thread Ralf Jung via llvm-branch-commits
RalfJung wrote: > So the problem Rust sees isn't that a ".1" was added to the version, but > rather that the name was changed from "libLLVM-18-rust-1.78.0-nightly.so" to > "libLLVM.so.18.1-rust-1.78.0-nightly". (that is: all the version info > previously went into the library name which comes

[llvm-branch-commits] [llvm] release/18.x: [cmake] Add minor version to library SONAME (#79376) (PR #82409)

2024-03-04 Thread Ralf Jung via llvm-branch-commits
RalfJung wrote: Yeah, I linked to it: https://github.com/rust-lang/rust/issues/121889. I'm not a linker expert, but it seems that now symlinks are required to link against the LLVM .so file, but we can't ship symlinks in our artifacts because of Windows. The old approach we used of just shippi

[llvm-branch-commits] [llvm] release/18.x: [cmake] Add minor version to library SONAME (#79376) (PR #82409)

2024-03-03 Thread Ralf Jung via llvm-branch-commits
RalfJung wrote: Making such a fundamental change to the .so file so late in the release was probably a bad idea... a bunch of downstream projects will have to adjust the way they link with LLVM and that's [not always easy](https://github.com/rust-lang/rust/issues/121889). https://github.com/l