[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-29 Thread Andres Villegas via llvm-branch-commits
https://github.com/avillega updated https://github.com/llvm/llvm-project/pull/89703 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-29 Thread Andres Villegas via llvm-branch-commits
https://github.com/avillega updated https://github.com/llvm/llvm-project/pull/89703 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-24 Thread David Blaikie via llvm-branch-commits
dwblaikie wrote: Oh, sorry, right - that API should/might be used by `llvm-symbolizer` and the change might be visible through its behavior? https://github.com/llvm/llvm-project/pull/89703 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-23 Thread Andres Villegas via llvm-branch-commits
avillega wrote: I was trying to figure out why llvm-dwarfdump does not seem to be affected by my change, there are note failing tests and I don't see any changes by doing some manual testing of some simple test cases. It seems that `llvm-dwarfdump` does not use the API I changed, for

[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-23 Thread David Blaikie via llvm-branch-commits
dwblaikie wrote: > I'd like to know how this affects the output of llvm-dwarfdump. Intuitively > it feels like something around the display of end_sequence rows should have > changed, but I'm willing to be corrected. +1 - given the change to DWARFDebugLine, I'd expect this to be observable

[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-23 Thread Paul T Robinson via llvm-branch-commits
pogo59 wrote: I'd like to know how this affects the output of llvm-dwarfdump. Intuitively it feels like something around the display of end_sequence rows should have changed, but I'm willing to be corrected. https://github.com/llvm/llvm-project/pull/89703

[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Andres Villegas (avillega) Changes Work around for https://github.com/llvm/llvm-project/issues/46494. Before this change end_sequence rows in debug_line were not included in `DWARFDebugLine::LineTable::lookupAddressRangeImpl`, this was

[llvm-branch-commits] [GSYM][DWARF] Include end_sequence debug_line rows when looking up addr ranges (PR #89703)

2024-04-22 Thread Andres Villegas via llvm-branch-commits
https://github.com/avillega created https://github.com/llvm/llvm-project/pull/89703 Work around for https://github.com/llvm/llvm-project/issues/46494. Before this change end_sequence rows in debug_line were not included in `DWARFDebugLine::LineTable::lookupAddressRangeImpl`, this was