[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

@@ -424,19 +439,13 @@ static void convertFunctionLineTable(OutputAggregator , CUInfo , auto LastLE = FI.OptLineTable->last(); if (LastLE && LastLE->File == FileIdx && LastLE->Line == Row.Line) continue; + // Only push a row if it isn't an end sequence.

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

@@ -424,19 +439,13 @@ static void convertFunctionLineTable(OutputAggregator , CUInfo , auto LastLE = FI.OptLineTable->last(); if (LastLE && LastLE->File == FileIdx && LastLE->Line == Row.Line) continue; + // Only push a row if it isn't an end sequence.

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

@@ -424,19 +439,13 @@ static void convertFunctionLineTable(OutputAggregator , CUInfo , auto LastLE = FI.OptLineTable->last(); if (LastLE && LastLE->File == FileIdx && LastLE->Line == Row.Line) continue; + // Only push a row if it isn't an end sequence.

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

@@ -321,7 +321,10 @@ static void convertFunctionLineTable(OutputAggregator , CUInfo , StartAddress, object::SectionedAddress::UndefSection}; - if (!CUI.LineTable->lookupAddressRange(SecAddress, RangeSize, RowVector)) { + // end_sequence markers can be located at

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/90535 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

@@ -424,19 +439,13 @@ static void convertFunctionLineTable(OutputAggregator , CUInfo , auto LastLE = FI.OptLineTable->last(); if (LastLE && LastLE->File == FileIdx && LastLE->Line == Row.Line) continue; + // Only push a row if it isn't an end sequence.

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

@@ -354,6 +357,18 @@ static void convertFunctionLineTable(OutputAggregator , CUInfo , for (uint32_t RowIndex : RowVector) { // Take file number and line/column from the row. const DWARFDebugLine::Row = CUI.LineTable->Rows[RowIndex]; + +// TODO(avillega): With

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

https://github.com/clayborg commented: Not sure this makes sense after checking the code for `DWARFDebugLine::LineTable::lookupAddressRangeImpl(...)`. If a line table has multiple sequences that contain an address, it will find the first sequence that contains the address and then return the

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

avillega wrote: I think I can accomplish the same behaviour exposed in https://github.com/llvm/llvm-project/pull/89703 which requires a change to the DWARF apis without actually changing them. https://github.com/llvm/llvm-project/pull/90535 ___

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Andres Villegas (avillega) Changes Work around for #46494. This change adds debug_line end_sequence rows when converting the function line tables. By including the end_sequence it is possible to handle some edge cases like icf

[llvm-branch-commits] [GSYM] Include end_sequence debug_line rows in Dwarf transform (PR #90535)

https://github.com/avillega created https://github.com/llvm/llvm-project/pull/90535 Work around for #46494. This change adds debug_line end_sequence rows when converting the function line tables. By including the end_sequence it is possible to handle some edge cases like icf optimizations.