ChuanqiXu9 wrote:
> We've hit an error during testing:
>
> ```c++
> In module '...stl_cc_library':
> .../src/libcxx/include/__memory/allocator.h:128:60: error:
> 'std::allocator>::deallocate' from
> module '...stl_cc_library./cxx17/vector' is not present in definition of
> 'std::allocator>'
ilya-biryukov wrote:
We've hit an error during testing:
```cpp
In module '...stl_cc_library':
.../src/libcxx/include/__memory/allocator.h:128:60: error:
'std::allocator>::deallocate' from
module '...stl_cc_library./cxx17/vector' is not present in definition of
'std::allocator>' provided
alexfh wrote:
> bool operator==(const LazySpecializationInfo )
Making this `operator==` `const` helps with the warning in C++20. And it's the
right thing to do anyway.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing
ChuanqiXu9 wrote:
> > > @ilya-biryukov, could we have another try of this PR on your end?
> >
> >
> > Sorry for missing this, we will rerun the testing and get back to you.
>
> In the meantime, could you rebase the patch on top of current ToT?
Are you saying to rebase on your local branch?
alexfh wrote:
I'm getting this error when trying to bootstrap Clang:
```
In file included from clang/lib/Serialization/ASTReaderDecl.cpp:15:
clang/lib/Serialization/ASTReaderInternals.h:160:19: error: ISO C++20 considers
use of overloaded operator '==' (with operand types
ilya-biryukov wrote:
> In the meantime, could you rebase the patch on top of current ToT?
I thought that it should not have any merge conflicts and it turned out to be
almost true, the only conflict I encountered was in `CMakeLists.txt`, feel free
to use this squashed and rebased commit for
alexfh wrote:
> > @ilya-biryukov, could we have another try of this PR on your end?
>
> Sorry for missing this, we will rerun the testing and get back to you.
In the meantime, could you rebase the patch on top of current ToT?
https://github.com/llvm/llvm-project/pull/83237
ilya-biryukov wrote:
> @ilya-biryukov, could we have another try of this PR on your end?
Sorry for missing this, we will rerun the testing and get back to you.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/83237
>From f2e53e44eebab4720a1dbade24fcb14d698fb03f Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Wed, 28 Feb 2024 11:41:53 +0800
Subject: [PATCH 1/2] [Serialization] Code cleanups and polish 83233
---
ChuanqiXu9 wrote:
@vgvassilev In the newest version, I introduced a new hasher
TemplateArgumentHasher and use this new hasher to calculate the hash value for
template arguments. We thought this may be harder. But I just realized, we
don't have to provide a very precise results at first. Since
ChuanqiXu9 wrote:
@ilya-biryukov I've fixed the crash occured in the reproducer. The root reason
is that, previously, I wouldn't load all the specializations for paritial
specializations. But this is not safe. I think you can test it again.
https://github.com/llvm/llvm-project/pull/83237
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/83237
>From f2e53e44eebab4720a1dbade24fcb14d698fb03f Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Wed, 28 Feb 2024 11:41:53 +0800
Subject: [PATCH] [Serialization] Code cleanups and polish 83233
---
ChuanqiXu9 wrote:
Sorry for bothering, I tried a new manner to update the patch but it shows I
should better : (
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ilya-biryukov wrote:
After endless hours and recompilations, I finally have this to share.
It could probably be smaller, but I decided to share this as soon as it crashed
outside of our monorepo.
[module.tgz](https://github.com/llvm/llvm-project/files/15223606/module.tgz)
^^ If you run
alexfh wrote:
Apologies for the delay with the reproducer. @ilya-biryukov is on vacation, but
maybe @sam-mccall can help with an isolated test case. Either way it seems to
be challenging.
https://github.com/llvm/llvm-project/pull/83237
___
ChuanqiXu9 wrote:
Rebased with main
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/83237
>From f4edc5b1cde1735d1c9c9f6c43ef4f50066965b0 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Wed, 28 Feb 2024 11:41:53 +0800
Subject: [PATCH 1/2] [Serialization] Code cleanups and polish 83233
---
ChuanqiXu9 wrote:
> Sorry, still struggling to get a small repro. The build graphs we have are
> quite large, unfortunately. Did any of the stack traces or error message I
> posted help to find certain problems? Or is there no hope until we get a
> smaller repro?
I tried to review the patch
vgvassilev wrote:
> > Can you export all files into a standalone reproducer? I might be able to
> > reduce an example.
>
> Not really, this is why it's taking so long. Our infrastructure in that space
> is lacking, the issue is that the root case is not in one compilation step,
> but rather
ilya-biryukov wrote:
> Can you export all files into a standalone reproducer? I might be able to
> reduce an example.
Not really, this is why it's taking so long. Our infrastructure in that space
is lacking, the issue is that the root case is not in one compilation step, but
rather in some
vgvassilev wrote:
Can you export all files into a standalone reproducer? I might be able to
reduce an example.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ilya-biryukov wrote:
Sorry, still struggling to get a small repro. The build graphs we have are
quite large, unfortunately.
Did any of the stack traces or error message I posted help to find certain
problems? Or is there no hope until we get a smaller repro?
ilya-biryukov wrote:
We have hit quite a few issues when trying this out. I have spent a day trying
to reduce to a small repro that I can share, but haven't not fully succeeded
yet, I will continue tomorrow.
Still wanted to share the error descriptions in case that would allow to make
ilya-biryukov wrote:
Thanks for fixing it quickly, we'll try the new patch and get back with the
results.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ChuanqiXu9 wrote:
Thanks for the reduced test case. It is pretty helpful. I've added it to the
current patch.
The root cause of the issue comes from an oversight in
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/83237
>From 40012e175a6ab3420e2dcaa64538b210173d6950 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Wed, 28 Feb 2024 11:41:53 +0800
Subject: [PATCH 1/2] [Serialization] Code cleanups and polish 83233
---
ilya-biryukov wrote:
Sorry for the delay, I had an emergency and took a week off.
We have hit some form of OOM (an infinite loop or some exponential computation
allocating memory?) on the following small example (ready as a test case, also
in [this
vgvassilev wrote:
> Btw, if I don't respond timely to these requests and you need an urgent
> reaction, feel free to ping me via email at
> [ibiryu...@google.com](mailto:ibiryu...@google.com). We heavily use Clang
> header modules internally at Google and we are really interested in helping
ilya-biryukov wrote:
Btw, if I don't respond timely to these requests and you need an urgent
reaction, feel free to ping me via email at ibiryu...@google.com.
We heavily use Clang header modules internally at Google and we are really
interested in helping to discover and prevent the module
ilya-biryukov wrote:
We'll pick this up, I'll get back with the testing results.
(Sorry for the delayed response)
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
vgvassilev wrote:
> @ilya-biryukov hi, the functional and performance test on the root side looks
> good: [root-project/root#14495
> (comment)](https://github.com/root-project/root/pull/14495#issuecomment-1980589145)
>
> Could you try to test this within google internals?
>
> Also if your
ChuanqiXu9 wrote:
@ilya-biryukov hi, the functional and performance test on the root side looks
good: https://github.com/root-project/root/pull/14495#issuecomment-1980589145
Could you try to test this within google internals?
Also if your projects implements new ExternalASTSource, you need
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/83237
>From 1d288e76b213a25d15fa6abdf633488838ed100a Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Wed, 28 Feb 2024 11:41:53 +0800
Subject: [PATCH] [Serialization] Code cleanups and polish 83233
---
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/83237
>From 19617bbdd5b83076140af087d3da0b46d4fe0208 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Wed, 28 Feb 2024 11:41:53 +0800
Subject: [PATCH] [Serialization] Code cleanups and polish 83233
---
ChuanqiXu9 wrote:
> > The error message looks odd since the language options shouldn't be
> > involved.
>
> Sorry, I did not push. Now you can take a look.
I mean your local results.
https://github.com/llvm/llvm-project/pull/83237
___
vgvassilev wrote:
> The error message looks odd since the language options shouldn't be involved.
Sorry, I did not push. Now you can take a look.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
ChuanqiXu9 wrote:
The error message looks odd since the language options shouldn't be involved.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
vgvassilev wrote:
> @vgvassilev this may be ready to test.
I triggered a test here: https://github.com/root-project/root/pull/14495
I still need to verify if I did not screw up bringing your changes back to our
builds but locally it crashes quite early with:
```
0 rootcling_stage1
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ChuanqiXu9 wrote:
@vgvassilev this may be ready to test.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -257,22 +241,12 @@ namespace clang {
// If we have any lazy specializations, and the external AST source is
// our chained AST reader, we can just write out the DeclIDs. Otherwise,
// we need to resolve them to actual declarations.
- if (Writer.Chain
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang
Author: Chuanqi Xu (ChuanqiXu9)
Changes
This is the following of https://github.com/llvm/llvm-project/pull/83233. This
simply removes `LazySpecializationInfo` from `RedeclarableTemplateDecl`. I
feel it can
https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/83237
This is the following of https://github.com/llvm/llvm-project/pull/83233. This
simply removes `LazySpecializationInfo` from `RedeclarableTemplateDecl`. I
feel it can make the review process much more easier
43 matches
Mail list logo
