[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

@@ -3358,14 +3396,17 @@ genOMP(Fortran::lower::AbstractConverter &converter, .t); // Currently only private/firstprivate clause is handled, and // all privatization is done within `omp.section` operations. + symTable.pushScope(); kparzysz wro

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

@@ -110,6 +110,32 @@ static void gatherFuncAndVarSyms( } } +static Fortran::lower::pft::Evaluation * +getEvalPastCollapse(Fortran::lower::pft::Evaluation &eval, int collapseValue) { skatrak wrote: Nit: I tend to read this function name as meaning "return th

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

@@ -3655,8 +3661,7 @@ void Fortran::lower::genOpenMPDeclarativeConstruct( Fortran::lower::pft::Evaluation &eval, const Fortran::parser::OpenMPDeclarativeConstruct &omp) { genOMP(converter, eval, omp); skatrak wrote: Nit: I guess the `symTable` argume

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

@@ -3358,14 +3396,17 @@ genOMP(Fortran::lower::AbstractConverter &converter, .t); // Currently only private/firstprivate clause is handled, and // all privatization is done within `omp.section` operations. + symTable.pushScope(); skatrak wrot

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

https://github.com/skatrak commented: Thanks Krzysztof! Just some small comments, but I like the approach. https://github.com/llvm/llvm-project/pull/77758 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cg

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

https://github.com/skatrak edited https://github.com/llvm/llvm-project/pull/77758 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/77758 >From 841ae5f68c36628bf209b220595fcb6e81bad18d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 9 Jan 2024 12:22:06 -0600 Subject: [PATCH] [Flang][OpenMP] Push genEval calls to individual operations

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/77758 >From 841ae5f68c36628bf209b220595fcb6e81bad18d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 9 Jan 2024 12:22:06 -0600 Subject: [PATCH] [Flang][OpenMP] Push genEval calls to individual operations

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Author: Krzysztof Parzyszek (kparzysz) Changes Introduce `genNestedEvaluations` that will lower all evaluations nested in the given, accouting for a potential COLLAPSE directive. Recursive lowering [2/5] --- Full diff: https://github.c

[llvm-branch-commits] [flang] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/77758 Introduce `genNestedEvaluations` that will lower all evaluations nested in the given, accouting for a potential COLLAPSE directive. Recursive lowering [2/5] >From fd51d9b3ad850579787cb31a5423498e09d51f0c Mon S