[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

kparzysz wrote: We can switch to ArrayRef in another PR. https://github.com/llvm/llvm-project/pull/87086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

@@ -58,17 +58,15 @@ void gatherFuncAndVarSyms( const ObjectList , mlir::omp::DeclareTargetCaptureClause clause, llvm::SmallVectorImpl ); +int64_t getCollapseValue(const List ); skatrak wrote: It looks like this function is only used within

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

@@ -2357,44 +2332,44 @@ genOMP(Fortran::lower::AbstractConverter , converter.genLocation(beginBlockDirective.source); const auto origDirective = std::get(beginBlockDirective.t).v; - const auto = - std::get(beginBlockDirective.t); - const auto = -

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

@@ -49,9 +49,8 @@ class ClauseProcessor { public: ClauseProcessor(Fortran::lower::AbstractConverter , Fortran::semantics::SemanticsContext , - const Fortran::parser::OmpClauseList ) - : converter(converter), semaCtx(semaCtx), -

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

https://github.com/skatrak edited https://github.com/llvm/llvm-project/pull/87086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

https://github.com/skatrak approved this pull request. Thank you Krzysztof, LGTM. I have a couple of suggestions, but this should be ready if you don't agree with them. https://github.com/llvm/llvm-project/pull/87086 ___ llvm-branch-commits mailing

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

@@ -597,14 +599,11 @@ static void removeStoreOp(mlir::Operation *reductionOp, mlir::Value symVal) { // TODO: Generate the reduction operation during lowering instead of creating // and removing operations since this is not a robust approach. Also, removing // ops in the

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

https://github.com/luporl approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/87086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Author: Krzysztof Parzyszek (kparzysz) Changes This removes the last use of genOmpObectList2, which has now been removed. --- Patch is 58.36 KiB, truncated to 20.00 KiB below, full version:

[llvm-branch-commits] [flang] [flang][OpenMP] Move clause/object conversion to happen early, in genOMP (PR #87086)

https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/87086 This removes the last use of genOmpObectList2, which has now been removed. >From f725face892cef4faf9f17d4b549541bdbcd7e08 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Fri, 29 Mar 2024 09:20:41