@@ -2012,34 +2012,87 @@ void OmpAttributeVisitor::Post(const parser::Name
&name) {
}
}
}
-std::vector defaultDSASymbols;
+
+// Implicitly determined DSAs
+// OMP 5.2 5.1.1 - Variables Referenced in a Construct
+Symbol *lastDeclSymbol = nullptr
@@ -2012,34 +2012,87 @@ void OmpAttributeVisitor::Post(const parser::Name
&name) {
}
}
}
-std::vector defaultDSASymbols;
+
+// Implicitly determined DSAs
+// OMP 5.2 5.1.1 - Variables Referenced in a Construct
+Symbol *lastDeclSymbol = nullptr
https://github.com/luporl updated
https://github.com/llvm/llvm-project/pull/85989
>From 94301e00239b789cf90d5291b1d733f0f2baab6c Mon Sep 17 00:00:00 2001
From: Leandro Lupori
Date: Mon, 11 Mar 2024 16:47:47 -0300
Subject: [PATCH 1/2] [flang][OpenMP] Support tasks' implicit firstprivate DSA
Han
@@ -2012,34 +2012,87 @@ void OmpAttributeVisitor::Post(const parser::Name
&name) {
}
}
}
-std::vector defaultDSASymbols;
+
+// Implicitly determined DSAs
+// OMP 5.2 5.1.1 - Variables Referenced in a Construct
+Symbol *lastDeclSymbol = nullptr
https://github.com/kiranchandramohan approved this pull request.
LG. Nice work.
https://github.com/llvm/llvm-project/pull/85989
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm
https://github.com/kiranchandramohan edited
https://github.com/llvm/llvm-project/pull/85989
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
luporl wrote:
@NimishMishra Thanks for the review!
It seems the buildbot errors on Windows are all of this type: `fatal error
C1002: compiler is out of heap space in pass 2`.
> Is this merge not in main?
It is not. It depends on https://github.com/llvm/llvm-project/pull/85978, that
depends o
NimishMishra wrote:
Also, the PR shows "[luporl] wants to merge 1 commit into
[**llvm:users/luporl/refactor-default-test**]from [luporl:luporl-omp-implicit]"
Is this merge not in `main`?
https://github.com/llvm/llvm-project/pull/85989
___
llvm-branch
@@ -213,11 +213,10 @@ subroutine nested_default_clause_tests
!CHECK: omp.terminator
!CHECK: }
!CHECK: omp.parallel {
-!CHECK: %[[PRIVATE_INNER_Z:.*]] = fir.alloca i32 {bindc_name = "z", pinned,
uniq_name = "_QFnested_default_clause_testsEz"}
!CHECK: %[[PRIVATE_INNER_W:.*]] =
https://github.com/NimishMishra approved this pull request.
Thanks a lot for these changes. I went through the changes; the handling of
symbols in semantics seems particularly fine.
LGTM! The windows builtbot is failing, though Linux is passing.
https://github.com/llvm/llvm-project/pull/85989
https://github.com/NimishMishra edited
https://github.com/llvm/llvm-project/pull/85989
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
kiranchandramohan wrote:
I am away this week, will come back to this next week.
https://github.com/llvm/llvm-project/pull/85989
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm
llvmbot wrote:
@llvm/pr-subscribers-flang-semantics
@llvm/pr-subscribers-flang-openmp
Author: Leandro Lupori (luporl)
Changes
Handle implicit firstprivate DSAs on task generating constructs.
Fixes https://github.com/llvm/llvm-project/issues/64480
---
Patch is 42.19 KiB, truncated to 20
https://github.com/luporl created
https://github.com/llvm/llvm-project/pull/85989
Handle implicit firstprivate DSAs on task generating constructs.
Fixes https://github.com/llvm/llvm-project/issues/64480
>From 94301e00239b789cf90d5291b1d733f0f2baab6c Mon Sep 17 00:00:00 2001
From: Leandro Lupo
14 matches
Mail list logo
