ian-twilightcoder wrote:
I don't think this needs a release note, it's a pretty minor change.
https://github.com/llvm/llvm-project/pull/87374
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
tstellar wrote:
Hi @ian-twilightcoder (or anyone else). If you would like to add a note about
this fix in the release notes (completely optional). Please reply to this
comment with a one or two sentence description of the fix.
https://github.com/llvm/llvm-project/pull/87374
ldionne wrote:
> As mentioned on #86843, this breaks using `-pedantic` in code that includes
> libc++ headers. Since this got cherry-picked, we also must cherry-pick #88214.
I just started that process here:
https://github.com/llvm/llvm-project/pull/88214#issuecomment-2050203419
ian-twilightcoder wrote:
Well, I wish I would've known that. We cherry-picked it because it's a
regression that was introduced in LLVM 18, and I am worried that it will cause
issues on some platforms.
https://github.com/llvm/llvm-project/pull/87374
nico wrote:
As mentioned on #86843, this breaks using `-pedantic` in code that includes
libc++ headers. Since this got cherry-picked (…why? doesn't seem urgent?), we
also must cherry-pick #88214.
https://github.com/llvm/llvm-project/pull/87374
___
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/87374
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/87374
>From bffecba7ce4cf4e3e8b9961fb6dc84d6cf8f680e Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 2 Apr 2024 08:14:04 -0400
Subject: [PATCH] [libc++] Simplify the implementation of (#86843)
Libc++'s own
ian-twilightcoder wrote:
@tstellar what do you think? I'm a little nervous someone else will run into
mysterious errors where `rsize_t` isn't declared in C++ mode, and if they
aren't intimately familiar with the workings of the clang header they're going
to be very confused for a very long
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/87374
Backport 2950283dddab03c183c1be2d7de9d4999cc86131
Requested by: @ian-twilightcoder
>From 20cb23caea75d1d94e930ce0593eb92770f3c94d Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 2 Apr 2024 08:14:04
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/87374
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
10 matches
Mail list logo
