Author: James Henderson Date: 2021-01-25T09:58:56Z New Revision: b37a349ff2442e73ceafeee982afb430359e08b1
URL: https://github.com/llvm/llvm-project/commit/b37a349ff2442e73ceafeee982afb430359e08b1 DIFF: https://github.com/llvm/llvm-project/commit/b37a349ff2442e73ceafeee982afb430359e08b1.diff LOG: [lld][ELF][test] Add testing for IE/LD TLS weak undef references Whilst migrating/retiring some downstream testing, I came across a test for weak undef IE and LD TLS references, but was unable to find any equivalent in LLD's upstream testing. There does seem to be some slight subtle differences that could be worth testing compared to LE TLS references, in particular that IE can be relaxed to LE in this case, hence this change. Differential Revision: https://reviews.llvm.org/D95124 Reviewed by: grimar, MaskRay Added: lld/test/ELF/tls-weak-undef.s Modified: Removed: lld/test/ELF/tls-le-weak-undef.s ################################################################################ diff --git a/lld/test/ELF/tls-le-weak-undef.s b/lld/test/ELF/tls-le-weak-undef.s deleted file mode 100644 index fefda9da9816..000000000000 --- a/lld/test/ELF/tls-le-weak-undef.s +++ /dev/null @@ -1,18 +0,0 @@ -# REQUIRES: x86 -# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o -# RUN: echo '.tbss; .globl tls; tls:' | llvm-mc -filetype=obj -triple=x86_64 - -o %tdef.o -# RUN: ld.lld %t.o -o - | llvm-objdump -d - | FileCheck %s - -## A weak symbol does not fetch a lazy definition. -# RUN: ld.lld %t.o --start-lib %tdef.o --end-lib -o - | llvm-objdump -d - | FileCheck %s - -## Undefined TLS symbols arbitrarily resolve to 0. -# CHECK: leaq 16(%rax), %rdx - -# RUN: ld.lld -shared %tdef.o -o %tdef.so -# RUN: not ld.lld %t.o %tdef.so -o /dev/null 2>&1 | FileCheck --check-prefix=COPYRELOC %s - -# COPYRELOC: symbol 'tls' has no type - -.weak tls -leaq tls@tpoff+16(%rax), %rdx diff --git a/lld/test/ELF/tls-weak-undef.s b/lld/test/ELF/tls-weak-undef.s new file mode 100644 index 000000000000..19d1337c9fc8 --- /dev/null +++ b/lld/test/ELF/tls-weak-undef.s @@ -0,0 +1,42 @@ +# REQUIRES: x86 + +# RUN: split-file %s %t +# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/exec.s -o %texec.o +# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/shared.s -o %tshared.o +# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/ledef.s -o %tdef.o +# RUN: ld.lld %texec.o -o %t.exec +# RUN: ld.lld %tshared.o -o %t.shared --shared +# RUN: llvm-objdump -d %t.exec | FileCheck %s --check-prefix=EXEC +# RUN: llvm-objdump -d %t.shared | FileCheck %s --check-prefix=SHARED + +## An undefined weak TLS symbol does not fetch a lazy definition. +# RUN: ld.lld %texec.o --start-lib %tdef.o --end-lib -o %tlazy +# RUN: llvm-objdump -d %tlazy | FileCheck %s --check-prefix=EXEC + +## Undefined TLS symbols arbitrarily resolve to 0. +# EXEC: leaq 16(%rax), %rdx +## Initial-exec references to undefined weak symbols can be relaxed to LE +## references. +# EXEC: leaq 32(%rax), %rax +# SHARED: leaq 48(%rax), %rcx + +# RUN: ld.lld -shared %tdef.o -o %tdef.so +# RUN: not ld.lld %texec.o %tdef.so -o /dev/null 2>&1 | FileCheck --check-prefix=ERROR %s + +# ERROR: symbol 'le' has no type + +#--- ledef.s +.tbss +.globl le +le: + +#--- exec.s +.weak le +leaq le@tpoff+16(%rax), %rdx + +.weak ie +addq ie@gottpoff+32(%rip), %rax + +#--- shared.s +.weak ld +leaq ld@dtpoff+48(%rax), %rcx _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits