[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/16] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/16] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung edited https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/16] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/16] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/16] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/16] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/dcci commented: LG https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/16] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/15] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/15] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/15] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/14] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -43,6 +43,57 @@ class YAMLProfileReader : public ProfileReaderBase { using ProfileLookupMap = DenseMap; + /// A class for matching binary functions in functions in the YAML profile. + /// First, a call graph is constructed for both profiled and binary functions.

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/aaupov approved this pull request. LG with a couple of nits https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -43,6 +43,57 @@ class YAMLProfileReader : public ProfileReaderBase { using ProfileLookupMap = DenseMap; + /// A class for matching binary functions in functions in the YAML profile. + /// First, a call graph is constructed for both profiled and binary functions.

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung edited https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -446,6 +503,56 @@ size_t YAMLProfileReader::matchWithLTOCommonName() { return MatchedWithLTOCommonName; } +size_t YAMLProfileReader::matchWithCallGraph(BinaryContext &BC) { + if (!opts::MatchWithCallGraph) +return 0; + + size_t MatchedWithCallGraph = 0; + CGMatcher

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/13] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/12] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/11] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/11] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -446,6 +503,56 @@ size_t YAMLProfileReader::matchWithLTOCommonName() { return MatchedWithLTOCommonName; } +size_t YAMLProfileReader::matchWithCallGraph(BinaryContext &BC) { + if (!opts::MatchWithCallGraph) +return 0; + + size_t MatchedWithCallGraph = 0; + CGMatcher

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -568,12 +675,30 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) { } YamlProfileToFunction.resize(YamlBP.Functions.size() + 1); - // Computes hash for binary functions. + // Map profiled function ids to names. + for (yaml::bolt::BinaryFunctionProfile &YamlB

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -16,6 +16,37 @@ namespace llvm { namespace bolt { +/// A class for matching binary functions in functions in the YAML profile. +struct CallGraphMatcher { aaupov wrote: Let's make it a proper class https://github.com/llvm/llvm-project/pull/98125 __

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/aaupov commented: Thank you for working on this! It looks very good overall, left a couple of comments inline. Please run this new matching on a large binary to answer questions about runtime and matching quality in ambiguous cases. https://github.com/llvm/llvm-project/pull/

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -50,6 +54,59 @@ llvm::cl::opt ProfileUseDFS("profile-use-dfs", namespace llvm { namespace bolt { +void CallGraphMatcher::addBFCGEdges(BinaryContext &BC, +yaml::bolt::BinaryProfile &YamlBP, +BinaryFuncti

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -446,6 +503,56 @@ size_t YAMLProfileReader::matchWithLTOCommonName() { return MatchedWithLTOCommonName; } +size_t YAMLProfileReader::matchWithCallGraph(BinaryContext &BC) { + if (!opts::MatchWithCallGraph) +return 0; + + size_t MatchedWithCallGraph = 0; + CGMatcher

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -446,6 +503,56 @@ size_t YAMLProfileReader::matchWithLTOCommonName() { return MatchedWithLTOCommonName; } +size_t YAMLProfileReader::matchWithCallGraph(BinaryContext &BC) { + if (!opts::MatchWithCallGraph) +return 0; + + size_t MatchedWithCallGraph = 0; + CGMatcher

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -446,6 +503,56 @@ size_t YAMLProfileReader::matchWithLTOCommonName() { return MatchedWithLTOCommonName; } +size_t YAMLProfileReader::matchWithCallGraph(BinaryContext &BC) { + if (!opts::MatchWithCallGraph) +return 0; + + size_t MatchedWithCallGraph = 0; + CGMatcher

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -50,6 +54,59 @@ llvm::cl::opt ProfileUseDFS("profile-use-dfs", namespace llvm { namespace bolt { +void CallGraphMatcher::addBFCGEdges(BinaryContext &BC, +yaml::bolt::BinaryProfile &YamlBP, +BinaryFuncti

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -568,12 +675,30 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) { } YamlProfileToFunction.resize(YamlBP.Functions.size() + 1); - // Computes hash for binary functions. + // Map profiled function ids to names. + for (yaml::bolt::BinaryFunctionProfile &YamlB

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -446,6 +503,56 @@ size_t YAMLProfileReader::matchWithLTOCommonName() { return MatchedWithLTOCommonName; } +size_t YAMLProfileReader::matchWithCallGraph(BinaryContext &BC) { + if (!opts::MatchWithCallGraph) +return 0; + + size_t MatchedWithCallGraph = 0; + CGMatcher

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/dcci edited https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

@@ -16,6 +16,37 @@ namespace llvm { namespace bolt { +/// A class for matching binary functions in functions in the YAML profile. dcci wrote: I think it would be useful to add a general description of the algorithm, in particular if you have a reference to t

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/dcci commented: This is heading in the right direction. https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bran

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/11] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung ready_for_review https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung edited https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung edited https://github.com/llvm/llvm-project/pull/98125 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 01/10] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAML

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 1/9] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAMLPr

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 1/8] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAMLPr

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 1/7] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAMLPr

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 1/6] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAMLPr

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 1/3] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAMLPr

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH 1/2] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAMLPr

[llvm-branch-commits] [llvm] [BOLT] Match functions with call graph (PR #98125)

https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/98125 >From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Tue, 9 Jul 2024 10:04:25 -0700 Subject: [PATCH] Comments Created using spr 1.3.4 --- bolt/lib/Profile/YAMLProfil