https://github.com/mtrofin edited
https://github.com/llvm/llvm-project/pull/78880
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/mtrofin approved this pull request.
LGTM, some nits
https://github.com/llvm/llvm-project/pull/78880
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
@@ -156,10 +88,86 @@ def main(argv):
)
-def entrypoint():
-multiprocessing.set_start_method("fork")
-app.run(main)
-
-
if __name__ == "__main__":
-entrypoint()
+parser = argparse.ArgumentParser(
mtrofin wrote:
nit: could you factor all
@@ -12,43 +12,38 @@
--default_args=""
"""
-from absl import app
-from absl import flags
-from absl import logging
+import logging
+import argparse
mtrofin wrote:
can the imports be in alphabetical order, or does `black` not do that for us?
llvmbot wrote:
@llvm/pr-subscribers-mlgo
Author: Aiden Grossman (boomanaiden154)
Changes
This patch removes the absl dependency from the mlgo-utils scripts. We were
only using absl.logging, and absl.flags, so this patch just consists of
mechanically converting the absl flags parsing to
https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/78880
>From 9dfc0ac712315f232e69496b7f8c0aed20421626 Mon Sep 17 00:00:00 2001
From: Aiden Grossman
Date: Sun, 21 Jan 2024 06:08:28 +
Subject: [PATCH 1/2] [MLGO] Remove absl dependency from scripts
This
https://github.com/boomanaiden154 created
https://github.com/llvm/llvm-project/pull/78880
This patch removes the absl dependency from the mlgo-utils scripts. We were
only using absl.logging, and absl.flags, so this patch just consists of
mechanically converting the absl flags parsing to
