https://github.com/dobbelaj-snps approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/81289
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
@@ -4561,6 +4577,10 @@ bool SROA::presplitLoadsAndStores(AllocaInst ,
AllocaSlices ) {
PStore->copyMetadata(*SI, {LLVMContext::MD_mem_parallel_loop_access,
LLVMContext::MD_access_group,
https://github.com/fhahn commented:
@dobbelaj-snps Added a substantial number of tests that should cover all cases
now in 2a9b86cc10c3883cca51a5166aad6e2b755fa958
https://github.com/llvm/llvm-project/pull/81289
___
llvm-branch-commits mailing list
@@ -4561,6 +4577,10 @@ bool SROA::presplitLoadsAndStores(AllocaInst ,
AllocaSlices ) {
PStore->copyMetadata(*SI, {LLVMContext::MD_mem_parallel_loop_access,
LLVMContext::MD_access_group,
https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/81289
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/81289
>From 90639e9131670863ebb4c199a9861b2b0094d601 Mon Sep 17 00:00:00 2001
From: Florian Hahn
Date: Fri, 9 Feb 2024 15:17:09 +
Subject: [PATCH 1/2] [SROA] Use !tbaa instead of !tbaa.struct if op matches
field.
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/81289
>From 90639e9131670863ebb4c199a9861b2b0094d601 Mon Sep 17 00:00:00 2001
From: Florian Hahn
Date: Fri, 9 Feb 2024 15:17:09 +
Subject: [PATCH] [SROA] Use !tbaa instead of !tbaa.struct if op matches field.
If a
dobbelaj-snps wrote:
> > Hmm. 10 changes + 1 new usage of setAAMetaData, But only 4 relevant changes
> > in tests.. That part of SROA seems to lack some testing ?
>
> Yes, will add the missing coverage, just wanted to make sure this makes sense
> in general beforehand
I think it makes sense.
fhahn wrote:
> Hmm. 10 changes + 1 new usage of setAAMetaData, But only 4 relevant changes
> in tests.. That part of SROA seems to lack some testing ?
Yes, will add the missing coverage, just wanted to make sure this makes sense
in general beforehand
@@ -7,9 +7,9 @@ define void @load_store_transfer_split_struct_tbaa_2_float(ptr
dereferenceable(2
; CHECK-NEXT: entry:
; CHECK-NEXT:[[TMP0:%.*]] = bitcast float [[A]] to i32
; CHECK-NEXT:[[TMP1:%.*]] = bitcast float [[B]] to i32
-; CHECK-NEXT:store i32 [[TMP0]],
dobbelaj-snps wrote:
Hmm. 10 changes + 1 new usage of setAAMetaData, But only 4 relevant changes in
tests.. That part of SROA might seems to lack some testing ?
https://github.com/llvm/llvm-project/pull/81289
___
llvm-branch-commits mailing list
@@ -7,9 +7,9 @@ define void @load_store_transfer_split_struct_tbaa_2_float(ptr
dereferenceable(2
; CHECK-NEXT: entry:
; CHECK-NEXT:[[TMP0:%.*]] = bitcast float [[A]] to i32
; CHECK-NEXT:[[TMP1:%.*]] = bitcast float [[B]] to i32
-; CHECK-NEXT:store i32 [[TMP0]],
@@ -4561,6 +4577,10 @@ bool SROA::presplitLoadsAndStores(AllocaInst ,
AllocaSlices ) {
PStore->copyMetadata(*SI, {LLVMContext::MD_mem_parallel_loop_access,
LLVMContext::MD_access_group,
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
@llvm/pr-subscribers-llvm-transforms
Author: Florian Hahn (fhahn)
Changes
If a split memory access introduced by SROA accesses precisely a single field
of the original operation's !tbaa.struct, use the !tbaa tag for the accessed
field directly
https://github.com/fhahn created https://github.com/llvm/llvm-project/pull/81289
If a split memory access introduced by SROA accesses precisely a single field
of the original operation's !tbaa.struct, use the !tbaa tag for the accessed
field directly instead of the full !tbaa.struct.
15 matches
Mail list logo
