[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/77221 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

@@ -1279,9 +1278,6 @@ bool AddressSanitizer::isInterestingAlloca(const AllocaInst ) { (AI.getAllocatedType()->isSized() && vitalybuka wrote: Yes, either keep as ClSkipPromotableAllocas=false, just in case, or remove it. Something similar but not the same

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/77221 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/77221 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/77221 >From 46d21cd0327e352491be77bb86740167984c0209 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 14 Feb 2024 23:26:34 -0800 Subject: [PATCH 1/2] fix cl::desc Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/77221 >From 46d21cd0327e352491be77bb86740167984c0209 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 14 Feb 2024 23:26:34 -0800 Subject: [PATCH] fix cl::desc Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/77221 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/77221 >From 46d21cd0327e352491be77bb86740167984c0209 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 14 Feb 2024 23:26:34 -0800 Subject: [PATCH] fix cl::desc Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/77221 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

@@ -1279,9 +1278,6 @@ bool AddressSanitizer::isInterestingAlloca(const AllocaInst ) { (AI.getAllocatedType()->isSized() && MaskRay wrote: In `ClInstrumentUninterestingAllocas=0 mode`, `!(SSGI && SSGI->isSafe(AI))` can ignore some `AllocaInst`s that

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

vitalybuka wrote: > We can set `-mllvm -stack-safety-run` to force `getInfo`, but it seems that > the current lazy `getInfo` works as intended once this patch is applied. No, we don't need any new flag. We need to trigger getInfo before any module modification, e.g. at getResult if some

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

@@ -1279,9 +1278,6 @@ bool AddressSanitizer::isInterestingAlloca(const AllocaInst ) { (AI.getAllocatedType()->isSized() && vitalybuka wrote: ClSkipPromotableAllocas on line 1315 is confusing, and maybe unnecessary? but after your rename it's still

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

@@ -1279,9 +1278,6 @@ bool AddressSanitizer::isInterestingAlloca(const AllocaInst ) { (AI.getAllocatedType()->isSized() && vitalybuka wrote: isInterestingAlloca contains other checks. There is no point to have a flag to enable instrumentation of allocas

[llvm-branch-commits] [llvm] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/77221 >From 46d21cd0327e352491be77bb86740167984c0209 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 14 Feb 2024 23:26:34 -0800 Subject: [PATCH] fix cl::desc Created using spr 1.3.4 ---