[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/92468 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/92468 >From 3d0752b9492efd60e85aedec79676596af6fb4f8 Mon Sep 17 00:00:00 2001 From: DianQK Date: Fri, 17 May 2024 05:51:49 +0800 Subject: [PATCH] [GlobalOpt] Don't replace aliasee with alias that has weak linkage

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

DianQK wrote: > > Per [#91483 > > (comment)](https://github.com/llvm/llvm-project/pull/91483#issuecomment-2116394616), > > we still need to further investigate this issue, but it won't stop us from > > backporting it. > > cc @MaskRay > > What exactly does this mean? Was there a bug in the

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

tstellar wrote: > Per [#91483 > (comment)](https://github.com/llvm/llvm-project/pull/91483#issuecomment-2116394616), > we still need to further investigate this issue, but it won't stop us from > backporting it. > > cc @MaskRay What exactly does this mean? Was there a bug in the original

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

DianQK wrote: Per https://github.com/llvm/llvm-project/pull/91483#issuecomment-2116394616, we still need to further investigate this issue, but it won't stop us from backporting it. cc @MaskRay https://github.com/llvm/llvm-project/pull/92468 ___

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

DianQK wrote: Release note (maybe): Do not replace an aliasee with an alias that has weak linkage, as this prevents the selection of incorrect symbols during the linking time. @tstellar https://github.com/llvm/llvm-project/pull/92468 ___

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

DianQK wrote: > As noted on the original pull request, this also affects some cases which > might be safe to optimize (a weak alias where the aliasee is an internal > symbol with no other references). But "optimizing" those cases doesn't really > have any useful effect, anyway: it doesn't

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

https://github.com/efriedma-quic approved this pull request. LGTM This only affects optimizations on weak aliases, and the logic is very simple: just don't optimize them. As noted on the original pull request, this also affects some cases which might be safe to optimize (a weak alias where

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: None (llvmbot) Changes Backport c79690040acf5bb3d857558b0878db47f7f23dc3 Requested by: @DianQK --- Full diff: https://github.com/llvm/llvm-project/pull/92468.diff 2 Files Affected: - (modified)

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

llvmbot wrote: @efriedma-quic What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/92468 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/92468 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [GlobalOpt] Don't replace aliasee with alias that has weak linkage (#91483) (PR #92468)

https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/92468 Backport c79690040acf5bb3d857558b0878db47f7f23dc3 Requested by: @DianQK >From 012e13b1594ba19058294d793993ad8da14c9159 Mon Sep 17 00:00:00 2001 From: DianQK Date: Fri, 17 May 2024 05:51:49 +0800 Subject: