https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/86099
>From ad1b2ac46a744887594e13370762939034797d31 Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Sat, 23 Mar 2024 05:57:33 +
Subject: [PATCH] [mlir][Interfaces][NFC] `ValueBoundsConstraintSet`:
https://github.com/MacDue approved this pull request.
https://github.com/llvm/llvm-project/pull/86099
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -113,8 +113,9 @@ class ValueBoundsConstraintSet {
///
/// The first parameter of the function is the shaped value/index-typed
/// value. The second parameter is the dimension in case of a shaped value.
- using StopConditionFn =
- function_ref /*dim*/)>;
+ /// Th
@@ -316,6 +317,9 @@ class ValueBoundsConstraintSet {
/// Builder for constructing affine expressions.
Builder builder;
+
+ /// The current stop condition function.
+ StopConditionFn stopCondition = nullptr;
matthias-springer wrote:
Actually I ran into t
https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/86099
>From 305001b6211f48e7643c34805e7008126a539b49 Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Fri, 22 Mar 2024 02:01:00 +
Subject: [PATCH] [mlir][Interfaces][NFC] `ValueBoundsConstraintSet`:
@@ -316,6 +317,9 @@ class ValueBoundsConstraintSet {
/// Builder for constructing affine expressions.
Builder builder;
+
+ /// The current stop condition function.
+ StopConditionFn stopCondition = nullptr;
MacDue wrote:
Just wondering if this should be
llvmbot wrote:
@llvm/pr-subscribers-mlir-scf
Author: Matthias Springer (matthias-springer)
Changes
This commit changes the API of `ValueBoundsConstraintSet`: the stop condition
is now passed to the constructor instead of `processWorklist`. That makes it
easier to add items to the worklis
https://github.com/matthias-springer created
https://github.com/llvm/llvm-project/pull/86099
This commit changes the API of `ValueBoundsConstraintSet`: the stop condition
is now passed to the constructor instead of `processWorklist`. That makes it
easier to add items to the worklist multiple t
llvmbot wrote:
@llvm/pr-subscribers-mlir-linalg
@llvm/pr-subscribers-mlir-arith
Author: Matthias Springer (matthias-springer)
Changes
This commit changes the API of `ValueBoundsConstraintSet`: the stop condition
is now passed to the constructor instead of `processWorklist`. That makes it
